2015-07-08 12:44:52

by Ana Calinov

[permalink] [raw]
Subject: [PATCH] iio: accel: kxcjk-1013: Remove blank lines

This patch fixes the the following errors given by
checkpatch.pl with --strict:
Please don't use multiple blank lines.
Blank lines aren't necessary after an open brace '{'.

Signed-off-by: Ana Calinov <[email protected]>
---
drivers/iio/accel/kxcjk-1013.c | 3 ---
1 file changed, 3 deletions(-)

diff --git a/drivers/iio/accel/kxcjk-1013.c b/drivers/iio/accel/kxcjk-1013.c
index 567de26..f069c41 100644
--- a/drivers/iio/accel/kxcjk-1013.c
+++ b/drivers/iio/accel/kxcjk-1013.c
@@ -658,10 +658,8 @@ static int kxcjk1013_set_scale(struct kxcjk1013_data *data, int val)
int ret, i;
enum kxcjk1013_mode store_mode;

-
for (i = 0; i < ARRAY_SIZE(KXCJK1013_scale_table); ++i) {
if (KXCJK1013_scale_table[i].scale == val) {
-
ret = kxcjk1013_get_mode(data, &store_mode);
if (ret < 0)
return ret;
@@ -820,7 +818,6 @@ static int kxcjk1013_read_event_config(struct iio_dev *indio_dev,
enum iio_event_type type,
enum iio_event_direction dir)
{
-
struct kxcjk1013_data *data = iio_priv(indio_dev);

return data->ev_enable_state;
--
2.1.0


2015-07-08 12:56:05

by Daniel Baluta

[permalink] [raw]
Subject: Re: [PATCH] iio: accel: kxcjk-1013: Remove blank lines

On Wed, Jul 8, 2015 at 3:44 PM, Ana Calinov <[email protected]> wrote:
> This patch fixes the the following errors given by
> checkpatch.pl with --strict:
> Please don't use multiple blank lines.
> Blank lines aren't necessary after an open brace '{'.
>
> Signed-off-by: Ana Calinov <[email protected]>


Looks good to me.

Reviewed-by: Daniel Baluta <[email protected]>

Thanks Ana!

Daniel.

2015-07-11 17:27:43

by Jonathan Cameron

[permalink] [raw]
Subject: Re: [PATCH] iio: accel: kxcjk-1013: Remove blank lines

On 08/07/15 13:56, Daniel Baluta wrote:
> On Wed, Jul 8, 2015 at 3:44 PM, Ana Calinov <[email protected]> wrote:
>> This patch fixes the the following errors given by
>> checkpatch.pl with --strict:
>> Please don't use multiple blank lines.
>> Blank lines aren't necessary after an open brace '{'.
>>
>> Signed-off-by: Ana Calinov <[email protected]>
>
>
> Looks good to me.
>
> Reviewed-by: Daniel Baluta <[email protected]>
>
> Thanks Ana!
>
> Daniel.
>
Applied to the togreg branch of iio.git. Will push out
as testing for the autobuilders to play with it.

A sensible checkpatch based cleanup. Thanks

Jonathan