Hi all,
In commit
593425276b94 ("PCI: endpoint: functions: Use memcpy_fromio()/memcpy_toio()")
Fixes tag
Fixes: 349e7a85b25f ("PCI: endpoint: functions: Add an EP function to
has these problem(s):
- Subject has leading but no trailing parentheses
- Subject has leading but no trailing quotes
Please do not split Fixes tags over more than 1 line.
--
Cheers,
Stephen Rothwell
On Wed, Feb 13, 2019 at 10:03:09AM +1100, Stephen Rothwell wrote:
> Hi all,
>
> In commit
>
> 593425276b94 ("PCI: endpoint: functions: Use memcpy_fromio()/memcpy_toio()")
>
> Fixes tag
>
> Fixes: 349e7a85b25f ("PCI: endpoint: functions: Add an EP function to
>
> has these problem(s):
>
> - Subject has leading but no trailing parentheses
> - Subject has leading but no trailing quotes
>
> Please do not split Fixes tags over more than 1 line.
It is my mistake, apologies, I will fix the commit log up.
Thanks,
Lorenzo
On Tue, Feb 12, 2019 at 5:03 PM Stephen Rothwell <[email protected]> wrote:
>
> Hi all,
>
> In commit
>
> 593425276b94 ("PCI: endpoint: functions: Use memcpy_fromio()/memcpy_toio()")
>
> Fixes tag
>
> Fixes: 349e7a85b25f ("PCI: endpoint: functions: Add an EP function to
>
> has these problem(s):
>
> - Subject has leading but no trailing parentheses
> - Subject has leading but no trailing quotes
>
> Please do not split Fixes tags over more than 1 line.
Hi Stephen,
Are these and similar warnings generated by commit hooks or similar
scripts? If so, do you publish them somewhere? I'd like to be able
to set up commit hooks to catch things like this before they get to
you.
Bjorn
Hi Bjorn,
On Wed, 13 Feb 2019 08:31:46 -0600 Bjorn Helgaas <[email protected]> wrote:
>
> Are these and similar warnings generated by commit hooks or similar
> scripts? If so, do you publish them somewhere? I'd like to be able
> to set up commit hooks to catch things like this before they get to
> you.
I run the attached script over the new commits in each tree each day ...
--
Cheers,
Stephen Rothwell
On Wed, Feb 13, 2019 at 2:10 PM Stephen Rothwell <[email protected]> wrote:
>
> Hi Bjorn,
>
> On Wed, 13 Feb 2019 08:31:46 -0600 Bjorn Helgaas <[email protected]> wrote:
> >
> > Are these and similar warnings generated by commit hooks or similar
> > scripts? If so, do you publish them somewhere? I'd like to be able
> > to set up commit hooks to catch things like this before they get to
> > you.
>
> I run the attached script over the new commits in each tree each day ...
Thanks, I guess now I have no more excuse :)
Is the "missing a Signed-off-by from their committer" thing that I
regularly trip over a manual check?
Bjorn
Hi Bjorn,
On Wed, 13 Feb 2019 14:19:32 -0600 Bjorn Helgaas <[email protected]> wrote:
>
> Thanks, I guess now I have no more excuse :)
:-)
> Is the "missing a Signed-off-by from their committer" thing that I
> regularly trip over a manual check?
Ah, attached is the other script I run (maybe I should combine them).
--
Cheers,
Stephen Rothwell