2022-11-18 14:48:22

by Neil Armstrong

Subject: [PATCH 05/12] dt-bindings: media: convert meson-ir.txt to dt-schema

Convert the Amlogic Meson IR remote control receiver bindings to
dt-schema.

Signed-off-by: Neil Armstrong <[email protected]>
---
.../bindings/media/amlogic,meson6-ir.yaml | 43 ++++++++++++++++++++++
.../devicetree/bindings/media/meson-ir.txt | 20 ----------
2 files changed, 43 insertions(+), 20 deletions(-)

diff --git a/Documentation/devicetree/bindings/media/amlogic,meson6-ir.yaml b/Documentation/devicetree/bindings/media/amlogic,meson6-ir.yaml
new file mode 100644
index 000000000000..f8bc445b1f25
--- /dev/null
+++ b/Documentation/devicetree/bindings/media/amlogic,meson6-ir.yaml
@@ -0,0 +1,43 @@
+# SPDX-License-Identifier: (GPL-2.0-only OR BSD-2-Clause)
+%YAML 1.2
+---
+$id: http://devicetree.org/schemas/media/amlogic,meson6-ir.yaml#
+$schema: http://devicetree.org/meta-schemas/core.yaml#
+
+title: Amlogic Meson IR remote control receiver
+
+maintainers:
+ - Neil Armstrong <[email protected]>
+
+allOf:
+ - $ref: rc.yaml#
+
+properties:
+ compatible:
+ enum:
+ - amlogic,meson6-ir
+ - amlogic,meson8b-ir
+ - amlogic,meson-gxbb-ir
+
+ reg:
+ maxItems: 1
+
+ interrupts:
+ maxItems: 1
+
+required:
+ - compatible
+ - reg
+ - interrupts
+
+unevaluatedProperties: false
+
+examples:
+ - |
+ #include <dt-bindings/interrupt-controller/irq.h>
+ #include <dt-bindings/interrupt-controller/arm-gic.h>
+ ir-receiver@c8100480 {
+ compatible = "amlogic,meson6-ir";
+ reg = <0xc8100480 0x20>;
+ interrupts = <GIC_SPI 15 IRQ_TYPE_EDGE_RISING>;
+ };
diff --git a/Documentation/devicetree/bindings/media/meson-ir.txt b/Documentation/devicetree/bindings/media/meson-ir.txt
deleted file mode 100644
index efd9d29a8f10..000000000000
--- a/Documentation/devicetree/bindings/media/meson-ir.txt
+++ /dev/null
@@ -1,20 +0,0 @@
-* Amlogic Meson IR remote control receiver
-
-Required properties:
- - compatible : depending on the platform this should be one of:
- - "amlogic,meson6-ir"
- - "amlogic,meson8b-ir"
- - "amlogic,meson-gxbb-ir"
- - reg : physical base address and length of the device registers
- - interrupts : a single specifier for the interrupt from the device
-
-Optional properties:
- - linux,rc-map-name: see rc.txt file in the same directory.
-
-Example:
-
- ir-receiver@c8100480 {
- compatible= "amlogic,meson6-ir";
- reg = <0xc8100480 0x20>;
- interrupts = <0 15 1>;
- };

--
b4 0.10.1

2022-11-18 15:07:09

by Krzysztof Kozlowski

Subject: Re: [PATCH 05/12] dt-bindings: media: convert meson-ir.txt to dt-schema

On 18/11/2022 15:33, Neil Armstrong wrote:
> Convert the Amlogic Meson IR remote control receiver bindings to
> dt-schema.
>
> Signed-off-by: Neil Armstrong <[email protected]>
> ---
> .../bindings/media/amlogic,meson6-ir.yaml | 43 ++++++++++++++++++++++
> .../devicetree/bindings/media/meson-ir.txt | 20 --------


Reviewed-by: Krzysztof Kozlowski <[email protected]>

Best regards,
Krzysztof

2022-11-18 19:02:33

by Rob Herring (Arm)

Subject: Re: [PATCH 05/12] dt-bindings: media: convert meson-ir.txt to dt-schema

On Fri, 18 Nov 2022 15:33:31 +0100, Neil Armstrong wrote:
> Convert the Amlogic Meson IR remote control receiver bindings to
> dt-schema.
>
> Signed-off-by: Neil Armstrong <[email protected]>
> ---
> .../bindings/media/amlogic,meson6-ir.yaml | 43 ++++++++++++++++++++++
> .../devicetree/bindings/media/meson-ir.txt | 20 ----------
> 2 files changed, 43 insertions(+), 20 deletions(-)
>

Running 'make dtbs_check' with the schema in this patch gives the
following warnings. Consider if they are expected or the schema is
incorrect. These may not be new warnings.

Note that it is not yet a requirement to have 0 warnings for dtbs_check.
This will change in the future.

Full log is available here: https://patchwork.ozlabs.org/project/devicetree-bindings/patch/20221117-b4-amlogic-bindings-convert-v1-5-3f025599b968@linaro.org


ir@580: compatible:0: 'amlogic,meson-gx-ir' is not one of ['amlogic,meson6-ir', 'amlogic,meson8b-ir', 'amlogic,meson-gxbb-ir']
arch/arm64/boot/dts/amlogic/meson-gxbb-kii-pro.dtb
arch/arm64/boot/dts/amlogic/meson-gxbb-nanopi-k2.dtb
arch/arm64/boot/dts/amlogic/meson-gxbb-nexbox-a95x.dtb
arch/arm64/boot/dts/amlogic/meson-gxbb-odroidc2.dtb
arch/arm64/boot/dts/amlogic/meson-gxbb-p200.dtb
arch/arm64/boot/dts/amlogic/meson-gxbb-p201.dtb
arch/arm64/boot/dts/amlogic/meson-gxbb-vega-s95-meta.dtb
arch/arm64/boot/dts/amlogic/meson-gxbb-vega-s95-pro.dtb
arch/arm64/boot/dts/amlogic/meson-gxbb-vega-s95-telos.dtb
arch/arm64/boot/dts/amlogic/meson-gxbb-wetek-hub.dtb
arch/arm64/boot/dts/amlogic/meson-gxbb-wetek-play2.dtb
arch/arm64/boot/dts/amlogic/meson-gxl-s805x-libretech-ac.dtb
arch/arm64/boot/dts/amlogic/meson-gxl-s805x-p241.dtb
arch/arm64/boot/dts/amlogic/meson-gxl-s905d-libretech-pc.dtb
arch/arm64/boot/dts/amlogic/meson-gxl-s905d-mecool-kii-pro.dtb
arch/arm64/boot/dts/amlogic/meson-gxl-s905d-p230.dtb
arch/arm64/boot/dts/amlogic/meson-gxl-s905d-p231.dtb
arch/arm64/boot/dts/amlogic/meson-gxl-s905d-phicomm-n1.dtb
arch/arm64/boot/dts/amlogic/meson-gxl-s905d-sml5442tw.dtb
arch/arm64/boot/dts/amlogic/meson-gxl-s905d-vero4k-plus.dtb
arch/arm64/boot/dts/amlogic/meson-gxl-s905w-jethome-jethub-j80.dtb
arch/arm64/boot/dts/amlogic/meson-gxl-s905w-p281.dtb
arch/arm64/boot/dts/amlogic/meson-gxl-s905w-tx3-mini.dtb
arch/arm64/boot/dts/amlogic/meson-gxl-s905x-hwacom-amazetv.dtb
arch/arm64/boot/dts/amlogic/meson-gxl-s905x-khadas-vim.dtb
arch/arm64/boot/dts/amlogic/meson-gxl-s905x-libretech-cc.dtb
arch/arm64/boot/dts/amlogic/meson-gxl-s905x-libretech-cc-v2.dtb
arch/arm64/boot/dts/amlogic/meson-gxl-s905x-nexbox-a95x.dtb
arch/arm64/boot/dts/amlogic/meson-gxl-s905x-p212.dtb
arch/arm64/boot/dts/amlogic/meson-gxm-gt1-ultimate.dtb
arch/arm64/boot/dts/amlogic/meson-gxm-khadas-vim2.dtb
arch/arm64/boot/dts/amlogic/meson-gxm-mecool-kiii-pro.dtb
arch/arm64/boot/dts/amlogic/meson-gxm-minix-neo-u9h.dtb
arch/arm64/boot/dts/amlogic/meson-gxm-nexbox-a1.dtb
arch/arm64/boot/dts/amlogic/meson-gxm-q200.dtb
arch/arm64/boot/dts/amlogic/meson-gxm-q201.dtb
arch/arm64/boot/dts/amlogic/meson-gxm-rbox-pro.dtb
arch/arm64/boot/dts/amlogic/meson-gxm-s912-libretech-pc.dtb
arch/arm64/boot/dts/amlogic/meson-gxm-vega-s96.dtb
arch/arm64/boot/dts/amlogic/meson-gxm-wetek-core2.dtb

ir@580: compatible: ['amlogic,meson-gx-ir', 'amlogic,meson-gxbb-ir'] is too long
arch/arm64/boot/dts/amlogic/meson-gxbb-kii-pro.dtb
arch/arm64/boot/dts/amlogic/meson-gxbb-nanopi-k2.dtb
arch/arm64/boot/dts/amlogic/meson-gxbb-nexbox-a95x.dtb
arch/arm64/boot/dts/amlogic/meson-gxbb-odroidc2.dtb
arch/arm64/boot/dts/amlogic/meson-gxbb-p200.dtb
arch/arm64/boot/dts/amlogic/meson-gxbb-p201.dtb
arch/arm64/boot/dts/amlogic/meson-gxbb-vega-s95-meta.dtb
arch/arm64/boot/dts/amlogic/meson-gxbb-vega-s95-pro.dtb
arch/arm64/boot/dts/amlogic/meson-gxbb-vega-s95-telos.dtb
arch/arm64/boot/dts/amlogic/meson-gxbb-wetek-hub.dtb
arch/arm64/boot/dts/amlogic/meson-gxbb-wetek-play2.dtb
arch/arm64/boot/dts/amlogic/meson-gxl-s805x-libretech-ac.dtb
arch/arm64/boot/dts/amlogic/meson-gxl-s805x-p241.dtb
arch/arm64/boot/dts/amlogic/meson-gxl-s905d-libretech-pc.dtb
arch/arm64/boot/dts/amlogic/meson-gxl-s905d-mecool-kii-pro.dtb
arch/arm64/boot/dts/amlogic/meson-gxl-s905d-p230.dtb
arch/arm64/boot/dts/amlogic/meson-gxl-s905d-p231.dtb
arch/arm64/boot/dts/amlogic/meson-gxl-s905d-phicomm-n1.dtb
arch/arm64/boot/dts/amlogic/meson-gxl-s905d-sml5442tw.dtb
arch/arm64/boot/dts/amlogic/meson-gxl-s905d-vero4k-plus.dtb
arch/arm64/boot/dts/amlogic/meson-gxl-s905w-jethome-jethub-j80.dtb
arch/arm64/boot/dts/amlogic/meson-gxl-s905w-p281.dtb
arch/arm64/boot/dts/amlogic/meson-gxl-s905w-tx3-mini.dtb
arch/arm64/boot/dts/amlogic/meson-gxl-s905x-hwacom-amazetv.dtb
arch/arm64/boot/dts/amlogic/meson-gxl-s905x-khadas-vim.dtb
arch/arm64/boot/dts/amlogic/meson-gxl-s905x-libretech-cc.dtb
arch/arm64/boot/dts/amlogic/meson-gxl-s905x-libretech-cc-v2.dtb
arch/arm64/boot/dts/amlogic/meson-gxl-s905x-nexbox-a95x.dtb
arch/arm64/boot/dts/amlogic/meson-gxl-s905x-p212.dtb
arch/arm64/boot/dts/amlogic/meson-gxm-gt1-ultimate.dtb
arch/arm64/boot/dts/amlogic/meson-gxm-khadas-vim2.dtb
arch/arm64/boot/dts/amlogic/meson-gxm-mecool-kiii-pro.dtb
arch/arm64/boot/dts/amlogic/meson-gxm-minix-neo-u9h.dtb
arch/arm64/boot/dts/amlogic/meson-gxm-nexbox-a1.dtb
arch/arm64/boot/dts/amlogic/meson-gxm-q200.dtb
arch/arm64/boot/dts/amlogic/meson-gxm-q201.dtb
arch/arm64/boot/dts/amlogic/meson-gxm-rbox-pro.dtb
arch/arm64/boot/dts/amlogic/meson-gxm-s912-libretech-pc.dtb
arch/arm64/boot/dts/amlogic/meson-gxm-vega-s96.dtb
arch/arm64/boot/dts/amlogic/meson-gxm-wetek-core2.dtb

ir@580: Unevaluated properties are not allowed ('compatible' was unexpected)
arch/arm64/boot/dts/amlogic/meson-gxbb-kii-pro.dtb
arch/arm64/boot/dts/amlogic/meson-gxbb-nanopi-k2.dtb
arch/arm64/boot/dts/amlogic/meson-gxbb-nexbox-a95x.dtb
arch/arm64/boot/dts/amlogic/meson-gxbb-odroidc2.dtb
arch/arm64/boot/dts/amlogic/meson-gxbb-p200.dtb
arch/arm64/boot/dts/amlogic/meson-gxbb-p201.dtb
arch/arm64/boot/dts/amlogic/meson-gxbb-vega-s95-meta.dtb
arch/arm64/boot/dts/amlogic/meson-gxbb-vega-s95-pro.dtb
arch/arm64/boot/dts/amlogic/meson-gxbb-vega-s95-telos.dtb
arch/arm64/boot/dts/amlogic/meson-gxbb-wetek-hub.dtb
arch/arm64/boot/dts/amlogic/meson-gxbb-wetek-play2.dtb
arch/arm64/boot/dts/amlogic/meson-gxl-s805x-libretech-ac.dtb
arch/arm64/boot/dts/amlogic/meson-gxl-s805x-p241.dtb
arch/arm64/boot/dts/amlogic/meson-gxl-s905d-libretech-pc.dtb
arch/arm64/boot/dts/amlogic/meson-gxl-s905d-mecool-kii-pro.dtb
arch/arm64/boot/dts/amlogic/meson-gxl-s905d-p230.dtb
arch/arm64/boot/dts/amlogic/meson-gxl-s905d-p231.dtb
arch/arm64/boot/dts/amlogic/meson-gxl-s905d-phicomm-n1.dtb
arch/arm64/boot/dts/amlogic/meson-gxl-s905d-sml5442tw.dtb
arch/arm64/boot/dts/amlogic/meson-gxl-s905d-vero4k-plus.dtb
arch/arm64/boot/dts/amlogic/meson-gxl-s905w-jethome-jethub-j80.dtb
arch/arm64/boot/dts/amlogic/meson-gxl-s905w-p281.dtb
arch/arm64/boot/dts/amlogic/meson-gxl-s905w-tx3-mini.dtb
arch/arm64/boot/dts/amlogic/meson-gxl-s905x-hwacom-amazetv.dtb
arch/arm64/boot/dts/amlogic/meson-gxl-s905x-khadas-vim.dtb
arch/arm64/boot/dts/amlogic/meson-gxl-s905x-libretech-cc.dtb
arch/arm64/boot/dts/amlogic/meson-gxl-s905x-libretech-cc-v2.dtb
arch/arm64/boot/dts/amlogic/meson-gxl-s905x-nexbox-a95x.dtb
arch/arm64/boot/dts/amlogic/meson-gxl-s905x-p212.dtb
arch/arm64/boot/dts/amlogic/meson-gxm-gt1-ultimate.dtb
arch/arm64/boot/dts/amlogic/meson-gxm-khadas-vim2.dtb
arch/arm64/boot/dts/amlogic/meson-gxm-mecool-kiii-pro.dtb
arch/arm64/boot/dts/amlogic/meson-gxm-minix-neo-u9h.dtb
arch/arm64/boot/dts/amlogic/meson-gxm-nexbox-a1.dtb
arch/arm64/boot/dts/amlogic/meson-gxm-q200.dtb
arch/arm64/boot/dts/amlogic/meson-gxm-q201.dtb
arch/arm64/boot/dts/amlogic/meson-gxm-rbox-pro.dtb
arch/arm64/boot/dts/amlogic/meson-gxm-s912-libretech-pc.dtb
arch/arm64/boot/dts/amlogic/meson-gxm-vega-s96.dtb
arch/arm64/boot/dts/amlogic/meson-gxm-wetek-core2.dtb

2022-11-26 00:21:22

by Martin Blumenstingl

Subject: Re: [PATCH 05/12] dt-bindings: media: convert meson-ir.txt to dt-schema

Hi Neil,

On Fri, Nov 18, 2022 at 3:33 PM Neil Armstrong
<[email protected]> wrote:
>
> Convert the Amlogic Meson IR remote control receiver bindings to
> dt-schema.
>
> Signed-off-by: Neil Armstrong <[email protected]>
Reviewed-by: Martin Blumenstingl <[email protected]>

Before this is applied we need an additional patch removing the
un-documented "amlogic,meson-gx-ir" compatible string from
arch/arm64/boot/dts/amlogic/meson-gx.dtsi though.