2022-10-27 12:40:16

by Neil Armstrong

[permalink] [raw]
Subject: [PATCH] spi: meson-spicc: fix do_div build error on non-arm64

This fixes :
error: passing argument 1 of '__div64_32' from incompatible pointer type

By passing an uint64_t as first variable to do_div().

Fixes: 04694e50020b ("spi: meson-spicc: move wait completion in driver to take bursts delay in account")
Signed-off-by: Neil Armstrong <[email protected]>
---
To: Neil Armstrong <[email protected]>
To: Kevin Hilman <[email protected]>
To: Jerome Brunet <[email protected]>
To: Martin Blumenstingl <[email protected]>
Cc: [email protected]
Cc: [email protected]
Cc: [email protected]
Cc: [email protected]
---
drivers/spi/spi-meson-spicc.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/drivers/spi/spi-meson-spicc.c b/drivers/spi/spi-meson-spicc.c
index 52bffab18329..1b4195c54ee2 100644
--- a/drivers/spi/spi-meson-spicc.c
+++ b/drivers/spi/spi-meson-spicc.c
@@ -387,7 +387,7 @@ static int meson_spicc_transfer_one(struct spi_master *master,
struct spi_transfer *xfer)
{
struct meson_spicc_device *spicc = spi_master_get_devdata(master);
- unsigned long timeout;
+ uint64_t timeout;

/* Store current transfer */
spicc->xfer = xfer;

---
base-commit: 574f97ab96d6b153407161746bc127564e998b4f
change-id: 20221027-b4-spicc-burst-delay-fix-a03004454876

Best regards,
--
Neil Armstrong <[email protected]>


2022-11-01 19:33:15

by Martin Blumenstingl

[permalink] [raw]
Subject: Re: [PATCH] spi: meson-spicc: fix do_div build error on non-arm64

On Thu, Oct 27, 2022 at 2:11 PM Neil Armstrong
<[email protected]> wrote:
>
> This fixes :
> error: passing argument 1 of '__div64_32' from incompatible pointer type
>
> By passing an uint64_t as first variable to do_div().
>
> Fixes: 04694e50020b ("spi: meson-spicc: move wait completion in driver to take bursts delay in account")
> Signed-off-by: Neil Armstrong <[email protected]>
Acked-by: Martin Blumenstingl <[email protected]>
and also:
Reported-by: kernel test robot <[email protected]>

2022-11-02 08:48:30

by Neil Armstrong

[permalink] [raw]
Subject: Re: [PATCH] spi: meson-spicc: fix do_div build error on non-arm64

On 01/11/2022 20:13, Martin Blumenstingl wrote:
> On Thu, Oct 27, 2022 at 2:11 PM Neil Armstrong
> <[email protected]> wrote:
>>
>> This fixes :
>> error: passing argument 1 of '__div64_32' from incompatible pointer type
>>
>> By passing an uint64_t as first variable to do_div().
>>
>> Fixes: 04694e50020b ("spi: meson-spicc: move wait completion in driver to take bursts delay in account")
>> Signed-off-by: Neil Armstrong <[email protected]>
> Acked-by: Martin Blumenstingl <[email protected]>
> and also:
> Reported-by: kernel test robot <[email protected]>

Thanks,
Seems To: Mark is somehow missing, will resend with it.

Neil