2023-01-10 10:46:51

by XU pengfei

Subject: [PATCH 1/1] habanalabs: remove unnecessary (void*) conversions

data is a void * type and does not require a cast.

Signed-off-by: XU pengfei <[email protected]>
---
drivers/misc/habanalabs/common/mmu/mmu.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/drivers/misc/habanalabs/common/mmu/mmu.c b/drivers/misc/habanalabs/common/mmu/mmu.c
index 2c1005f74cf4..a42ae8bc61e8 100644
--- a/drivers/misc/habanalabs/common/mmu/mmu.c
+++ b/drivers/misc/habanalabs/common/mmu/mmu.c
@@ -781,7 +781,7 @@ static void mmu_dma_mem_free_from_chunk(struct gen_pool *pool,
struct gen_pool_chunk *chunk,
void *data)
{
- struct hl_device *hdev = (struct hl_device *)data;
+ struct hl_device *hdev = data;

hl_asic_dma_free_coherent(hdev, (chunk->end_addr - chunk->start_addr) + 1,
(void *)chunk->start_addr, chunk->phys_addr);
--
2.18.2

2023-01-10 13:53:52

by Oded Gabbay

Subject: Re: [PATCH 1/1] habanalabs: remove unnecessary (void*) conversions

On Tue, Jan 10, 2023 at 12:35 PM XU pengfei <[email protected]> wrote:
>
> data is a void * type and does not require a cast.
>
> Signed-off-by: XU pengfei <[email protected]>
> ---
> drivers/misc/habanalabs/common/mmu/mmu.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/drivers/misc/habanalabs/common/mmu/mmu.c b/drivers/misc/habanalabs/common/mmu/mmu.c
> index 2c1005f74cf4..a42ae8bc61e8 100644
> --- a/drivers/misc/habanalabs/common/mmu/mmu.c
> +++ b/drivers/misc/habanalabs/common/mmu/mmu.c
> @@ -781,7 +781,7 @@ static void mmu_dma_mem_free_from_chunk(struct gen_pool *pool,
> struct gen_pool_chunk *chunk,
> void *data)
> {
> - struct hl_device *hdev = (struct hl_device *)data;
> + struct hl_device *hdev = data;
>
> hl_asic_dma_free_coherent(hdev, (chunk->end_addr - chunk->start_addr) + 1,
> (void *)chunk->start_addr, chunk->phys_addr);
> --
> 2.18.2
>

Reviewed-by: Oded Gabbay <[email protected]>
Applied to -next.
Thanks,
Oded