2023-01-19 16:48:36

by Jeffrey Hugo

Subject: [PATCH] docs: accel: Fix debugfs path

The device specific directory in debugfs does not have "accel". For
example, the documentation says device 0 should have a debugfs entry as
/sys/kernel/debug/accel/accel0/ but in reality the entry is
/sys/kernel/debug/accel/0/

Fix the documentation to match the implementation.

Fixes: 8c5577a5ccc6 ("doc: add documentation for accel subsystem")
Signed-off-by: Jeffrey Hugo <[email protected]>
---
Documentation/accel/introduction.rst | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/Documentation/accel/introduction.rst b/Documentation/accel/introduction.rst
index 6f31af1..11cade5 100644
--- a/Documentation/accel/introduction.rst
+++ b/Documentation/accel/introduction.rst
@@ -69,7 +69,7 @@ The accelerator devices will be exposed to the user space with the dedicated

- device char files - /dev/accel/accel*
- sysfs - /sys/class/accel/accel*/
-- debugfs - /sys/kernel/debug/accel/accel*/
+- debugfs - /sys/kernel/debug/accel/*/

Getting Started
===============
--
2.7.4

2023-01-19 17:11:04

by Oded Gabbay

Subject: Re: [PATCH] docs: accel: Fix debugfs path

On Thu, Jan 19, 2023 at 6:26 PM Jeffrey Hugo <[email protected]> wrote:
>
> The device specific directory in debugfs does not have "accel". For
> example, the documentation says device 0 should have a debugfs entry as
> /sys/kernel/debug/accel/accel0/ but in reality the entry is
> /sys/kernel/debug/accel/0/
>
> Fix the documentation to match the implementation.
>
> Fixes: 8c5577a5ccc6 ("doc: add documentation for accel subsystem")
> Signed-off-by: Jeffrey Hugo <[email protected]>
> ---
> Documentation/accel/introduction.rst | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/Documentation/accel/introduction.rst b/Documentation/accel/introduction.rst
> index 6f31af1..11cade5 100644
> --- a/Documentation/accel/introduction.rst
> +++ b/Documentation/accel/introduction.rst
> @@ -69,7 +69,7 @@ The accelerator devices will be exposed to the user space with the dedicated
>
> - device char files - /dev/accel/accel*
> - sysfs - /sys/class/accel/accel*/
> -- debugfs - /sys/kernel/debug/accel/accel*/
> +- debugfs - /sys/kernel/debug/accel/*/
>
> Getting Started
> ===============
> --
> 2.7.4
>

Reviewed-by: Oded Gabbay <[email protected]>
Thanks,
Oded

2023-01-24 22:21:01

by Jonathan Corbet

Subject: Re: [PATCH] docs: accel: Fix debugfs path

Jeffrey Hugo <[email protected]> writes:

> The device specific directory in debugfs does not have "accel". For
> example, the documentation says device 0 should have a debugfs entry as
> /sys/kernel/debug/accel/accel0/ but in reality the entry is
> /sys/kernel/debug/accel/0/
>
> Fix the documentation to match the implementation.
>
> Fixes: 8c5577a5ccc6 ("doc: add documentation for accel subsystem")
> Signed-off-by: Jeffrey Hugo <[email protected]>
> ---
> Documentation/accel/introduction.rst | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/Documentation/accel/introduction.rst b/Documentation/accel/introduction.rst
> index 6f31af1..11cade5 100644
> --- a/Documentation/accel/introduction.rst
> +++ b/Documentation/accel/introduction.rst
> @@ -69,7 +69,7 @@ The accelerator devices will be exposed to the user space with the dedicated
>
> - device char files - /dev/accel/accel*
> - sysfs - /sys/class/accel/accel*/
> -- debugfs - /sys/kernel/debug/accel/accel*/
> +- debugfs - /sys/kernel/debug/accel/*/
>
Applied, thanks.

jon