2015-06-16 14:37:13

by Daniel Kurtz

Subject: [PATCH] arm64: dts: symlink cros-ec-keyboard from arm to arm64

The cros-ec-keyboard.dtsi snippet is useful for both arm and arm64 boards.
Create a link between the two.

This may not be the most scalable solution, so consider it temporary until
we find a more central repository for such shared .dtsi snippets.

Signed-off-by: Daniel Kurtz <[email protected]>
---
arch/arm64/boot/dts/cros-ec-keyboard.dtsi | 1 +
1 file changed, 1 insertion(+)
create mode 120000 arch/arm64/boot/dts/cros-ec-keyboard.dtsi

diff --git a/arch/arm64/boot/dts/cros-ec-keyboard.dtsi b/arch/arm64/boot/dts/cros-ec-keyboard.dtsi
new file mode 120000
index 0000000..42220ac
--- /dev/null
+++ b/arch/arm64/boot/dts/cros-ec-keyboard.dtsi
@@ -0,0 +1 @@
+../../../arm/boot/dts/cros-ec-keyboard.dtsi
\ No newline at end of file
--
2.2.0.rc0.207.ga3a616c

2015-06-16 14:56:04

by Will Deacon

Subject: Re: [PATCH] arm64: dts: symlink cros-ec-keyboard from arm to arm64

On Tue, Jun 16, 2015 at 03:35:41PM +0100, Daniel Kurtz wrote:
> The cros-ec-keyboard.dtsi snippet is useful for both arm and arm64 boards.
> Create a link between the two.
>
> This may not be the most scalable solution, so consider it temporary until
> we find a more central repository for such shared .dtsi snippets.

I don't have strong opinions either way, but we should be consistent as
to whether we use relative paths:

http://lists.infradead.org/pipermail/linux-arm-kernel/2015-June/350267.html

or symlinks, like below.

Does anybody have some technical arguments one way or the other?

Will

> Signed-off-by: Daniel Kurtz <[email protected]>
> ---
> arch/arm64/boot/dts/cros-ec-keyboard.dtsi | 1 +
> 1 file changed, 1 insertion(+)
> create mode 120000 arch/arm64/boot/dts/cros-ec-keyboard.dtsi
>
> diff --git a/arch/arm64/boot/dts/cros-ec-keyboard.dtsi b/arch/arm64/boot/dts/cros-ec-keyboard.dtsi
> new file mode 120000
> index 0000000..42220ac
> --- /dev/null
> +++ b/arch/arm64/boot/dts/cros-ec-keyboard.dtsi
> @@ -0,0 +1 @@
> +../../../arm/boot/dts/cros-ec-keyboard.dtsi
> \ No newline at end of file
> --
> 2.2.0.rc0.207.ga3a616c
>

2015-06-17 04:14:10

by Daniel Kurtz

Subject: Re: [PATCH] arm64: dts: symlink cros-ec-keyboard from arm to arm64

On Tue, Jun 16, 2015 at 10:55 PM, Will Deacon <[email protected]> wrote:
> On Tue, Jun 16, 2015 at 03:35:41PM +0100, Daniel Kurtz wrote:
>> The cros-ec-keyboard.dtsi snippet is useful for both arm and arm64 boards.
>> Create a link between the two.
>>
>> This may not be the most scalable solution, so consider it temporary until
>> we find a more central repository for such shared .dtsi snippets.
>
> I don't have strong opinions either way, but we should be consistent as
> to whether we use relative paths:
>
> http://lists.infradead.org/pipermail/linux-arm-kernel/2015-June/350267.html
>
> or symlinks, like below.
>
> Does anybody have some technical arguments one way or the other?

/include/ "../../../../arm/boot/dts/cros-ec-keyboard.dtsi"

Directly embedding the relative path to .dtsi in /arm/ from .dts in
/arm64/ is more straightforward and does not require maintaining extra
symlink .dtsi files.

I actually like it better than the symlink that I proposed :-).
Consider my patch abandoned, unless someone else feels strongly.

-Dan

>
> Will
>
>> Signed-off-by: Daniel Kurtz <[email protected]>
>> ---
>> arch/arm64/boot/dts/cros-ec-keyboard.dtsi | 1 +
>> 1 file changed, 1 insertion(+)
>> create mode 120000 arch/arm64/boot/dts/cros-ec-keyboard.dtsi
>>
>> diff --git a/arch/arm64/boot/dts/cros-ec-keyboard.dtsi b/arch/arm64/boot/dts/cros-ec-keyboard.dtsi
>> new file mode 120000
>> index 0000000..42220ac
>> --- /dev/null
>> +++ b/arch/arm64/boot/dts/cros-ec-keyboard.dtsi
>> @@ -0,0 +1 @@
>> +../../../arm/boot/dts/cros-ec-keyboard.dtsi
>> \ No newline at end of file
>> --
>> 2.2.0.rc0.207.ga3a616c
>>