2021-06-30 04:53:47

by Hsin-Yi Wang

Subject: [PATCH] arm64: dts: mt8183: kukui: use generic pin configs for i2c pins

mt8183 i2c pins don't support PUPD register, so change to use generic
pin configs instead of let it fail and fallback.

Signed-off-by: Hsin-Yi Wang <[email protected]>
---
arch/arm64/boot/dts/mediatek/mt8183-kukui.dtsi | 8 ++++----
1 file changed, 4 insertions(+), 4 deletions(-)

diff --git a/arch/arm64/boot/dts/mediatek/mt8183-kukui.dtsi b/arch/arm64/boot/dts/mediatek/mt8183-kukui.dtsi
index ae549d55a94fc..69dc04c3f7fff 100644
--- a/arch/arm64/boot/dts/mediatek/mt8183-kukui.dtsi
+++ b/arch/arm64/boot/dts/mediatek/mt8183-kukui.dtsi
@@ -426,7 +426,7 @@ i2c0_pins: i2c0 {
pins_bus {
pinmux = <PINMUX_GPIO82__FUNC_SDA0>,
<PINMUX_GPIO83__FUNC_SCL0>;
- mediatek,pull-up-adv = <3>;
+ bias-pull-up;
mediatek,drive-strength-adv = <00>;
};
};
@@ -435,7 +435,7 @@ i2c1_pins: i2c1 {
pins_bus {
pinmux = <PINMUX_GPIO81__FUNC_SDA1>,
<PINMUX_GPIO84__FUNC_SCL1>;
- mediatek,pull-up-adv = <3>;
+ bias-pull-up;
mediatek,drive-strength-adv = <00>;
};
};
@@ -453,7 +453,7 @@ i2c3_pins: i2c3 {
pins_bus {
pinmux = <PINMUX_GPIO50__FUNC_SCL3>,
<PINMUX_GPIO51__FUNC_SDA3>;
- mediatek,pull-up-adv = <3>;
+ bias-pull-up;
mediatek,drive-strength-adv = <00>;
};
};
@@ -471,7 +471,7 @@ i2c5_pins: i2c5 {
pins_bus {
pinmux = <PINMUX_GPIO48__FUNC_SCL5>,
<PINMUX_GPIO49__FUNC_SDA5>;
- mediatek,pull-up-adv = <3>;
+ bias-pull-up;
mediatek,drive-strength-adv = <00>;
};
};
--
2.32.0.93.g670b81a890-goog

2021-06-30 07:30:52

by Chen-Yu Tsai

Subject: Re: [PATCH] arm64: dts: mt8183: kukui: use generic pin configs for i2c pins

On Wed, Jun 30, 2021 at 3:27 PM Chen-Yu Tsai <[email protected]> wrote:
>
> On Wed, Jun 30, 2021 at 11:55 AM Hsin-Yi Wang <[email protected]> wrote:
> >
> > mt8183 i2c pins don't support PUPD register, so change to use generic
> > pin configs instead of let it fail and fallback.
> >
> > Signed-off-by: Hsin-Yi Wang <[email protected]>
>
> Reviewed-by: Chen-Yu Tsai <[email protected]>

You might also want:

Fixes: cd894e274b74 ("arm64: dts: mt8183: Add krane-sku176 board")

> On a side note, the `mediatek,pull-up-adv` property probably should be
> merged into `bias-pull-up` with an argument.

2021-06-30 07:31:12

by Chen-Yu Tsai

Subject: Re: [PATCH] arm64: dts: mt8183: kukui: use generic pin configs for i2c pins

On Wed, Jun 30, 2021 at 11:55 AM Hsin-Yi Wang <[email protected]> wrote:
>
> mt8183 i2c pins don't support PUPD register, so change to use generic
> pin configs instead of let it fail and fallback.
>
> Signed-off-by: Hsin-Yi Wang <[email protected]>

Reviewed-by: Chen-Yu Tsai <[email protected]>

On a side note, the `mediatek,pull-up-adv` property probably should be
merged into `bias-pull-up` with an argument.