Updated sparse to get rid of some unneeded kernel sparse check
warnings but now get many more
I get 100s of warnings similar to
./include/linux/quota.h:114:17: error: Expected ( after asm
./include/linux/quota.h:114:17: error: got __inline
but that is simply
default:
BUG();
Any idea a way to quiet those - there are too many sparse warnings now
to find any real warnings that are introduced by kernel changes?
--
Thanks,
Steve
On Tue, Oct 01, 2019 at 11:28:16AM -0500, Steve French wrote:
> Updated sparse to get rid of some unneeded kernel sparse check
> warnings but now get many more
>
> I get 100s of warnings similar to
>
> ./include/linux/quota.h:114:17: error: Expected ( after asm
> ./include/linux/quota.h:114:17: error: got __inline
>
> but that is simply
> default:
> BUG();
Hi,
I don't see this on v5.4-rc1 with defconfig or allyesconfig and
sparse's current version. Any sparse's version since roughly
mid-December should give the same result.
If you're using an older version of sparse, please upgrade.
Otherwise, please send me your config so that I can take a look at it.
Best regards,
-- Luc Van Oostenryck
It may be related to the following sparse make warning:
No rule to make target
'/usr/include/x86_64-linux-gnu/bits/huge_val.h', needed by
'sparse-llvm.o'
I don't see huge_val.h in the Ubuntu 19 version of libc6-dev
Will send you the kernel config - but I am using the default one from
the Ubuntu mainline download of 5.4-rc1
On Tue, Oct 1, 2019 at 6:10 PM Luc Van Oostenryck
<[email protected]> wrote:
>
> On Tue, Oct 01, 2019 at 11:28:16AM -0500, Steve French wrote:
> > Updated sparse to get rid of some unneeded kernel sparse check
> > warnings but now get many more
> >
> > I get 100s of warnings similar to
> >
> > ./include/linux/quota.h:114:17: error: Expected ( after asm
> > ./include/linux/quota.h:114:17: error: got __inline
> >
> > but that is simply
> > default:
> > BUG();
>
> Hi,
>
> I don't see this on v5.4-rc1 with defconfig or allyesconfig and
> sparse's current version. Any sparse's version since roughly
> mid-December should give the same result.
>
> If you're using an older version of sparse, please upgrade.
> Otherwise, please send me your config so that I can take a look at it.
>
>
> Best regards,
> -- Luc Van Oostenryck
--
Thanks,
Steve
On Tue, Oct 01, 2019 at 06:14:23PM -0500, Steve French wrote:
> It may be related to the following sparse make warning:
>
> No rule to make target
> '/usr/include/x86_64-linux-gnu/bits/huge_val.h', needed by
> 'sparse-llvm.o'
>
> I don't see huge_val.h in the Ubuntu 19 version of libc6-dev
Yes, I've been bitten myself by this. It's fixed since a little while.
So, just doing a clean build or removing all the deps (.*.d)
should allow you to build sparse.
I've verified the problem with asm and __inline in quota.h:
it's autodetected by kconfig (CC_HAS_ASM_INLINE) so the exact config
doesn't matter (only gcc's version does) but in all cases recent
versions of sparse don't have a problem with it (an upstream version
of `sparse --version` should return "v0.6.1-rc1-37-gd466a0281").
Best regards,
-- Luc
On Tue, Oct 1, 2019 at 7:19 PM Luc Van Oostenryck
<[email protected]> wrote:
>
> On Tue, Oct 01, 2019 at 06:14:23PM -0500, Steve French wrote:
> > It may be related to the following sparse make warning:
> >
> > No rule to make target
> > '/usr/include/x86_64-linux-gnu/bits/huge_val.h', needed by
> > 'sparse-llvm.o'
> >
> > I don't see huge_val.h in the Ubuntu 19 version of libc6-dev
>
> Yes, I've been bitten myself by this. It's fixed since a little while.
> So, just doing a clean build or removing all the deps (.*.d)
> should allow you to build sparse.
>
> I've verified the problem with asm and __inline in quota.h:
> it's autodetected by kconfig (CC_HAS_ASM_INLINE) so the exact config
> doesn't matter (only gcc's version does) but in all cases recent
> versions of sparse don't have a problem with it
Removed the dependencies and rebuilt as you suggested and it worked ...
and even better ... with the noise removed I now see two real bugs
(endian conversion missing on two lines) and only one possible problem
with sparse/gcc itself
Sparse now flags this line from one of Paulo's DFS features merged last year:
struct smb_vol fake_vol = {0};
with
"warning: Using plain integer as NULL pointer"
What is the recommended way to initialize a struct to avoid the sparse warning?
And what about the "namespace" warnings from the fscache (cache.o)
code that now show up? I hadn't seen those before.
Any easy way to remove them?
"WARNING: module cifs uses symbol sigprocmask from namespace
fs/cifs/cache.o: $(deps_/home/sfrench/cifs-2.6/fs/cifs/cache.o), but
does not import it."
--
Thanks,
Steve
On Tue, Oct 01, 2019 at 08:24:45PM -0500, Steve French wrote:
> On Tue, Oct 1, 2019 at 7:19 PM Luc Van Oostenryck
> <[email protected]> wrote:
> >
> > On Tue, Oct 01, 2019 at 06:14:23PM -0500, Steve French wrote:
> > > It may be related to the following sparse make warning:
> > >
> > > No rule to make target
> > > '/usr/include/x86_64-linux-gnu/bits/huge_val.h', needed by
> > > 'sparse-llvm.o'
> > >
> > > I don't see huge_val.h in the Ubuntu 19 version of libc6-dev
> >
> > Yes, I've been bitten myself by this. It's fixed since a little while.
> > So, just doing a clean build or removing all the deps (.*.d)
> > should allow you to build sparse.
> >
> > I've verified the problem with asm and __inline in quota.h:
> > it's autodetected by kconfig (CC_HAS_ASM_INLINE) so the exact config
> > doesn't matter (only gcc's version does) but in all cases recent
> > versions of sparse don't have a problem with it
>
> Removed the dependencies and rebuilt as you suggested and it worked ...
> and even better ... with the noise removed I now see two real bugs
Ahh, good!
> (endian conversion missing on two lines) and only one possible problem
> with sparse/gcc itself
>
> Sparse now flags this line from one of Paulo's DFS features merged last year:
>
> struct smb_vol fake_vol = {0};
>
> with
>
> "warning: Using plain integer as NULL pointer"
>
> What is the recommended way to initialize a struct to avoid the sparse warning?
Well, personally, I simply use '{}'. GCC and sparse are happy with it but, IIRC,
it's not allowed by the standard...
> And what about the "namespace" warnings from the fscache (cache.o)
> code that now show up? I hadn't seen those before.
> Any easy way to remove them?
>
> "WARNING: module cifs uses symbol sigprocmask from namespace
> fs/cifs/cache.o: $(deps_/home/sfrench/cifs-2.6/fs/cifs/cache.o), but
> does not import it."
This one is not from sparse, it's from modpost (see EXPORT_SYMBOL_NS).
Cheers,
-- Luc