Hi all,
After merging the cifs tree, today's linux-next build (powerpc
ppc64_defconfig) failed like this:
In file included from fs/cifs/dns_resolve.c:18:
fs/cifs/cifsglob.h: In function 'cifs_get_tlink':
fs/cifs/cifsglob.h:1169:14: error: passing argument 1 of 'atomic_inc' from incompatible pointer type [-Werror=incompatible-pointer-types]
1169 | atomic_inc(&tlink->tl_count);
| ^~~~~~~~~~~~~~~~
| |
| refcount_t * {aka struct refcount_struct *}
In file included from include/linux/atomic.h:82,
from include/linux/cpumask.h:13,
from include/linux/smp.h:13,
from include/linux/lockdep.h:14,
from include/linux/spinlock.h:62,
from include/linux/mmzone.h:8,
from include/linux/gfp.h:6,
from include/linux/slab.h:15,
from fs/cifs/dns_resolve.c:15:
include/linux/atomic/atomic-instrumented.h:179:22: note: expected 'atomic_t *' but argument is of type 'refcount_t *' {aka 'struct refcount_struct *'}
179 | atomic_inc(atomic_t *v)
| ~~~~~~~~~~^
and lots more similar ...
Caused by commit
ef242296e441 ("fs:cifs: convert from atomic_t to refcount_t on tlink->tl_count")
Please write, review, test (repeat) and, only then, publish. :-(
I have used the cifs tree from next-20211115 for today.
--
Cheers,
Stephen Rothwell
patch removed pending author fix
On Mon, Nov 15, 2021 at 4:17 PM Stephen Rothwell <[email protected]> wrote:
>
> Hi all,
>
> After merging the cifs tree, today's linux-next build (powerpc
> ppc64_defconfig) failed like this:
>
> In file included from fs/cifs/dns_resolve.c:18:
> fs/cifs/cifsglob.h: In function 'cifs_get_tlink':
> fs/cifs/cifsglob.h:1169:14: error: passing argument 1 of 'atomic_inc' from incompatible pointer type [-Werror=incompatible-pointer-types]
> 1169 | atomic_inc(&tlink->tl_count);
> | ^~~~~~~~~~~~~~~~
> | |
> | refcount_t * {aka struct refcount_struct *}
> In file included from include/linux/atomic.h:82,
> from include/linux/cpumask.h:13,
> from include/linux/smp.h:13,
> from include/linux/lockdep.h:14,
> from include/linux/spinlock.h:62,
> from include/linux/mmzone.h:8,
> from include/linux/gfp.h:6,
> from include/linux/slab.h:15,
> from fs/cifs/dns_resolve.c:15:
> include/linux/atomic/atomic-instrumented.h:179:22: note: expected 'atomic_t *' but argument is of type 'refcount_t *' {aka 'struct refcount_struct *'}
> 179 | atomic_inc(atomic_t *v)
> | ~~~~~~~~~~^
>
> and lots more similar ...
>
> Caused by commit
>
> ef242296e441 ("fs:cifs: convert from atomic_t to refcount_t on tlink->tl_count")
>
> Please write, review, test (repeat) and, only then, publish. :-(
>
> I have used the cifs tree from next-20211115 for today.
>
> --
> Cheers,
> Stephen Rothwell
--
Thanks,
Steve