2021-03-18 19:21:38

by Richard Guy Briggs

[permalink] [raw]
Subject: [PATCH v3 0/2] audit: add documentation for /proc/PID/stable interfaces

Add Documentation/ABI entries for audit interfaces in /proc/PID/ that have
been stable for more than a decade.

Richard Guy Briggs (2):
audit: document /proc/PID/loginuid
audit: document /proc/PID/sessionid

.../ABI/stable/procfs-audit_loginuid | 27 +++++++++++++++++++
1 file changed, 27 insertions(+)
create mode 100644 Documentation/ABI/stable/procfs-audit_loginuid

--
2.27.0


2021-03-18 19:21:57

by Richard Guy Briggs

[permalink] [raw]
Subject: [PATCH v3 1/2] audit: document /proc/PID/loginuid

Describe the /proc/PID/loginuid interface in Documentation/ABI/stable that
was added 2005-02-01 by commit 1e2d1492e178 ("[PATCH] audit: handle
loginuid through proc")

Signed-off-by: Richard Guy Briggs <[email protected]>
---
Documentation/ABI/stable/procfs-audit_loginuid | 15 +++++++++++++++
1 file changed, 15 insertions(+)
create mode 100644 Documentation/ABI/stable/procfs-audit_loginuid

diff --git a/Documentation/ABI/stable/procfs-audit_loginuid b/Documentation/ABI/stable/procfs-audit_loginuid
new file mode 100644
index 000000000000..e7c100b9ab18
--- /dev/null
+++ b/Documentation/ABI/stable/procfs-audit_loginuid
@@ -0,0 +1,15 @@
+What: Audit Login UID
+Date: 2005-02-01
+KernelVersion: 2.6.11-rc2 1e2d1492e178 ("[PATCH] audit: handle loginuid through proc")
+Contact: [email protected]
+Format: %u
+Users: audit and login applications
+Description:
+ The /proc/$pid/loginuid pseudofile is written to set and
+ read to get the audit login UID of process $pid. If it is
+ unset, permissions are not needed to set it. The accessor must
+ have CAP_AUDIT_CONTROL in the initial user namespace to write
+ it if it has been set. It cannot be written again if
+ AUDIT_FEATURE_LOGINUID_IMMUTABLE is enabled. It cannot be
+ unset if AUDIT_FEATURE_ONLY_UNSET_LOGINUID is enabled.
+
--
2.27.0

2021-03-18 19:22:10

by Richard Guy Briggs

[permalink] [raw]
Subject: [PATCH v3 2/2] audit: document /proc/PID/sessionid

Describe the /proc/PID/loginuid interface in Documentation/ABI/stable that
was added 2008-03-13 in commit 1e0bd7550ea9 ("[PATCH] export sessionid
alongside the loginuid in procfs")

Signed-off-by: Richard Guy Briggs <[email protected]>
---
Documentation/ABI/stable/procfs-audit_loginuid | 12 ++++++++++++
1 file changed, 12 insertions(+)

diff --git a/Documentation/ABI/stable/procfs-audit_loginuid b/Documentation/ABI/stable/procfs-audit_loginuid
index e7c100b9ab18..9d55a3ff4b34 100644
--- a/Documentation/ABI/stable/procfs-audit_loginuid
+++ b/Documentation/ABI/stable/procfs-audit_loginuid
@@ -13,3 +13,15 @@ Description:
AUDIT_FEATURE_LOGINUID_IMMUTABLE is enabled. It cannot be
unset if AUDIT_FEATURE_ONLY_UNSET_LOGINUID is enabled.

+
+What: Audit Login Session ID
+Date: 2008-03-13
+KernelVersion: 2.6.25-rc7 1e0bd7550ea9 ("[PATCH] export sessionid alongside the loginuid in procfs")
+Contact: [email protected]
+Format: %u
+Users: audit and login applications
+Description:
+ The /proc/$pid/sessionid pseudofile is read to get the
+ audit login session ID of process $pid. It is set
+ automatically, serially assigned with each new login.
+
--
2.27.0

2021-03-18 21:01:51

by Paul Moore

[permalink] [raw]
Subject: Re: [PATCH v3 1/2] audit: document /proc/PID/loginuid

On Thu, Mar 18, 2021 at 3:19 PM Richard Guy Briggs <[email protected]> wrote:
>
> Describe the /proc/PID/loginuid interface in Documentation/ABI/stable that
> was added 2005-02-01 by commit 1e2d1492e178 ("[PATCH] audit: handle
> loginuid through proc")
>
> Signed-off-by: Richard Guy Briggs <[email protected]>
> ---
> Documentation/ABI/stable/procfs-audit_loginuid | 15 +++++++++++++++
> 1 file changed, 15 insertions(+)
> create mode 100644 Documentation/ABI/stable/procfs-audit_loginuid

Merged into audit/next, thanks.

--
paul moore
http://www.paul-moore.com

2021-03-18 21:02:55

by Paul Moore

[permalink] [raw]
Subject: Re: [PATCH v3 2/2] audit: document /proc/PID/sessionid

On Thu, Mar 18, 2021 at 3:19 PM Richard Guy Briggs <[email protected]> wrote:
>
> Describe the /proc/PID/loginuid interface in Documentation/ABI/stable that
> was added 2008-03-13 in commit 1e0bd7550ea9 ("[PATCH] export sessionid
> alongside the loginuid in procfs")
>
> Signed-off-by: Richard Guy Briggs <[email protected]>
> ---
> Documentation/ABI/stable/procfs-audit_loginuid | 12 ++++++++++++
> 1 file changed, 12 insertions(+)

Merged into audit/next, thanks.

--
paul moore
http://www.paul-moore.com

2021-04-01 17:46:28

by Paul Moore

[permalink] [raw]
Subject: Re: [PATCH v3 1/2] audit: document /proc/PID/loginuid

On Thu, Apr 1, 2021 at 9:48 AM Mauro Carvalho Chehab
<[email protected]> wrote:
> Em Thu, 18 Mar 2021 15:19:10 -0400
> Richard Guy Briggs <[email protected]> escreveu:
> > Describe the /proc/PID/loginuid interface in Documentation/ABI/stable that
> > was added 2005-02-01 by commit 1e2d1492e178 ("[PATCH] audit: handle
> > loginuid through proc")
> >
> > Signed-off-by: Richard Guy Briggs <[email protected]>
> > ---
> > Documentation/ABI/stable/procfs-audit_loginuid | 15 +++++++++++++++
> > 1 file changed, 15 insertions(+)
> > create mode 100644 Documentation/ABI/stable/procfs-audit_loginuid
> >
> > diff --git a/Documentation/ABI/stable/procfs-audit_loginuid b/Documentation/ABI/stable/procfs-audit_loginuid
> > new file mode 100644
> > index 000000000000..e7c100b9ab18
> > --- /dev/null
> > +++ b/Documentation/ABI/stable/procfs-audit_loginuid
> > @@ -0,0 +1,15 @@
> > +What: Audit Login UID
> > +Date: 2005-02-01
> > +KernelVersion: 2.6.11-rc2 1e2d1492e178 ("[PATCH] audit: handle loginuid through proc")
> > +Contact: [email protected]
> > +Format: %u
>
> The ABI definition doesn't include a "Format:" symbol. See:
>
> Documentation/ABI/README
>
> For the valid ones.
>
> This change causes a warning at the ABI parser:
>
>
> $ ./scripts/get_abi.pl validate
> Warning: file Documentation/ABI/stable/procfs-audit_loginuid#5:
> tag 'contact' is invalid. Line
> Format: %u
> Warning: file Documentation/ABI/stable/procfs-audit_loginuid#21:
> tag 'contact' is invalid. Line
> Format: %u
>
> You should either drop it or add it to the parser and to the README
> file, if the ABI maintainers are ok with such new field.

Thanks Mauro, I didn't realize there were tools that parsed these files.

Richard, please post a patch that drops the 'Format:' line from the
newly added audit files as soon as possible so I can merge it into
audit/next.

--
paul moore
http://www.paul-moore.com

2021-04-01 18:04:10

by Richard Guy Briggs

[permalink] [raw]
Subject: Re: [PATCH v3 1/2] audit: document /proc/PID/loginuid

On 2021-04-01 09:57, Paul Moore wrote:
> On Thu, Apr 1, 2021 at 9:48 AM Mauro Carvalho Chehab
> <[email protected]> wrote:
> > Em Thu, 18 Mar 2021 15:19:10 -0400
> > Richard Guy Briggs <[email protected]> escreveu:
> > > Describe the /proc/PID/loginuid interface in Documentation/ABI/stable that
> > > was added 2005-02-01 by commit 1e2d1492e178 ("[PATCH] audit: handle
> > > loginuid through proc")
> > >
> > > Signed-off-by: Richard Guy Briggs <[email protected]>
> > > ---
> > > Documentation/ABI/stable/procfs-audit_loginuid | 15 +++++++++++++++
> > > 1 file changed, 15 insertions(+)
> > > create mode 100644 Documentation/ABI/stable/procfs-audit_loginuid
> > >
> > > diff --git a/Documentation/ABI/stable/procfs-audit_loginuid b/Documentation/ABI/stable/procfs-audit_loginuid
> > > new file mode 100644
> > > index 000000000000..e7c100b9ab18
> > > --- /dev/null
> > > +++ b/Documentation/ABI/stable/procfs-audit_loginuid
> > > @@ -0,0 +1,15 @@
> > > +What: Audit Login UID
> > > +Date: 2005-02-01
> > > +KernelVersion: 2.6.11-rc2 1e2d1492e178 ("[PATCH] audit: handle loginuid through proc")
> > > +Contact: [email protected]
> > > +Format: %u
> >
> > The ABI definition doesn't include a "Format:" symbol. See:
> >
> > Documentation/ABI/README
> >
> > For the valid ones.
> >
> > This change causes a warning at the ABI parser:
> >
> >
> > $ ./scripts/get_abi.pl validate
> > Warning: file Documentation/ABI/stable/procfs-audit_loginuid#5:
> > tag 'contact' is invalid. Line
> > Format: %u
> > Warning: file Documentation/ABI/stable/procfs-audit_loginuid#21:
> > tag 'contact' is invalid. Line
> > Format: %u
> >
> > You should either drop it or add it to the parser and to the README
> > file, if the ABI maintainers are ok with such new field.
>
> Thanks Mauro, I didn't realize there were tools that parsed these files.
>
> Richard, please post a patch that drops the 'Format:' line from the
> newly added audit files as soon as possible so I can merge it into
> audit/next.

Ok. I'll roll it into the description so we don't lose that
information.

> paul moore

- RGB

--
Richard Guy Briggs <[email protected]>
Sr. S/W Engineer, Kernel Security, Base Operating Systems
Remote, Ottawa, Red Hat Canada
IRC: rgb, SunRaycer
Voice: +1.647.777.2635, Internal: (81) 32635

2021-04-01 18:53:29

by Mauro Carvalho Chehab

[permalink] [raw]
Subject: Re: [PATCH v3 1/2] audit: document /proc/PID/loginuid

Em Thu, 18 Mar 2021 15:19:10 -0400
Richard Guy Briggs <[email protected]> escreveu:

> Describe the /proc/PID/loginuid interface in Documentation/ABI/stable that
> was added 2005-02-01 by commit 1e2d1492e178 ("[PATCH] audit: handle
> loginuid through proc")
>
> Signed-off-by: Richard Guy Briggs <[email protected]>
> ---
> Documentation/ABI/stable/procfs-audit_loginuid | 15 +++++++++++++++
> 1 file changed, 15 insertions(+)
> create mode 100644 Documentation/ABI/stable/procfs-audit_loginuid
>
> diff --git a/Documentation/ABI/stable/procfs-audit_loginuid b/Documentation/ABI/stable/procfs-audit_loginuid
> new file mode 100644
> index 000000000000..e7c100b9ab18
> --- /dev/null
> +++ b/Documentation/ABI/stable/procfs-audit_loginuid
> @@ -0,0 +1,15 @@
> +What: Audit Login UID
> +Date: 2005-02-01
> +KernelVersion: 2.6.11-rc2 1e2d1492e178 ("[PATCH] audit: handle loginuid through proc")
> +Contact: [email protected]
> +Format: %u

The ABI definition doesn't include a "Format:" symbol. See:

Documentation/ABI/README

For the valid ones.

This change causes a warning at the ABI parser:


$ ./scripts/get_abi.pl validate
Warning: file Documentation/ABI/stable/procfs-audit_loginuid#5:
tag 'contact' is invalid. Line
Format: %u
Warning: file Documentation/ABI/stable/procfs-audit_loginuid#21:
tag 'contact' is invalid. Line
Format: %u

You should either drop it or add it to the parser and to the README
file, if the ABI maintainers are ok with such new field.

Thanks,
Mauro