2021-04-13 08:59:51

by Ilya Lipnitskiy

Subject: [PATCH 3/8] MIPS: pci-rt3883: trivial: remove unused variable

Fixes the following compiler warning:
warning: unused variable 'flags' [-Wunused-variable]

Fixes: e5067c718b3a ("MIPS: pci-rt3883: Remove odd locking in PCI config space access code")
Signed-off-by: Ilya Lipnitskiy <[email protected]>
Cc: Sergey Ryazanov <[email protected]>
Cc: [email protected]
---
arch/mips/pci/pci-rt3883.c | 4 ----
1 file changed, 4 deletions(-)

diff --git a/arch/mips/pci/pci-rt3883.c b/arch/mips/pci/pci-rt3883.c
index 0ac6346026d0..e422f78db5bc 100644
--- a/arch/mips/pci/pci-rt3883.c
+++ b/arch/mips/pci/pci-rt3883.c
@@ -100,7 +100,6 @@ static u32 rt3883_pci_read_cfg32(struct rt3883_pci_controller *rpc,
unsigned bus, unsigned slot,
unsigned func, unsigned reg)
{
- unsigned long flags;
u32 address;
u32 ret;

@@ -116,7 +115,6 @@ static void rt3883_pci_write_cfg32(struct rt3883_pci_controller *rpc,
unsigned bus, unsigned slot,
unsigned func, unsigned reg, u32 val)
{
- unsigned long flags;
u32 address;

address = rt3883_pci_get_cfgaddr(bus, slot, func, reg);
@@ -229,7 +227,6 @@ static int rt3883_pci_config_read(struct pci_bus *bus, unsigned int devfn,
int where, int size, u32 *val)
{
struct rt3883_pci_controller *rpc;
- unsigned long flags;
u32 address;
u32 data;

@@ -263,7 +260,6 @@ static int rt3883_pci_config_write(struct pci_bus *bus, unsigned int devfn,
int where, int size, u32 val)
{
struct rt3883_pci_controller *rpc;
- unsigned long flags;
u32 address;
u32 data;

--
2.31.1

2021-04-13 17:10:15

by Sergey Ryazanov

Subject: Re: [PATCH 3/8] MIPS: pci-rt3883: trivial: remove unused variable

On Tue, Apr 13, 2021 at 9:22 AM Ilya Lipnitskiy
<[email protected]> wrote:
> Fixes the following compiler warning:
> warning: unused variable 'flags' [-Wunused-variable]
>
> Fixes: e5067c718b3a ("MIPS: pci-rt3883: Remove odd locking in PCI config space access code")
> Signed-off-by: Ilya Lipnitskiy <[email protected]>
> Cc: Sergey Ryazanov <[email protected]>
> Cc: [email protected]

Yep, I overlooked these local variables. Thank you.

Acked-by: Sergey Ryazanov <[email protected]>

--
Sergey