2020-09-20 02:13:09

by Elvira Khabirova

Subject: [PATCH] tee: fix some comment typos in header files

struct tee_param: revc -> recv.
TEE_IOC_SUPPL_SEND: typo introduced by copy-pasting, replace invalid
description with description from the according argument struct.

Signed-off-by: Elvira Khabirova <[email protected]>
---
include/linux/tee_drv.h | 2 +-
include/uapi/linux/tee.h | 2 +-
2 files changed, 2 insertions(+), 2 deletions(-)

diff --git a/include/linux/tee_drv.h b/include/linux/tee_drv.h
index d074302989dd..61557bc0e29f 100644
--- a/include/linux/tee_drv.h
+++ b/include/linux/tee_drv.h
@@ -85,7 +85,7 @@ struct tee_param {
* @close_session: close a session
* @invoke_func: invoke a trusted function
* @cancel_req: request cancel of an ongoing invoke or open
- * @supp_revc: called for supplicant to get a command
+ * @supp_recv: called for supplicant to get a command
* @supp_send: called for supplicant to send a response
* @shm_register: register shared memory buffer in TEE
* @shm_unregister: unregister shared memory buffer in TEE
diff --git a/include/uapi/linux/tee.h b/include/uapi/linux/tee.h
index b619f37ee03e..7546be5ed4f8 100644
--- a/include/uapi/linux/tee.h
+++ b/include/uapi/linux/tee.h
@@ -342,7 +342,7 @@ struct tee_iocl_supp_send_arg {
};

/**
- * TEE_IOC_SUPPL_SEND - Receive a request for a supplicant function
+ * TEE_IOC_SUPPL_SEND - Send a response to a received request
*
* Takes a struct tee_ioctl_buf_data which contains a struct
* tee_iocl_supp_send_arg followed by any array of struct tee_param
--
2.28.0

2020-09-20 02:58:15

by Gustavo A. R. Silva

Subject: Re: [PATCH] tee: fix some comment typos in header files

Hi,

Here is another one you can solve:

$ git grep -nw overlfow
net/sctp/tsnmap.c:78: * overlfow our map

Thanks
--
Gustavo

On 9/19/20 20:58, Elvira Khabirova wrote:
> struct tee_param: revc -> recv.
> TEE_IOC_SUPPL_SEND: typo introduced by copy-pasting, replace invalid
> description with description from the according argument struct.
>
> Signed-off-by: Elvira Khabirova <[email protected]>
> ---
> include/linux/tee_drv.h | 2 +-
> include/uapi/linux/tee.h | 2 +-
> 2 files changed, 2 insertions(+), 2 deletions(-)
>
> diff --git a/include/linux/tee_drv.h b/include/linux/tee_drv.h
> index d074302989dd..61557bc0e29f 100644
> --- a/include/linux/tee_drv.h
> +++ b/include/linux/tee_drv.h
> @@ -85,7 +85,7 @@ struct tee_param {
> * @close_session: close a session
> * @invoke_func: invoke a trusted function
> * @cancel_req: request cancel of an ongoing invoke or open
> - * @supp_revc: called for supplicant to get a command
> + * @supp_recv: called for supplicant to get a command
> * @supp_send: called for supplicant to send a response
> * @shm_register: register shared memory buffer in TEE
> * @shm_unregister: unregister shared memory buffer in TEE
> diff --git a/include/uapi/linux/tee.h b/include/uapi/linux/tee.h
> index b619f37ee03e..7546be5ed4f8 100644
> --- a/include/uapi/linux/tee.h
> +++ b/include/uapi/linux/tee.h
> @@ -342,7 +342,7 @@ struct tee_iocl_supp_send_arg {
> };
>
> /**
> - * TEE_IOC_SUPPL_SEND - Receive a request for a supplicant function
> + * TEE_IOC_SUPPL_SEND - Send a response to a received request
> *
> * Takes a struct tee_ioctl_buf_data which contains a struct
> * tee_iocl_supp_send_arg followed by any array of struct tee_param
>

2021-02-03 12:07:22

by Jens Wiklander

Subject: Re: [PATCH] tee: fix some comment typos in header files

On Sun, Sep 20, 2020 at 3:58 AM Elvira Khabirova
<[email protected]> wrote:
>
> struct tee_param: revc -> recv.
> TEE_IOC_SUPPL_SEND: typo introduced by copy-pasting, replace invalid
> description with description from the according argument struct.
>
> Signed-off-by: Elvira Khabirova <[email protected]>
> ---
> include/linux/tee_drv.h | 2 +-
> include/uapi/linux/tee.h | 2 +-
> 2 files changed, 2 insertions(+), 2 deletions(-)

I'll pick this up.

Thanks,
Jens

>
> diff --git a/include/linux/tee_drv.h b/include/linux/tee_drv.h
> index d074302989dd..61557bc0e29f 100644
> --- a/include/linux/tee_drv.h
> +++ b/include/linux/tee_drv.h
> @@ -85,7 +85,7 @@ struct tee_param {
> * @close_session: close a session
> * @invoke_func: invoke a trusted function
> * @cancel_req: request cancel of an ongoing invoke or open
> - * @supp_revc: called for supplicant to get a command
> + * @supp_recv: called for supplicant to get a command
> * @supp_send: called for supplicant to send a response
> * @shm_register: register shared memory buffer in TEE
> * @shm_unregister: unregister shared memory buffer in TEE
> diff --git a/include/uapi/linux/tee.h b/include/uapi/linux/tee.h
> index b619f37ee03e..7546be5ed4f8 100644
> --- a/include/uapi/linux/tee.h
> +++ b/include/uapi/linux/tee.h
> @@ -342,7 +342,7 @@ struct tee_iocl_supp_send_arg {
> };
>
> /**
> - * TEE_IOC_SUPPL_SEND - Receive a request for a supplicant function
> + * TEE_IOC_SUPPL_SEND - Send a response to a received request
> *
> * Takes a struct tee_ioctl_buf_data which contains a struct
> * tee_iocl_supp_send_arg followed by any array of struct tee_param
> --
> 2.28.0
>