2021-02-12 18:18:03

by Steve French

[permalink] [raw]
Subject: [GIT PULL] cifs fixes

Please pull the following changes since commit
92bf22614b21a2706f4993b278017e437f7785b3:

Linux 5.11-rc7 (2021-02-07 13:57:38 -0800)

are available in the Git repository at:

git://git.samba.org/sfrench/cifs-2.6.git tags/5.11-rc7-smb3

for you to fetch changes up to a738c93fb1c17e386a09304b517b1c6b2a6a5a8b:

cifs: Set CIFS_MOUNT_USE_PREFIX_PATH flag on setting
cifs_sb->prepath. (2021-02-11 11:08:32 -0600)

----------------------------------------------------------------
4 small cifs fixes for the implementation of the new mount API (including
a particularly important one for DFS links) that were found in
additional testing
this week of additional DFS scenarios, and a user testing of an apache container
problem.

Regression test results:
http://smb3-test-rhel-75.southcentralus.cloudapp.azure.com/#/builders/2/builds/501
----------------------------------------------------------------
Ronnie Sahlberg (3):
cifs: fix dfs-links
cifs: do not disable noperm if multiuser mount option is not provided
cifs: In the new mount api we get the full devname as source=

Shyam Prasad N (1):
cifs: Set CIFS_MOUNT_USE_PREFIX_PATH flag on setting cifs_sb->prepath.

fs/cifs/cifsfs.c | 2 +-
fs/cifs/connect.c | 9 +++++++++
fs/cifs/fs_context.c | 20 +++++++++++++++++---
fs/cifs/fs_context.h | 1 +
4 files changed, 28 insertions(+), 4 deletions(-)


--
Thanks,

Steve


2021-02-12 20:09:02

by Linus Torvalds

[permalink] [raw]
Subject: Re: [GIT PULL] cifs fixes

On Fri, Feb 12, 2021 at 10:16 AM Steve French <[email protected]> wrote:
>
> git://git.samba.org/sfrench/cifs-2.6.git tags/5.11-rc7-smb3

It looks like git.samba.org is feeling very sick and is not answering.
Not git, not ping (but maybe icmp ping is blocked).

Please give it a kick, or provide some other hosting mirror?

Linus

2021-02-12 20:41:49

by Steve French

[permalink] [raw]
Subject: Re: [GIT PULL] cifs fixes

Metze/Bjorn,
Linus is right - samba.org is down for me (I also verified with JRA).
Any ETA on when it gets back up?

On Fri, Feb 12, 2021 at 2:05 PM Linus Torvalds
<[email protected]> wrote:
>
> On Fri, Feb 12, 2021 at 10:16 AM Steve French <[email protected]> wrote:
> >
> > git://git.samba.org/sfrench/cifs-2.6.git tags/5.11-rc7-smb3
>
> It looks like git.samba.org is feeling very sick and is not answering.
> Not git, not ping (but maybe icmp ping is blocked).
>
> Please give it a kick, or provide some other hosting mirror?
>
> Linus



--
Thanks,

Steve

2021-02-12 21:35:13

by Steve French

[permalink] [raw]
Subject: Re: [GIT PULL] cifs fixes

The branch also was mirrored to github so could be pulled from there
if you prefer - see below (presumably the admins for samba.org, who
live in Germany, are not online - and so I am not sure when samba.org
servers will be restarted).

The following changes since commit 92bf22614b21a2706f4993b278017e437f7785b3:

Linux 5.11-rc7 (2021-02-07 13:57:38 -0800)

are available in the Git repository at:

git://github.com/smfrench/smb3-kernel.git tags/5.11-rc7-smb3-github

for you to fetch changes up to a738c93fb1c17e386a09304b517b1c6b2a6a5a8b:

cifs: Set CIFS_MOUNT_USE_PREFIX_PATH flag on setting
cifs_sb->prepath. (2021-02-11 11:08:32 -0600)

----------------------------------------------------------------
4 small smb3 fixes to the new mount API

----------------------------------------------------------------
Ronnie Sahlberg (3):
cifs: fix dfs-links
cifs: do not disable noperm if multiuser mount option is not provided
cifs: In the new mount api we get the full devname as source=

Shyam Prasad N (1):
cifs: Set CIFS_MOUNT_USE_PREFIX_PATH flag on setting cifs_sb->prepath.

fs/cifs/cifsfs.c | 2 +-
fs/cifs/connect.c | 9 +++++++++
fs/cifs/fs_context.c | 20 +++++++++++++++++---
fs/cifs/fs_context.h | 1 +
4 files changed, 28 insertions(+), 4 deletions(-)


On Fri, Feb 12, 2021 at 2:05 PM Linus Torvalds
<[email protected]> wrote:
>
> On Fri, Feb 12, 2021 at 10:16 AM Steve French <[email protected]> wrote:
> >
> > git://git.samba.org/sfrench/cifs-2.6.git tags/5.11-rc7-smb3
>
> It looks like git.samba.org is feeling very sick and is not answering.
> Not git, not ping (but maybe icmp ping is blocked).
>
> Please give it a kick, or provide some other hosting mirror?
>
> Linus



--
Thanks,

Steve

2021-02-13 01:00:36

by Stefan Metzmacher

[permalink] [raw]
Subject: Re: [GIT PULL] cifs fixes

Am 12.02.21 um 21:39 schrieb Steve French:
> Metze/Bjorn,
> Linus is right - samba.org is down for me (I also verified with JRA).
> Any ETA on when it gets back up?
>
> On Fri, Feb 12, 2021 at 2:05 PM Linus Torvalds
> <[email protected]> wrote:
>>
>> On Fri, Feb 12, 2021 at 10:16 AM Steve French <[email protected]> wrote:
>>>
>>> git://git.samba.org/sfrench/cifs-2.6.git tags/5.11-rc7-smb3
>>
>> It looks like git.samba.org is feeling very sick and is not answering.
>> Not git, not ping (but maybe icmp ping is blocked).
>>
>> Please give it a kick, or provide some other hosting mirror?


It's online again.

The machine is running a 'AMD Ryzen Threadripper 2950X 16-Core Processor'
and is freezing without any trace every view days.

We played with various boot parameters (currently we're using
'mem_encrypt=off rcu_nocbs=0-31 processor.max_cstate=1 idle=nomwait nomodeset consoleblank=0',
with the ubuntu 20.04 5.8 kernel, we also tried 5.4 before), but nothing seems to help.

metze



Attachments:
signature.asc (849.00 B)
OpenPGP digital signature

2021-02-13 01:04:30

by Linus Torvalds

[permalink] [raw]
Subject: Re: [GIT PULL] cifs fixes

On Fri, Feb 12, 2021 at 4:26 PM Stefan Metzmacher <[email protected]> wrote:
>
> The machine is running a 'AMD Ryzen Threadripper 2950X 16-Core Processor'
> and is freezing without any trace every view days.

I don't think the first-gen Zen issues ever really got solved. There
were multiple ones, with random segfaults for the early ones (but
afaik those were fixed by an RMA process with AMD), but the "it
randomly locks up" ones never had a satisfactory resolution afaik.

There were lots of random workarounds, but judging by your email:

> We played with various boot parameters (currently we're using
> 'mem_encrypt=off rcu_nocbs=0-31 processor.max_cstate=1 idle=nomwait nomodeset consoleblank=0',

I suspect you've seen all the bugzilla threads on this issue (kernel
bugzilla 196683 is probably the main one, but it was discussed
elsewhere too).

I assume you've updated to latest BIOS and looked at various BIOS
power management settings too?

Zen 2 seems to have fixed things (knock wood - it's certainly working
for me), But many people obviously never saw any issues with Zen 1
either.

Linus

2021-02-13 01:13:30

by Stefan Metzmacher

[permalink] [raw]
Subject: Re: [GIT PULL] cifs fixes

Hi Linus,

>> The machine is running a 'AMD Ryzen Threadripper 2950X 16-Core Processor'
>> and is freezing without any trace every view days.
>
> I don't think the first-gen Zen issues ever really got solved. There
> were multiple ones, with random segfaults for the early ones (but
> afaik those were fixed by an RMA process with AMD), but the "it
> randomly locks up" ones never had a satisfactory resolution afaik.
>
> There were lots of random workarounds, but judging by your email:
>
>> We played with various boot parameters (currently we're using
>> 'mem_encrypt=off rcu_nocbs=0-31 processor.max_cstate=1 idle=nomwait nomodeset consoleblank=0',
>
> I suspect you've seen all the bugzilla threads on this issue (kernel
> bugzilla 196683 is probably the main one, but it was discussed
> elsewhere too).

I just found that one, I'll have a closer look at the details in the next days.

> I assume you've updated to latest BIOS and looked at various BIOS
> power management settings too?

No, but I'll have a look at that.

> Zen 2 seems to have fixed things (knock wood - it's certainly working
> for me), But many people obviously never saw any issues with Zen 1
> either.

Do you know about the Zen3 status, I was thinking to replace the system
by this one with AMD Ryzen 9 5950X:
https://www.hetzner.com/dedicated-rootserver/ax101

Thanks!
metze



Attachments:
signature.asc (849.00 B)
OpenPGP digital signature

2021-02-13 01:33:33

by Linus Torvalds

[permalink] [raw]
Subject: Re: [GIT PULL] cifs fixes

On Fri, Feb 12, 2021 at 5:08 PM Stefan Metzmacher <[email protected]> wrote:
>
> > Zen 2 seems to have fixed things (knock wood - it's certainly working
> > for me), But many people obviously never saw any issues with Zen 1
> > either.
>
> Do you know about the Zen3 status, I was thinking to replace the system
> by this one with AMD Ryzen 9 5950X:

I have heard nothing but good things about Zen3 so far (apart from
apparently people complaining about availability), but it's only been
out a few months, so obviously coverage is somewhat limited.

I wish AMD hadn't decimated their Linux team (several years ago), and
they definitely had some embarrassing issues early on with Zen (apart
from the Zen 1 stability issues, they've screwed up rdrand at least
three times, iirc). But I've yet to hear of any Zen 3 issues, and I
suspect I'll upgrade when Threadripper comes out (I've become quite
spoiled by the build speeds of my Threadripper 3970X - the only thing
I miss is the better 'perf' support from Intel PEBS).

Note that I'm not necessarily the person who would hear about any
issues first, though, so take the above with a pinch of salt.

Linus

2021-02-13 20:07:30

by pr-tracker-bot

[permalink] [raw]
Subject: Re: [GIT PULL] cifs fixes

The pull request you sent on Fri, 12 Feb 2021 12:15:57 -0600:

> git://git.samba.org/sfrench/cifs-2.6.git tags/5.11-rc7-smb3

has been merged into torvalds/linux.git:
https://git.kernel.org/torvalds/c/7989807dc0c95c4b787698eba10905a5baac42e8

Thank you!

--
Deet-doot-dot, I am a bot.
https://korg.docs.kernel.org/prtracker.html

2021-02-19 23:50:16

by Stefan Metzmacher

[permalink] [raw]
Subject: Re: [GIT PULL] cifs fixes

Hi Linus,

>> Do you know about the Zen3 status, I was thinking to replace the system
>> by this one with AMD Ryzen 9 5950X:
>
> I have heard nothing but good things about Zen3 so far (apart from
> apparently people complaining about availability), but it's only been
> out a few months, so obviously coverage is somewhat limited.
>
> I wish AMD hadn't decimated their Linux team (several years ago), and
> they definitely had some embarrassing issues early on with Zen (apart
> from the Zen 1 stability issues, they've screwed up rdrand at least
> three times, iirc). But I've yet to hear of any Zen 3 issues, and I
> suspect I'll upgrade when Threadripper comes out (I've become quite
> spoiled by the build speeds of my Threadripper 3970X - the only thing
> I miss is the better 'perf' support from Intel PEBS).
>
> Note that I'm not necessarily the person who would hear about any
> issues first, though, so take the above with a pinch of salt.

Thanks for the hints! While we're waiting for the Ryzen 9 5950X machine
to get ready, I upgraded the Ryzen Threadripper 2950X to a 5.10 kernel
and we didn't had a freeze yet again.

Do you think 5.10 would be good for the Ryzen 9 5950X too?

Thanks!
metze




Attachments:
signature.asc (849.00 B)
OpenPGP digital signature