2021-07-22 14:12:41

by Wei Liu

[permalink] [raw]
Subject: [GIT PULL] Hyper-V fixes for 5.14-rc3

Hi Linus,

The following changes since commit e73f0f0ee7541171d89f2e2491130c7771ba58d3:

Linux 5.14-rc1 (2021-07-11 15:07:40 -0700)

are available in the Git repository at:

ssh://[email protected]/pub/scm/linux/kernel/git/hyperv/linux.git tags/hyperv-fixes-signed-20210722

for you to fetch changes up to f5a11c69b69923a4367d24365ad4dff6d4f3fc42:

Revert "x86/hyperv: fix logical processor creation" (2021-07-21 15:55:43 +0000)

----------------------------------------------------------------
hyperv-fixes for 5.14-rc3
- A bug fix from Haiyang for vmbus CPU assignment
- Reversion of a bogus patch that went into 5.14-rc1
----------------------------------------------------------------
Haiyang Zhang (1):
Drivers: hv: vmbus: Fix duplicate CPU assignments within a device

Wei Liu (1):
Revert "x86/hyperv: fix logical processor creation"

arch/x86/kernel/cpu/mshyperv.c | 2 +-
drivers/hv/channel_mgmt.c | 96 ++++++++++++++++++++++++++++--------------
2 files changed, 65 insertions(+), 33 deletions(-)


2021-07-22 17:28:14

by Linus Torvalds

[permalink] [raw]
Subject: Re: [GIT PULL] Hyper-V fixes for 5.14-rc3

On Thu, Jul 22, 2021 at 7:09 AM Wei Liu <[email protected]> wrote:
>
> - Reversion of a bogus patch that went into 5.14-rc1

When doing a revert, please explain it.

Yes, they are simple in the sense that they just undo something, but
at the same time, that "something" was done for a reason, and the
reason why that original change was wrong, and how it was noticed (ie
what the symptoms of the reverted patch were) is important.

I've pulled this, so it's too late now, but please please please
explain reverts in the future, not just a "This reverts commit XYZ".

Linus

2021-07-22 17:56:15

by Wei Liu

[permalink] [raw]
Subject: Re: [GIT PULL] Hyper-V fixes for 5.14-rc3

On Thu, Jul 22, 2021 at 10:25:46AM -0700, Linus Torvalds wrote:
> On Thu, Jul 22, 2021 at 7:09 AM Wei Liu <[email protected]> wrote:
> >
> > - Reversion of a bogus patch that went into 5.14-rc1
>
> When doing a revert, please explain it.
>
> Yes, they are simple in the sense that they just undo something, but
> at the same time, that "something" was done for a reason, and the
> reason why that original change was wrong, and how it was noticed (ie
> what the symptoms of the reverted patch were) is important.
>
> I've pulled this, so it's too late now, but please please please
> explain reverts in the future, not just a "This reverts commit XYZ".
>

Sure. Noted.

Thanks,
Wei.

2021-07-22 18:01:41

by pr-tracker-bot

[permalink] [raw]
Subject: Re: [GIT PULL] Hyper-V fixes for 5.14-rc3

The pull request you sent on Thu, 22 Jul 2021 14:09:49 +0000:

> ssh://[email protected]/pub/scm/linux/kernel/git/hyperv/linux.git tags/hyperv-fixes-signed-20210722

has been merged into torvalds/linux.git:
https://git.kernel.org/torvalds/c/7c14e4d6fbdd68bf8026868e8de263017c81b83d

Thank you!

--
Deet-doot-dot, I am a bot.
https://korg.docs.kernel.org/prtracker.html