2022-01-04 15:36:39

by Prabhakar Mahadev Lad

Subject: [PATCH] gpio: rcar: Propagate errors from devm_request_irq()

The driver overrides the error code returned by devm_request_irq() to
-ENOENT. Switch to propagating the error code upstream.

Suggested-by: Andy Shevchenko <[email protected]>
Signed-off-by: Lad Prabhakar <[email protected]>
---
This patch depends on [1].

[1] https://lkml.org/lkml/2021/12/22/633
---
drivers/gpio/gpio-rcar.c | 6 +++---
1 file changed, 3 insertions(+), 3 deletions(-)

diff --git a/drivers/gpio/gpio-rcar.c b/drivers/gpio/gpio-rcar.c
index 437baecc434e..bd2e16d6e21c 100644
--- a/drivers/gpio/gpio-rcar.c
+++ b/drivers/gpio/gpio-rcar.c
@@ -552,10 +552,10 @@ static int gpio_rcar_probe(struct platform_device *pdev)
goto err0;
}

- if (devm_request_irq(dev, p->irq_parent, gpio_rcar_irq_handler,
- IRQF_SHARED, name, p)) {
+ ret = devm_request_irq(dev, p->irq_parent, gpio_rcar_irq_handler,
+ IRQF_SHARED, name, p);
+ if (ret) {
dev_err(dev, "failed to request IRQ\n");
- ret = -ENOENT;
goto err1;
}

--
2.17.1

2022-01-04 15:54:31

by Andy Shevchenko

Subject: Re: [PATCH] gpio: rcar: Propagate errors from devm_request_irq()

On Tue, Jan 4, 2022 at 5:36 PM Lad Prabhakar
<[email protected]> wrote:
>
> The driver overrides the error code returned by devm_request_irq() to
> -ENOENT. Switch to propagating the error code upstream.

Thanks, FWIW,
Reviewed-by: Andy Shevchenko <[email protected]>

> Suggested-by: Andy Shevchenko <[email protected]>
> Signed-off-by: Lad Prabhakar <[email protected]>
> ---
> This patch depends on [1].
>
> [1] https://lkml.org/lkml/2021/12/22/633
> ---
> drivers/gpio/gpio-rcar.c | 6 +++---
> 1 file changed, 3 insertions(+), 3 deletions(-)
>
> diff --git a/drivers/gpio/gpio-rcar.c b/drivers/gpio/gpio-rcar.c
> index 437baecc434e..bd2e16d6e21c 100644
> --- a/drivers/gpio/gpio-rcar.c
> +++ b/drivers/gpio/gpio-rcar.c
> @@ -552,10 +552,10 @@ static int gpio_rcar_probe(struct platform_device *pdev)
> goto err0;
> }
>
> - if (devm_request_irq(dev, p->irq_parent, gpio_rcar_irq_handler,
> - IRQF_SHARED, name, p)) {
> + ret = devm_request_irq(dev, p->irq_parent, gpio_rcar_irq_handler,
> + IRQF_SHARED, name, p);
> + if (ret) {
> dev_err(dev, "failed to request IRQ\n");
> - ret = -ENOENT;
> goto err1;
> }
>
> --
> 2.17.1
>


--
With Best Regards,
Andy Shevchenko

2022-01-04 20:00:32

by Sergei Shtylyov

Subject: Re: [PATCH] gpio: rcar: Propagate errors from devm_request_irq()

Hello!

On 1/4/22 6:36 PM, Lad Prabhakar wrote:

> The driver overrides the error code returned by devm_request_irq() to
> -ENOENT. Switch to propagating the error code upstream.
>
> Suggested-by: Andy Shevchenko <[email protected]>
> Signed-off-by: Lad Prabhakar <[email protected]>
[...]

Reviewed-by: Sergey Shtylyov <[email protected]>

MBR, Sergey

2022-01-05 09:25:10

by Bartosz Golaszewski

Subject: Re: [PATCH] gpio: rcar: Propagate errors from devm_request_irq()

On Tue, Jan 4, 2022 at 4:36 PM Lad Prabhakar
<[email protected]> wrote:
>
> The driver overrides the error code returned by devm_request_irq() to
> -ENOENT. Switch to propagating the error code upstream.
>
> Suggested-by: Andy Shevchenko <[email protected]>
> Signed-off-by: Lad Prabhakar <[email protected]>
> ---

Applied, thanks!

Bart