2022-01-04 17:50:51

by Prabhakar Mahadev Lad

Subject: [PATCH] serial: 8250_bcm7271: Fix return error code in case of dma_alloc_coherent() failure

In case of dma_alloc_coherent() failure return -ENOMEM instead of
returning -EINVAL.

Fixes: c195438f1e84 ("serial: 8250_bcm7271: Propagate error codes from brcmuart_probe()")
Reported-by: Andy Shevchenko <[email protected]>
Signed-off-by: Lad Prabhakar <[email protected]>
---
Hi All,

This patch applies to -next.

Cheers,
Prabhakar
---
drivers/tty/serial/8250/8250_bcm7271.c | 4 ++--
1 file changed, 2 insertions(+), 2 deletions(-)

diff --git a/drivers/tty/serial/8250/8250_bcm7271.c b/drivers/tty/serial/8250/8250_bcm7271.c
index cc60a7874e8b..9b878d023dac 100644
--- a/drivers/tty/serial/8250/8250_bcm7271.c
+++ b/drivers/tty/serial/8250/8250_bcm7271.c
@@ -1075,7 +1075,7 @@ static int brcmuart_probe(struct platform_device *pdev)
priv->rx_size,
&priv->rx_addr, GFP_KERNEL);
if (!priv->rx_bufs) {
- ret = -EINVAL;
+ ret = -ENOMEM;
goto err;
}
priv->tx_size = UART_XMIT_SIZE;
@@ -1083,7 +1083,7 @@ static int brcmuart_probe(struct platform_device *pdev)
priv->tx_size,
&priv->tx_addr, GFP_KERNEL);
if (!priv->tx_buf) {
- ret = -EINVAL;
+ ret = -ENOMEM;
goto err;
}
}
--
2.17.1

2022-01-04 18:13:01

by Florian Fainelli

Subject: Re: [PATCH] serial: 8250_bcm7271: Fix return error code in case of dma_alloc_coherent() failure

On 1/4/22 9:50 AM, Lad Prabhakar wrote:
> In case of dma_alloc_coherent() failure return -ENOMEM instead of
> returning -EINVAL.
>
> Fixes: c195438f1e84 ("serial: 8250_bcm7271: Propagate error codes from brcmuart_probe()")
> Reported-by: Andy Shevchenko <[email protected]>
> Signed-off-by: Lad Prabhakar <[email protected]>

Acked-by: Florian Fainelli <[email protected]>

The fixes tag may be a bit superfluous since this is just an error path,
but it is correct nonetheless.
--
Florian

2022-01-05 09:49:41

by Andy Shevchenko

Subject: Re: [PATCH] serial: 8250_bcm7271: Fix return error code in case of dma_alloc_coherent() failure

On Tue, Jan 4, 2022 at 7:50 PM Lad Prabhakar
<[email protected]> wrote:
>
> In case of dma_alloc_coherent() failure return -ENOMEM instead of
> returning -EINVAL.
>
> Fixes: c195438f1e84 ("serial: 8250_bcm7271: Propagate error codes from brcmuart_probe()")

It doesn't fix any issue that needs to be backported.
After dropping that tag,
Reviewed-by: Andy Shevchenko <[email protected]>

> Reported-by: Andy Shevchenko <[email protected]>
> Signed-off-by: Lad Prabhakar <[email protected]>
> ---
> Hi All,
>
> This patch applies to -next.

The rule of thumb is to test it against the subsystem thru which you
are routing your patch, in this case you need to use tty-next.

>
> Cheers,
> Prabhakar
> ---
> drivers/tty/serial/8250/8250_bcm7271.c | 4 ++--
> 1 file changed, 2 insertions(+), 2 deletions(-)
>
> diff --git a/drivers/tty/serial/8250/8250_bcm7271.c b/drivers/tty/serial/8250/8250_bcm7271.c
> index cc60a7874e8b..9b878d023dac 100644
> --- a/drivers/tty/serial/8250/8250_bcm7271.c
> +++ b/drivers/tty/serial/8250/8250_bcm7271.c
> @@ -1075,7 +1075,7 @@ static int brcmuart_probe(struct platform_device *pdev)
> priv->rx_size,
> &priv->rx_addr, GFP_KERNEL);
> if (!priv->rx_bufs) {
> - ret = -EINVAL;
> + ret = -ENOMEM;
> goto err;
> }
> priv->tx_size = UART_XMIT_SIZE;
> @@ -1083,7 +1083,7 @@ static int brcmuart_probe(struct platform_device *pdev)
> priv->tx_size,
> &priv->tx_addr, GFP_KERNEL);
> if (!priv->tx_buf) {
> - ret = -EINVAL;
> + ret = -ENOMEM;
> goto err;
> }
> }
> --
> 2.17.1
>


--
With Best Regards,
Andy Shevchenko