LinuxLists.cc - [PATCH] platform/x86: Replace HTTP links with HTTPS ones

2020-07-13 18:49:11

Subject: [PATCH] platform/x86: Replace HTTP links with HTTPS ones

Rationale:
Reduces attack surface on kernel devs opening the links for MITM
as HTTPS traffic is much harder to manipulate.

Deterministic algorithm:
For each file:
If not .svg:
For each line:
If doesn't contain `\bxmlns\b`:
For each link, `\bhttp://[^# \t\r\n]*(?:\w|/)`:
If neither `\bgnu\.org/license`, nor `\bmozilla\.org/MPL\b`:
If both the HTTP and HTTPS versions
return 200 OK and serve the same content:
Replace HTTP with HTTPS.

Signed-off-by: Alexander A. Klimov <[email protected]>
---
Continuing my work started at 93431e0607e5.
See also: git log --oneline '--author=Alexander A. Klimov <[email protected]>' v5.7..master
(Actually letting a shell for loop submit all this stuff for me.)

If there are any URLs to be removed completely or at least not just HTTPSified:
Just clearly say so and I'll *undo my change*.
See also: https://lkml.org/lkml/2020/6/27/64

If there are any valid, but yet not changed URLs:
See: https://lkml.org/lkml/2020/6/26/837

If you apply the patch, please let me know.

Sorry again to all maintainers who complained about subject lines.
Now I realized that you want an actually perfect prefixes,
not just subsystem ones.
I tried my best...
And yes, *I could* (at least half-)automate it.
Impossible is nothing! :)

drivers/platform/x86/Kconfig | 2 +-
drivers/platform/x86/apple-gmux.c | 16 ++++++++--------
2 files changed, 9 insertions(+), 9 deletions(-)

diff --git a/drivers/platform/x86/Kconfig b/drivers/platform/x86/Kconfig
index 0581a54cf562..1d96e07b2a02 100644
--- a/drivers/platform/x86/Kconfig
+++ b/drivers/platform/x86/Kconfig
@@ -140,7 +140,7 @@ config ACERHDF
in the same node directory will tell you if it is "acerhdf".

For more information about this driver see
- <http://piie.net/files/acerhdf_README.txt>
+ <https://piie.net/files/acerhdf_README.txt>

If you have an Acer Aspire One netbook, say Y or M
here.
diff --git a/drivers/platform/x86/apple-gmux.c b/drivers/platform/x86/apple-gmux.c
index 7e3083deb1c5..9aae45a45200 100644
--- a/drivers/platform/x86/apple-gmux.c
+++ b/drivers/platform/x86/apple-gmux.c
@@ -277,8 +277,8 @@ static bool gmux_is_indexed(struct apple_gmux_data *gmux_data)
* MBP5 2008/09 uses a `TI LP8543`_ backlight driver. All newer models
* use a `TI LP8545`_.
*
- * .. _TI LP8543: http://www.ti.com/lit/ds/symlink/lp8543.pdf
- * .. _TI LP8545: http://www.ti.com/lit/ds/symlink/lp8545.pdf
+ * .. _TI LP8543: https://www.ti.com/lit/ds/symlink/lp8543.pdf
+ * .. _TI LP8545: https://www.ti.com/lit/ds/symlink/lp8545.pdf
*/

static int gmux_get_brightness(struct backlight_device *bd)
@@ -373,14 +373,14 @@ static const struct backlight_ops gmux_bl_ops = {
* switch the panel and the external DP connector and allocates a framebuffer
* for the selected GPU.
*
- * .. _US 8,687,007 B2: http://pimg-fpiw.uspto.gov/fdd/07/870/086/0.pdf
- * .. _NXP CBTL06141: http://www.nxp.com/documents/data_sheet/CBTL06141.pdf
- * .. _NXP CBTL06142: http://www.nxp.com/documents/data_sheet/CBTL06141.pdf
- * .. _TI HD3SS212: http://www.ti.com/lit/ds/symlink/hd3ss212.pdf
+ * .. _US 8,687,007 B2: https://pimg-fpiw.uspto.gov/fdd/07/870/086/0.pdf
+ * .. _NXP CBTL06141: https://www.nxp.com/documents/data_sheet/CBTL06141.pdf
+ * .. _NXP CBTL06142: https://www.nxp.com/documents/data_sheet/CBTL06141.pdf
+ * .. _TI HD3SS212: https://www.ti.com/lit/ds/symlink/hd3ss212.pdf
* .. _Pericom PI3VDP12412: https://www.pericom.com/assets/Datasheets/PI3VDP12412.pdf
- * .. _TI SN74LV4066A: http://www.ti.com/lit/ds/symlink/sn74lv4066a.pdf
+ * .. _TI SN74LV4066A: https://www.ti.com/lit/ds/symlink/sn74lv4066a.pdf
* .. _NXP CBTL03062: http://pdf.datasheetarchive.com/indexerfiles/Datasheets-SW16/DSASW00308511.pdf
- * .. _TI TS3DS10224: http://www.ti.com/lit/ds/symlink/ts3ds10224.pdf
+ * .. _TI TS3DS10224: https://www.ti.com/lit/ds/symlink/ts3ds10224.pdf
*/

static void gmux_read_switch_state(struct apple_gmux_data *gmux_data)
--
2.27.0

2020-07-13 19:18:23

by Andy Shevchenko

[permalink] [raw]

Subject: Re: [PATCH] platform/x86: Replace HTTP links with HTTPS ones

On Mon, Jul 13, 2020 at 9:46 PM Alexander A. Klimov
<[email protected]> wrote:
>
> Rationale:
> Reduces attack surface on kernel devs opening the links for MITM
> as HTTPS traffic is much harder to manipulate.
>
> Deterministic algorithm:
> For each file:
> If not .svg:
> For each line:
> If doesn't contain `\bxmlns\b`:
> For each link, `\bhttp://[^# \t\r\n]*(?:\w|/)`:
> If neither `\bgnu\.org/license`, nor `\bmozilla\.org/MPL\b`:
> If both the HTTP and HTTPS versions
> return 200 OK and serve the same content:
> Replace HTTP with HTTPS.

Please split per driver basis.

> Signed-off-by: Alexander A. Klimov <[email protected]>
> ---
> Continuing my work started at 93431e0607e5.
> See also: git log --oneline '--author=Alexander A. Klimov <[email protected]>' v5.7..master
> (Actually letting a shell for loop submit all this stuff for me.)
>
> If there are any URLs to be removed completely or at least not just HTTPSified:
> Just clearly say so and I'll *undo my change*.
> See also: https://lkml.org/lkml/2020/6/27/64
>
> If there are any valid, but yet not changed URLs:
> See: https://lkml.org/lkml/2020/6/26/837
>
> If you apply the patch, please let me know.
>
> Sorry again to all maintainers who complained about subject lines.
> Now I realized that you want an actually perfect prefixes,
> not just subsystem ones.
> I tried my best...
> And yes, *I could* (at least half-)automate it.
> Impossible is nothing! :)
>
>
> drivers/platform/x86/Kconfig | 2 +-
> drivers/platform/x86/apple-gmux.c | 16 ++++++++--------
> 2 files changed, 9 insertions(+), 9 deletions(-)
>
> diff --git a/drivers/platform/x86/Kconfig b/drivers/platform/x86/Kconfig
> index 0581a54cf562..1d96e07b2a02 100644
> --- a/drivers/platform/x86/Kconfig
> +++ b/drivers/platform/x86/Kconfig
> @@ -140,7 +140,7 @@ config ACERHDF
> in the same node directory will tell you if it is "acerhdf".
>
> For more information about this driver see
> - <http://piie.net/files/acerhdf_README.txt>
> + <https://piie.net/files/acerhdf_README.txt>
>
> If you have an Acer Aspire One netbook, say Y or M
> here.
> diff --git a/drivers/platform/x86/apple-gmux.c b/drivers/platform/x86/apple-gmux.c
> index 7e3083deb1c5..9aae45a45200 100644
> --- a/drivers/platform/x86/apple-gmux.c
> +++ b/drivers/platform/x86/apple-gmux.c
> @@ -277,8 +277,8 @@ static bool gmux_is_indexed(struct apple_gmux_data *gmux_data)
> * MBP5 2008/09 uses a `TI LP8543`_ backlight driver. All newer models
> * use a `TI LP8545`_.
> *
> - * .. _TI LP8543: http://www.ti.com/lit/ds/symlink/lp8543.pdf
> - * .. _TI LP8545: http://www.ti.com/lit/ds/symlink/lp8545.pdf
> + * .. _TI LP8543: https://www.ti.com/lit/ds/symlink/lp8543.pdf
> + * .. _TI LP8545: https://www.ti.com/lit/ds/symlink/lp8545.pdf
> */
>
> static int gmux_get_brightness(struct backlight_device *bd)
> @@ -373,14 +373,14 @@ static const struct backlight_ops gmux_bl_ops = {
> * switch the panel and the external DP connector and allocates a framebuffer
> * for the selected GPU.
> *
> - * .. _US 8,687,007 B2: http://pimg-fpiw.uspto.gov/fdd/07/870/086/0.pdf
> - * .. _NXP CBTL06141: http://www.nxp.com/documents/data_sheet/CBTL06141.pdf
> - * .. _NXP CBTL06142: http://www.nxp.com/documents/data_sheet/CBTL06141.pdf
> - * .. _TI HD3SS212: http://www.ti.com/lit/ds/symlink/hd3ss212.pdf
> + * .. _US 8,687,007 B2: https://pimg-fpiw.uspto.gov/fdd/07/870/086/0.pdf
> + * .. _NXP CBTL06141: https://www.nxp.com/documents/data_sheet/CBTL06141.pdf
> + * .. _NXP CBTL06142: https://www.nxp.com/documents/data_sheet/CBTL06141.pdf
> + * .. _TI HD3SS212: https://www.ti.com/lit/ds/symlink/hd3ss212.pdf
> * .. _Pericom PI3VDP12412: https://www.pericom.com/assets/Datasheets/PI3VDP12412.pdf
> - * .. _TI SN74LV4066A: http://www.ti.com/lit/ds/symlink/sn74lv4066a.pdf
> + * .. _TI SN74LV4066A: https://www.ti.com/lit/ds/symlink/sn74lv4066a.pdf
> * .. _NXP CBTL03062: http://pdf.datasheetarchive.com/indexerfiles/Datasheets-SW16/DSASW00308511.pdf
> - * .. _TI TS3DS10224: http://www.ti.com/lit/ds/symlink/ts3ds10224.pdf
> + * .. _TI TS3DS10224: https://www.ti.com/lit/ds/symlink/ts3ds10224.pdf
> */
>
> static void gmux_read_switch_state(struct apple_gmux_data *gmux_data)
> --
> 2.27.0
>

--
With Best Regards,
Andy Shevchenko

2020-07-13 22:23:54

by Alexander A. Klimov

[permalink] [raw]

Subject: Re: [PATCH] platform/x86: Replace HTTP links with HTTPS ones

Am 13.07.20 um 21:17 schrieb Andy Shevchenko:
> On Mon, Jul 13, 2020 at 9:46 PM Alexander A. Klimov
> <[email protected]> wrote:
>>
>> Rationale:
>> Reduces attack surface on kernel devs opening the links for MITM
>> as HTTPS traffic is much harder to manipulate.
>>
>> Deterministic algorithm:
>> For each file:
>> If not .svg:
>> For each line:
>> If doesn't contain `\bxmlns\b`:
>> For each link, `\bhttp://[^# \t\r\n]*(?:\w|/)`:
>> If neither `\bgnu\.org/license`, nor `\bmozilla\.org/MPL\b`:
>> If both the HTTP and HTTPS versions
>> return 200 OK and serve the same content:
>> Replace HTTP with HTTPS.
>
> Please split per driver basis.
Am I completely blind or is there only one driver affected by my patch?

>
>> Signed-off-by: Alexander A. Klimov <[email protected]>
>> ---
>> Continuing my work started at 93431e0607e5.
>> See also: git log --oneline '--author=Alexander A. Klimov <[email protected]>' v5.7..master
>> (Actually letting a shell for loop submit all this stuff for me.)
>>
>> If there are any URLs to be removed completely or at least not just HTTPSified:
>> Just clearly say so and I'll *undo my change*.
>> See also: https://lkml.org/lkml/2020/6/27/64
>>
>> If there are any valid, but yet not changed URLs:
>> See: https://lkml.org/lkml/2020/6/26/837
>>
>> If you apply the patch, please let me know.
>>
>> Sorry again to all maintainers who complained about subject lines.
>> Now I realized that you want an actually perfect prefixes,
>> not just subsystem ones.
>> I tried my best...
>> And yes, *I could* (at least half-)automate it.
>> Impossible is nothing! :)
>>
>>
>> drivers/platform/x86/Kconfig | 2 +-
>> drivers/platform/x86/apple-gmux.c | 16 ++++++++--------
>> 2 files changed, 9 insertions(+), 9 deletions(-)
>>
>> diff --git a/drivers/platform/x86/Kconfig b/drivers/platform/x86/Kconfig
>> index 0581a54cf562..1d96e07b2a02 100644
>> --- a/drivers/platform/x86/Kconfig
>> +++ b/drivers/platform/x86/Kconfig
>> @@ -140,7 +140,7 @@ config ACERHDF
>> in the same node directory will tell you if it is "acerhdf".
>>
>> For more information about this driver see
>> - <http://piie.net/files/acerhdf_README.txt>
>> + <https://piie.net/files/acerhdf_README.txt>
>>
>> If you have an Acer Aspire One netbook, say Y or M
>> here.
>> diff --git a/drivers/platform/x86/apple-gmux.c b/drivers/platform/x86/apple-gmux.c
>> index 7e3083deb1c5..9aae45a45200 100644
>> --- a/drivers/platform/x86/apple-gmux.c
>> +++ b/drivers/platform/x86/apple-gmux.c
>> @@ -277,8 +277,8 @@ static bool gmux_is_indexed(struct apple_gmux_data *gmux_data)
>> * MBP5 2008/09 uses a `TI LP8543`_ backlight driver. All newer models
>> * use a `TI LP8545`_.
>> *
>> - * .. _TI LP8543: http://www.ti.com/lit/ds/symlink/lp8543.pdf
>> - * .. _TI LP8545: http://www.ti.com/lit/ds/symlink/lp8545.pdf
>> + * .. _TI LP8543: https://www.ti.com/lit/ds/symlink/lp8543.pdf
>> + * .. _TI LP8545: https://www.ti.com/lit/ds/symlink/lp8545.pdf
>> */
>>
>> static int gmux_get_brightness(struct backlight_device *bd)
>> @@ -373,14 +373,14 @@ static const struct backlight_ops gmux_bl_ops = {
>> * switch the panel and the external DP connector and allocates a framebuffer
>> * for the selected GPU.
>> *
>> - * .. _US 8,687,007 B2: http://pimg-fpiw.uspto.gov/fdd/07/870/086/0.pdf
>> - * .. _NXP CBTL06141: http://www.nxp.com/documents/data_sheet/CBTL06141.pdf
>> - * .. _NXP CBTL06142: http://www.nxp.com/documents/data_sheet/CBTL06141.pdf
>> - * .. _TI HD3SS212: http://www.ti.com/lit/ds/symlink/hd3ss212.pdf
>> + * .. _US 8,687,007 B2: https://pimg-fpiw.uspto.gov/fdd/07/870/086/0.pdf
>> + * .. _NXP CBTL06141: https://www.nxp.com/documents/data_sheet/CBTL06141.pdf
>> + * .. _NXP CBTL06142: https://www.nxp.com/documents/data_sheet/CBTL06141.pdf
>> + * .. _TI HD3SS212: https://www.ti.com/lit/ds/symlink/hd3ss212.pdf
>> * .. _Pericom PI3VDP12412: https://www.pericom.com/assets/Datasheets/PI3VDP12412.pdf
>> - * .. _TI SN74LV4066A: http://www.ti.com/lit/ds/symlink/sn74lv4066a.pdf
>> + * .. _TI SN74LV4066A: https://www.ti.com/lit/ds/symlink/sn74lv4066a.pdf
>> * .. _NXP CBTL03062: http://pdf.datasheetarchive.com/indexerfiles/Datasheets-SW16/DSASW00308511.pdf
>> - * .. _TI TS3DS10224: http://www.ti.com/lit/ds/symlink/ts3ds10224.pdf
>> + * .. _TI TS3DS10224: https://www.ti.com/lit/ds/symlink/ts3ds10224.pdf
>> */
>>
>> static void gmux_read_switch_state(struct apple_gmux_data *gmux_data)
>> --
>> 2.27.0
>>
>
>

2020-07-14 19:09:06

by Alexander A. Klimov

[permalink] [raw]

Subject: [PATCH] platform/x86: apple-gmux: Replace HTTP links with HTTPS ones

2020-07-14 19:09:38

by Alexander A. Klimov

[permalink] [raw]

Subject: [PATCH] platform/x86: acerhdf: Replace HTTP links with HTTPS ones

2020-07-15 11:17:06

by Andy Shevchenko

[permalink] [raw]

Subject: Re: [PATCH] platform/x86: apple-gmux: Replace HTTP links with HTTPS ones

On Tue, Jul 14, 2020 at 10:07 PM Alexander A. Klimov
<[email protected]> wrote:
>
> Rationale:
> Reduces attack surface on kernel devs opening the links for MITM
> as HTTPS traffic is much harder to manipulate.
>
> Deterministic algorithm:
> For each file:
> If not .svg:
> For each line:
> If doesn't contain `\bxmlns\b`:
> For each link, `\bhttp://[^# \t\r\n]*(?:\w|/)`:
> If neither `\bgnu\.org/license`, nor `\bmozilla\.org/MPL\b`:
> If both the HTTP and HTTPS versions
> return 200 OK and serve the same content:
> Replace HTTP with HTTPS.
>

Pushed to my review and testing queue, thanks!

> Signed-off-by: Alexander A. Klimov <[email protected]>
> ---
> drivers/platform/x86/apple-gmux.c | 16 ++++++++--------
> 1 file changed, 8 insertions(+), 8 deletions(-)
>
> diff --git a/drivers/platform/x86/apple-gmux.c b/drivers/platform/x86/apple-gmux.c
> index 7e3083deb1c5..9aae45a45200 100644
> --- a/drivers/platform/x86/apple-gmux.c
> +++ b/drivers/platform/x86/apple-gmux.c
> @@ -277,8 +277,8 @@ static bool gmux_is_indexed(struct apple_gmux_data *gmux_data)
> * MBP5 2008/09 uses a `TI LP8543`_ backlight driver. All newer models
> * use a `TI LP8545`_.
> *
> - * .. _TI LP8543: http://www.ti.com/lit/ds/symlink/lp8543.pdf
> - * .. _TI LP8545: http://www.ti.com/lit/ds/symlink/lp8545.pdf
> + * .. _TI LP8543: https://www.ti.com/lit/ds/symlink/lp8543.pdf
> + * .. _TI LP8545: https://www.ti.com/lit/ds/symlink/lp8545.pdf
> */
>
> static int gmux_get_brightness(struct backlight_device *bd)
> @@ -373,14 +373,14 @@ static const struct backlight_ops gmux_bl_ops = {
> * switch the panel and the external DP connector and allocates a framebuffer
> * for the selected GPU.
> *
> - * .. _US 8,687,007 B2: http://pimg-fpiw.uspto.gov/fdd/07/870/086/0.pdf
> - * .. _NXP CBTL06141: http://www.nxp.com/documents/data_sheet/CBTL06141.pdf
> - * .. _NXP CBTL06142: http://www.nxp.com/documents/data_sheet/CBTL06141.pdf
> - * .. _TI HD3SS212: http://www.ti.com/lit/ds/symlink/hd3ss212.pdf
> + * .. _US 8,687,007 B2: https://pimg-fpiw.uspto.gov/fdd/07/870/086/0.pdf
> + * .. _NXP CBTL06141: https://www.nxp.com/documents/data_sheet/CBTL06141.pdf
> + * .. _NXP CBTL06142: https://www.nxp.com/documents/data_sheet/CBTL06141.pdf
> + * .. _TI HD3SS212: https://www.ti.com/lit/ds/symlink/hd3ss212.pdf
> * .. _Pericom PI3VDP12412: https://www.pericom.com/assets/Datasheets/PI3VDP12412.pdf
> - * .. _TI SN74LV4066A: http://www.ti.com/lit/ds/symlink/sn74lv4066a.pdf
> + * .. _TI SN74LV4066A: https://www.ti.com/lit/ds/symlink/sn74lv4066a.pdf
> * .. _NXP CBTL03062: http://pdf.datasheetarchive.com/indexerfiles/Datasheets-SW16/DSASW00308511.pdf
> - * .. _TI TS3DS10224: http://www.ti.com/lit/ds/symlink/ts3ds10224.pdf
> + * .. _TI TS3DS10224: https://www.ti.com/lit/ds/symlink/ts3ds10224.pdf
> */
>
> static void gmux_read_switch_state(struct apple_gmux_data *gmux_data)
> --
> 2.27.0
>

--
With Best Regards,
Andy Shevchenko

2020-07-15 11:19:28

by Andy Shevchenko

[permalink] [raw]

Subject: Re: [PATCH] platform/x86: acerhdf: Replace HTTP links with HTTPS ones

2020-07-15 19:00:42

by Alexander A. Klimov

[permalink] [raw]

Subject: [PATCH] platform/x86: Replace HTTP links with HTTPS ones

Subject: Re: [PATCH] platform/x86: Replace HTTP links with HTTPS ones

Subject: Re: [PATCH] platform/x86: Replace HTTP links with HTTPS ones

Subject: [PATCH] platform/x86: apple-gmux: Replace HTTP links with HTTPS ones

Subject: [PATCH] platform/x86: acerhdf: Replace HTTP links with HTTPS ones

Subject: Re: [PATCH] platform/x86: apple-gmux: Replace HTTP links with HTTPS ones

Subject: Re: [PATCH] platform/x86: acerhdf: Replace HTTP links with HTTPS ones

Subject: [PATCH v2] platform/x86: acerhdf: Replace HTTP links with HTTPS ones