Subject: Re: [PATCH v2 04/11] pinctrl: mediatek: Provide a helper macro PINCTRL_PIN_FUNCTION()

Il 28/05/24 21:44, Andy Shevchenko ha scritto:
> Provide a helper macro to assign the struct function_desc entries.
> This helps further refactoring.
>
> Signed-off-by: Andy Shevchenko <[email protected]>

Not a strong opinion but, for commodity, I'd like to see "moore" mentioned in the
title, as only the Moore pinctrl IPs are being touched here (where MTK has two
different IPs: Moore and Paris).

In any case:

Reviewed-by: AngeloGioacchino Del Regno <[email protected]>




2024-05-29 09:39:33

by Andy Shevchenko

[permalink] [raw]
Subject: Re: [PATCH v2 04/11] pinctrl: mediatek: Provide a helper macro PINCTRL_PIN_FUNCTION()

On Wed, May 29, 2024 at 11:24 AM AngeloGioacchino Del Regno
<[email protected]> wrote:
> Il 28/05/24 21:44, Andy Shevchenko ha scritto:
> > Provide a helper macro to assign the struct function_desc entries.
> > This helps further refactoring.
> >
> > Signed-off-by: Andy Shevchenko <[email protected]>
>
> Not a strong opinion but, for commodity, I'd like to see "moore" mentioned in the
> title, as only the Moore pinctrl IPs are being touched here (where MTK has two
> different IPs: Moore and Paris).

If I need a new version, sure, I'll add that.

> In any case:
>
> Reviewed-by: AngeloGioacchino Del Regno <[email protected]>

Thanks!

--
With Best Regards,
Andy Shevchenko