This patchset adds BMP380 variant to the already existing drivers for
the Bosch BMP180/280 pressure sensors.
Patch 1 is a minor refactor simplifying driver initialization logic
to facilitate the integration of the new sensor variant extending the
information stored in the "chip_info" struct.
Patch 2 fixes DMA unsafe regmap_bulk_* calls reported by Jonathan Cameron
<[email protected]>.
Patch 3 adds the basic logic to initialize and read measurements from
the sensor.
Patch 4 adds references and sensor id to the devicetree bindings docs.
Patch 5 adds advanced configurable features such as sampling frequency
and IIR filter through the IIO sysfs ABI.
Changes in v5:
- Moved dt bindings patch (previously patch 2/5) to 4/5 to preserve
tree coherence as suggested by Jonathan Cameron <[email protected]>
- Patch 1: Simplified initial oversampling values assignation.
- Patch 1: Updated codepaths for bmp180 and bmp280 to use FIELD_GET and
FIELD_GET helpers. Migrated compatible masks to use GENMASK.
- Patch 2: Store DMA-safe buffers on the device data struct instead of
using dynamic allocations for calibration buffers.
Thanks Jonathan Cameron <[email protected]>.
- Patch 3: Fixed small typos
- Patch 3: Fixed incompatible division on 32-bit machines reported by
Andy Shevchenko <[email protected]> and kernel test robot
<[email protected]>.
- Patch 3: Fixed inconsistent use of "x" and "X" declaring constants.
- Patch 5: Dropped incorrect reported-by tag on changelog message.
- Patch 5: Fixed typos on various comments.
Changes in v4:
- Patch 4 and 2: Merged v3 patch 2 (Kconfig refs update) into this patch.
- Patch 3: Added patch fixing unsafe DMA regmap_bulk_* calls reported by
Jonathan Cameron <[email protected]>.
- Patch 4: Fixed DMA unsafe buffers used on regmap_bulk_* calls reported
by Jonathan Cameron <[email protected]>.
Changes in v3:
- Patch 2: Fixed incorrect abbreviation.
- Patch 3: use dev_err_probe helper to handle error initializing sensor.
- Patch 4: Fixed kernel test robot warning provoked by missing include.
- Patch 4: Fixed bug reported by Dan Carpenter <[email protected]>.
- Patch 5: Fixed formatting and typos on multiple comments.
- Patch 5: Fixed missing boolean initialization reported by
Andy Shevchenko <[email protected]>.
- Patch 5: Replaced duplicated comments with a single comment containing
a brief explantation in a shared location.
- Patch 5: Dropped incorrect use of unlikely macro.
Changes in v2:
- Added patch 2 updating Kconfig with references to new sensor.
- Patch 3 adds changes proposed by Jonathan Cameron <[email protected]>
to declutter and unify configuration logic for the different sensors
extending "chip_info" struct with default configuration parameters.
- Patch 4: store temperature and pressure adc values on 3 byte array
instead of using the type __le32. Uses function get_unaligned_le24
to convert the little-endian encoded 3 byte value to an integer.
- Patch 4: drops custom macro le16_from_bytes and use get_unaligned_le16.
- Patch 4: generate masks using GENMASK macro.
- Patch 4: use FIELD_PREP to generate bitfields for registries.
- Patch 4: dropped stray formatting change.
- Patch 5: adds sanity checks in bmp280_read_raw for channel properties
only available in the BMP380.
- Patch 5: on bmp280_write_* checks if a problem occurred committing new
configuration and tries to restore previous working configuration
to keep the sensor in a previous working state.
- Patch 5: refactored bmp380_chip_config to only check for configuration
errors when a configuration change is detected.
- Patch 5: improved invalid configuration detection on BMP380 restarting
measurement loop to force a new measurement after the configuration is
updated.
Previous patch version available on:
https://lore.kernel.org/all/[email protected]/
Angel Iglesias (5):
iio: pressure: bmp280: simplify driver initialization logic
iio: pressure: bmp280: Fix alignment for DMA safety
iio: pressure: bmp280: Add support for BMP380 sensor family
dt-bindings: iio: pressure: bmp085: Add BMP380 compatible string
iio: pressure: bmp280: Add more tunable config parameters for BMP380
.../bindings/iio/pressure/bmp085.yaml | 4 +-
drivers/iio/pressure/Kconfig | 6 +-
drivers/iio/pressure/bmp280-core.c | 866 +++++++++++++++---
drivers/iio/pressure/bmp280-i2c.c | 5 +
drivers/iio/pressure/bmp280-regmap.c | 55 ++
drivers/iio/pressure/bmp280-spi.c | 5 +
drivers/iio/pressure/bmp280.h | 159 +++-
7 files changed, 952 insertions(+), 148 deletions(-)
base-commit: 180c6cb6b9b79c55b79e8414f4c0208f2463af7d
--
2.37.1
Adds compatibility with the new generation of this sensor, the BMP380
Includes basic sensor initialization to do pressure and temp
measurements and allows tuning oversampling settings for each channel.
The compensation algorithms are adapted from the device datasheet and
the repository https://github.com/BoschSensortec/BMP3-Sensor-API
Signed-off-by: Angel Iglesias <[email protected]>
---
drivers/iio/pressure/Kconfig | 6 +-
drivers/iio/pressure/bmp280-core.c | 354 +++++++++++++++++++++++++++
drivers/iio/pressure/bmp280-i2c.c | 5 +
drivers/iio/pressure/bmp280-regmap.c | 55 +++++
drivers/iio/pressure/bmp280-spi.c | 5 +
drivers/iio/pressure/bmp280.h | 101 ++++++++
6 files changed, 523 insertions(+), 3 deletions(-)
diff --git a/drivers/iio/pressure/Kconfig b/drivers/iio/pressure/Kconfig
index 0ff756cea63a..c9453389e4f7 100644
--- a/drivers/iio/pressure/Kconfig
+++ b/drivers/iio/pressure/Kconfig
@@ -17,14 +17,14 @@ config ABP060MG
will be called abp060mg.
config BMP280
- tristate "Bosch Sensortec BMP180/BMP280 pressure sensor I2C driver"
+ tristate "Bosch Sensortec BMP180/BMP280/BMP380 pressure sensor I2C driver"
depends on (I2C || SPI_MASTER)
select REGMAP
select BMP280_I2C if (I2C)
select BMP280_SPI if (SPI_MASTER)
help
- Say yes here to build support for Bosch Sensortec BMP180 and BMP280
- pressure and temperature sensors. Also supports the BME280 with
+ Say yes here to build support for Bosch Sensortec BMP180, BMP280 and
+ BMP380 pressure and temperature sensors. Also supports the BME280 with
an additional humidity sensor channel.
To compile this driver as a module, choose M here: the core module
diff --git a/drivers/iio/pressure/bmp280-core.c b/drivers/iio/pressure/bmp280-core.c
index 4cd657dcbfed..fe171908a89c 100644
--- a/drivers/iio/pressure/bmp280-core.c
+++ b/drivers/iio/pressure/bmp280-core.c
@@ -12,6 +12,7 @@
* https://ae-bst.resource.bosch.com/media/_tech/media/datasheets/BST-BMP180-DS000-121.pdf
* https://ae-bst.resource.bosch.com/media/_tech/media/datasheets/BST-BMP280-DS001-12.pdf
* https://ae-bst.resource.bosch.com/media/_tech/media/datasheets/BST-BME280_DS001-11.pdf
+ * https://www.bosch-sensortec.com/media/boschsensortec/downloads/datasheets/bst-bmp388-ds001.pdf
*/
#define pr_fmt(fmt) "bmp280: " fmt
@@ -77,6 +78,24 @@ struct bmp280_calib {
s8 H6;
};
+/* See datasheet Section 3.11.1. */
+struct bmp380_calib {
+ u16 T1;
+ u16 T2;
+ s8 T3;
+ s16 P1;
+ s16 P2;
+ s8 P3;
+ s8 P4;
+ u16 P5;
+ u16 P6;
+ s8 P7;
+ s8 P8;
+ s16 P9;
+ s8 P10;
+ s8 P11;
+};
+
static const char *const bmp280_supply_names[] = {
"vddd", "vdda"
};
@@ -93,6 +112,7 @@ struct bmp280_data {
union {
struct bmp180_calib bmp180;
struct bmp280_calib bmp280;
+ struct bmp380_calib bmp380;
} calib;
struct regulator_bulk_data supplies[BMP280_NUM_SUPPLIES];
unsigned int start_up_time; /* in microseconds */
@@ -118,6 +138,7 @@ struct bmp280_data {
/* calibration data buffers */
__le16 bmp280_cal[BMP280_CONTIGUOUS_CALIB_REGS / 2];
__be16 bmp180_cal[BMP180_REG_CALIB_COUNT / 2];
+ u8 bmp380_cal[BMP380_CALIB_REG_COUNT];
} buf __aligned(IIO_DMA_MINALIGN);
};
@@ -153,6 +174,25 @@ struct bmp280_chip_info {
enum { T1, T2, T3 };
enum { P1, P2, P3, P4, P5, P6, P7, P8, P9 };
+enum {
+ /* Temperature calib indexes */
+ BMP380_T1 = 0,
+ BMP380_T2 = 2,
+ BMP380_T3 = 4,
+ /* Pressure calib indexes */
+ BMP380_P1 = 5,
+ BMP380_P2 = 7,
+ BMP380_P3 = 9,
+ BMP380_P4 = 10,
+ BMP380_P5 = 11,
+ BMP380_P6 = 13,
+ BMP380_P7 = 15,
+ BMP380_P8 = 16,
+ BMP380_P9 = 17,
+ BMP380_P10 = 19,
+ BMP380_P11 = 20,
+};
+
static const struct iio_chan_spec bmp280_channels[] = {
{
.type = IIO_PRESSURE,
@@ -721,6 +761,310 @@ static const struct bmp280_chip_info bme280_chip_info = {
.read_calib = bmp280_read_calib,
};
+/* Send a command to BMP3XX sensors */
+static int bmp380_cmd(struct bmp280_data *data, u8 cmd)
+{
+ int ret;
+ unsigned int reg;
+
+ /* check if device is ready to process a command */
+ ret = regmap_read(data->regmap, BMP380_REG_STATUS, ®);
+ if (ret) {
+ dev_err(data->dev, "failed to read error register\n");
+ return ret;
+ }
+ if (!(reg & BMP380_STATUS_CMD_RDY_MASK)) {
+ dev_err(data->dev, "device is not ready to accept commands\n");
+ return -EBUSY;
+ }
+
+ /* send command to process */
+ ret = regmap_write(data->regmap, BMP380_REG_CMD, cmd);
+ if (ret) {
+ dev_err(data->dev, "failed to send command to device\n");
+ return ret;
+ }
+ /* wait for 2ms for command to be processed */
+ usleep_range(data->start_up_time, data->start_up_time + 100);
+ /* check for command processing error */
+ ret = regmap_read(data->regmap, BMP380_REG_ERROR, ®);
+ if (ret) {
+ dev_err(data->dev, "error reading ERROR reg\n");
+ return ret;
+ }
+ if (reg & BMP380_ERR_CMD_MASK) {
+ dev_err(data->dev, "error processing command 0x%X\n", cmd);
+ return -EINVAL;
+ }
+ dev_dbg(data->dev, "Command 0x%X processed successfully\n", cmd);
+
+ return 0;
+}
+
+/*
+ * Returns temperature in DegC, resolution is 0.01 DegC. Output value of
+ * "5123" equals 51.23 DegC. t_fine carries fine temperature as global
+ * value.
+ *
+ * Taken from datasheet, Section Appendix 9, "Compensation formula" and repo
+ * https://github.com/BoschSensortec/BMP3-Sensor-API
+ */
+static s32 bmp380_compensate_temp(struct bmp280_data *data, u32 adc_temp)
+{
+ s64 var1, var2, var3, var4, var5, var6, comp_temp;
+ struct bmp380_calib *calib = &data->calib.bmp380;
+
+ var1 = ((s64) adc_temp) - (((s64) calib->T1) << 8);
+ var2 = var1 * ((s64) calib->T2);
+ var3 = var1 * var1;
+ var4 = var3 * ((s64) calib->T3);
+ var5 = (var2 << 18) + var4;
+ var6 = var5 >> 32;
+ data->t_fine = (s32) var6;
+ comp_temp = (var6 * 25) >> 14;
+
+ comp_temp = clamp_val(comp_temp, BMP380_MIN_TEMP, BMP380_MAX_TEMP);
+ return (s32) comp_temp;
+}
+
+/*
+ * Returns pressure in Pa as unsigned 32 bit integer in fractional Pascal.
+ * Output value of "9528709" represents 9528709/100 = 95287.09 Pa = 952.8709 hPa
+ *
+ * Taken from datasheet, Section 9.3. "Pressure compensation" and repository
+ * https://github.com/BoschSensortec/BMP3-Sensor-API
+ */
+static u32 bmp380_compensate_press(struct bmp280_data *data, u32 adc_press)
+{
+ s64 var1, var2, var3, var4, var5, var6, offset, sensitivity;
+ u64 comp_press;
+ struct bmp380_calib *calib = &data->calib.bmp380;
+
+ var1 = ((s64)data->t_fine) * ((s64)data->t_fine);
+ var2 = var1 >> 6;
+ var3 = (var2 * ((s64) data->t_fine)) >> 8;
+ var4 = (((s64)calib->P8) * var3) >> 5;
+ var5 = (((s64) calib->P7) * var1) << 4;
+ var6 = (((s64) calib->P6) * ((s64)data->t_fine)) << 22;
+ offset = (((s64)calib->P5) << 47) + var4 + var5 + var6;
+ var2 = (((s64)calib->P4) * var3) >> 5;
+ var4 = (((s64) calib->P3) * var1) << 2;
+ var5 = (((s64) calib->P2) - ((s64) 1<<14)) *
+ (((s64)data->t_fine) << 21);
+ sensitivity = ((((s64) calib->P1) - ((s64) 1 << 14)) << 46) +
+ var2 + var4 + var5;
+ var1 = (sensitivity >> 24) * ((s64)adc_press);
+ var2 = ((s64)calib->P10) * ((s64) data->t_fine);
+ var3 = var2 + (((s64) calib->P9) << 16);
+ var4 = (var3 * ((s64)adc_press)) >> 13;
+
+ /*
+ * Dividing by 10 followed by multiplying by 10 to avoid
+ * possible overflow caused by (uncomp_data->pressure * partial_data4)
+ */
+ var5 = (((s64)adc_press) * div_s64(var4, 10)) >> 9;
+ var5 *= 10;
+ var6 = ((s64)adc_press) * ((s64)adc_press);
+ var2 = (((s64)calib->P11) * var6) >> 16;
+ var3 = (var2 * ((s64)adc_press)) >> 7;
+ var4 = (offset >> 2) + var1 + var5 + var3;
+ comp_press = ((u64)var4 * 25) >> 40;
+
+ comp_press = clamp_val(comp_press, BMP380_MIN_PRES, BMP380_MAX_PRES);
+ return (u32)comp_press;
+}
+
+static int bmp380_read_temp(struct bmp280_data *data, int *val)
+{
+ int ret;
+ u32 adc_temp;
+ s32 comp_temp;
+
+ ret = regmap_bulk_read(data->regmap, BMP380_REG_TEMP_XLSB,
+ data->buf.data, sizeof(data->buf.data));
+ if (ret < 0) {
+ dev_err(data->dev, "failed to read temperature\n");
+ return ret;
+ }
+
+ adc_temp = get_unaligned_le24(data->buf.data);
+ if (adc_temp == BMP380_TEMP_SKIPPED) {
+ /* reading was skipped */
+ dev_err(data->dev, "reading temperature skipped\n");
+ return -EIO;
+ }
+ comp_temp = bmp380_compensate_temp(data, adc_temp);
+
+ /*
+ * val might be NULL if we're called by the read_press routine,
+ * who only cares about the carry over t_fine value.
+ */
+ if (val) {
+ /* IIO reports temperatures in mC */
+ *val = comp_temp * 10;
+ return IIO_VAL_INT;
+ }
+
+ return 0;
+}
+
+static int bmp380_read_press(struct bmp280_data *data, int *val, int *val2)
+{
+ int ret;
+ u32 adc_press;
+ s32 comp_press;
+
+ /* Read and compensate for temperature so we get a reading of t_fine */
+ ret = bmp380_read_temp(data, NULL);
+ if (ret < 0)
+ return ret;
+
+ ret = regmap_bulk_read(data->regmap, BMP380_REG_PRESS_XLSB,
+ data->buf.data, sizeof(data->buf.data));
+ if (ret < 0) {
+ dev_err(data->dev, "failed to read pressure\n");
+ return ret;
+ }
+
+ adc_press = get_unaligned_le24(data->buf.data);
+ if (adc_press == BMP380_PRESS_SKIPPED) {
+ /* reading was skipped */
+ dev_err(data->dev, "reading pressure skipped\n");
+ return -EIO;
+ }
+ comp_press = bmp380_compensate_press(data, adc_press);
+
+ *val = comp_press;
+ /* Compensated pressure is in cPa (centipascals) */
+ *val2 = 100000;
+
+ return IIO_VAL_FRACTIONAL;
+}
+
+static int bmp380_read_calib(struct bmp280_data *data, unsigned int chip)
+{
+ struct bmp380_calib *calib = &data->calib.bmp380;
+ int ret;
+
+
+ /* Read temperature calibration values. */
+ ret = regmap_bulk_read(data->regmap, BMP380_REG_CALIB_TEMP_START,
+ data->buf.bmp380_cal, sizeof(data->buf.bmp380_cal));
+ if (ret < 0) {
+ dev_err(data->dev,
+ "failed to read temperature calibration parameters\n");
+ return ret;
+ }
+
+ /* Toss the temperature calibration data into the entropy pool */
+ add_device_randomness(data->buf.bmp380_cal, sizeof(data->buf.bmp380_cal));
+
+ /* Parse calibration data */
+ calib->T1 = get_unaligned_le16(&data->buf.bmp380_cal[BMP380_T1]);
+ calib->T2 = get_unaligned_le16(&data->buf.bmp380_cal[BMP380_T2]);
+ calib->T3 = data->buf.bmp380_cal[BMP380_T3];
+ calib->P1 = get_unaligned_le16(&data->buf.bmp380_cal[BMP380_P1]);
+ calib->P2 = get_unaligned_le16(&data->buf.bmp380_cal[BMP380_P2]);
+ calib->P3 = data->buf.bmp380_cal[BMP380_P3];
+ calib->P4 = data->buf.bmp380_cal[BMP380_P4];
+ calib->P5 = get_unaligned_le16(&data->buf.bmp380_cal[BMP380_P5]);
+ calib->P6 = get_unaligned_le16(&data->buf.bmp380_cal[BMP380_P6]);
+ calib->P7 = data->buf.bmp380_cal[BMP380_P7];
+ calib->P8 = data->buf.bmp380_cal[BMP380_P8];
+ calib->P9 = get_unaligned_le16(&data->buf.bmp380_cal[BMP380_P9]);
+ calib->P10 = data->buf.bmp380_cal[BMP380_P10];
+ calib->P11 = data->buf.bmp380_cal[BMP380_P11];
+
+ return 0;
+}
+
+static int bmp380_chip_config(struct bmp280_data *data)
+{
+ unsigned int tmp;
+ u8 osrs;
+ int ret;
+
+ /* configure power control register */
+ ret = regmap_write_bits(data->regmap, BMP380_REG_POWER_CONTROL,
+ BMP380_CTRL_SENSORS_MASK | BMP380_MODE_MASK,
+ BMP380_CTRL_SENSORS_PRESS_EN |
+ BMP380_CTRL_SENSORS_TEMP_EN |
+ FIELD_PREP(BMP380_MODE_MASK, BMP380_MODE_NORMAL));
+ if (ret < 0) {
+ dev_err(data->dev,
+ "failed to write operation control register\n");
+ return ret;
+ }
+
+ /* configure oversampling */
+ osrs = FIELD_PREP(BMP380_OSRS_TEMP_MASK, data->oversampling_temp) |
+ FIELD_PREP(BMP380_OSRS_PRESS_MASK, data->oversampling_press);
+
+ ret = regmap_write_bits(data->regmap, BMP380_REG_OSR,
+ BMP380_OSRS_TEMP_MASK | BMP380_OSRS_PRESS_MASK,
+ osrs);
+ if (ret < 0) {
+ dev_err(data->dev, "failed to write oversampling register\n");
+ return ret;
+ }
+
+ /* configure output data rate */
+ ret = regmap_write_bits(data->regmap, BMP380_REG_ODR,
+ BMP380_ODRS_MASK, BMP380_ODRS_50HZ);
+ if (ret < 0) {
+ dev_err(data->dev, "failed to write ODR selection register\n");
+ return ret;
+ }
+
+ /* set filter data */
+ ret = regmap_update_bits(data->regmap, BMP380_REG_CONFIG,
+ BMP380_FILTER_MASK,
+ FIELD_PREP(BMP380_FILTER_MASK, BMP380_FILTER_3X));
+ if (ret < 0) {
+ dev_err(data->dev, "failed to write config register\n");
+ return ret;
+ }
+
+ /* wait startup_time before verifying config changes */
+ usleep_range(data->start_up_time, data->start_up_time + 100);
+
+ /* check config error flag */
+ ret = regmap_read(data->regmap, BMP380_REG_ERROR, &tmp);
+ if (ret < 0) {
+ dev_err(data->dev,
+ "failed to read error register\n");
+ return ret;
+ }
+ if (tmp & BMP380_ERR_CONF_MASK) {
+ dev_warn(data->dev,
+ "sensor flagged configuration as incompatible\n");
+ return -EINVAL;
+ }
+
+ return 0;
+}
+
+static const int bmp380_oversampling_avail[] = { 1, 2, 4, 8, 16, 32 };
+
+static const struct bmp280_chip_info bmp380_chip_info = {
+ .id_reg = BMP380_REG_ID,
+ .start_up_time = 2000,
+ .num_channels = 2,
+
+ .oversampling_temp_avail = bmp380_oversampling_avail,
+ .num_oversampling_temp_avail = ARRAY_SIZE(bmp380_oversampling_avail),
+ .oversampling_temp_default = ilog2(1),
+
+ .oversampling_press_avail = bmp380_oversampling_avail,
+ .num_oversampling_press_avail = ARRAY_SIZE(bmp380_oversampling_avail),
+ .oversampling_press_default = ilog2(4),
+
+ .chip_config = bmp380_chip_config,
+ .read_temp = bmp380_read_temp,
+ .read_press = bmp380_read_press,
+ .read_calib = bmp380_read_calib,
+};
+
static int bmp180_measure(struct bmp280_data *data, u8 ctrl_meas)
{
int ret;
@@ -1067,6 +1411,9 @@ int bmp280_common_probe(struct device *dev,
case BME280_CHIP_ID:
chip_info = &bme280_chip_info;
break;
+ case BMP380_CHIP_ID:
+ chip_info = &bmp380_chip_info;
+ break;
default:
return -EINVAL;
}
@@ -1124,6 +1471,13 @@ int bmp280_common_probe(struct device *dev,
return -EINVAL;
}
+ /* BMP3xx requires soft-reset as part of initialization */
+ if (chip_id == BMP380_CHIP_ID) {
+ ret = bmp380_cmd(data, BMP380_CMD_SOFT_RESET);
+ if (ret < 0)
+ return ret;
+ }
+
ret = data->chip_info->chip_config(data);
if (ret < 0)
return ret;
diff --git a/drivers/iio/pressure/bmp280-i2c.c b/drivers/iio/pressure/bmp280-i2c.c
index bf4a7a617537..744442dbe5f9 100644
--- a/drivers/iio/pressure/bmp280-i2c.c
+++ b/drivers/iio/pressure/bmp280-i2c.c
@@ -19,6 +19,9 @@ static int bmp280_i2c_probe(struct i2c_client *client,
case BME280_CHIP_ID:
regmap_config = &bmp280_regmap_config;
break;
+ case BMP380_CHIP_ID:
+ regmap_config = &bmp380_regmap_config;
+ break;
default:
return -EINVAL;
}
@@ -37,6 +40,7 @@ static int bmp280_i2c_probe(struct i2c_client *client,
}
static const struct of_device_id bmp280_of_i2c_match[] = {
+ { .compatible = "bosch,bmp380", .data = (void *)BMP380_CHIP_ID },
{ .compatible = "bosch,bme280", .data = (void *)BME280_CHIP_ID },
{ .compatible = "bosch,bmp280", .data = (void *)BMP280_CHIP_ID },
{ .compatible = "bosch,bmp180", .data = (void *)BMP180_CHIP_ID },
@@ -46,6 +50,7 @@ static const struct of_device_id bmp280_of_i2c_match[] = {
MODULE_DEVICE_TABLE(of, bmp280_of_i2c_match);
static const struct i2c_device_id bmp280_i2c_id[] = {
+ {"bmp380", BMP380_CHIP_ID },
{"bmp280", BMP280_CHIP_ID },
{"bmp180", BMP180_CHIP_ID },
{"bmp085", BMP180_CHIP_ID },
diff --git a/drivers/iio/pressure/bmp280-regmap.c b/drivers/iio/pressure/bmp280-regmap.c
index 969698518984..c98c67970265 100644
--- a/drivers/iio/pressure/bmp280-regmap.c
+++ b/drivers/iio/pressure/bmp280-regmap.c
@@ -72,6 +72,49 @@ static bool bmp280_is_volatile_reg(struct device *dev, unsigned int reg)
}
}
+static bool bmp380_is_writeable_reg(struct device *dev, unsigned int reg)
+{
+ switch (reg) {
+ case BMP380_REG_CMD:
+ case BMP380_REG_CONFIG:
+ case BMP380_REG_FIFO_CONFIG_1:
+ case BMP380_REG_FIFO_CONFIG_2:
+ case BMP380_REG_FIFO_WATERMARK_LSB:
+ case BMP380_REG_FIFO_WATERMARK_MSB:
+ case BMP380_REG_POWER_CONTROL:
+ case BMP380_REG_INT_CONTROL:
+ case BMP380_REG_IF_CONFIG:
+ case BMP380_REG_ODR:
+ case BMP380_REG_OSR:
+ return true;
+ default:
+ return false;
+ }
+}
+
+static bool bmp380_is_volatile_reg(struct device *dev, unsigned int reg)
+{
+ switch (reg) {
+ case BMP380_REG_TEMP_XLSB:
+ case BMP380_REG_TEMP_LSB:
+ case BMP380_REG_TEMP_MSB:
+ case BMP380_REG_PRESS_XLSB:
+ case BMP380_REG_PRESS_LSB:
+ case BMP380_REG_PRESS_MSB:
+ case BMP380_REG_SENSOR_TIME_XLSB:
+ case BMP380_REG_SENSOR_TIME_LSB:
+ case BMP380_REG_SENSOR_TIME_MSB:
+ case BMP380_REG_INT_STATUS:
+ case BMP380_REG_FIFO_DATA:
+ case BMP380_REG_STATUS:
+ case BMP380_REG_ERROR:
+ case BMP380_REG_EVENT:
+ return true;
+ default:
+ return false;
+ }
+}
+
const struct regmap_config bmp280_regmap_config = {
.reg_bits = 8,
.val_bits = 8,
@@ -83,3 +126,15 @@ const struct regmap_config bmp280_regmap_config = {
.volatile_reg = bmp280_is_volatile_reg,
};
EXPORT_SYMBOL_NS(bmp280_regmap_config, IIO_BMP280);
+
+const struct regmap_config bmp380_regmap_config = {
+ .reg_bits = 8,
+ .val_bits = 8,
+
+ .max_register = BMP380_REG_CMD,
+ .cache_type = REGCACHE_RBTREE,
+
+ .writeable_reg = bmp380_is_writeable_reg,
+ .volatile_reg = bmp380_is_volatile_reg,
+};
+EXPORT_SYMBOL_NS(bmp380_regmap_config, IIO_BMP280);
diff --git a/drivers/iio/pressure/bmp280-spi.c b/drivers/iio/pressure/bmp280-spi.c
index 4cfaf3e869b8..011c68e07ebf 100644
--- a/drivers/iio/pressure/bmp280-spi.c
+++ b/drivers/iio/pressure/bmp280-spi.c
@@ -66,6 +66,9 @@ static int bmp280_spi_probe(struct spi_device *spi)
case BME280_CHIP_ID:
regmap_config = &bmp280_regmap_config;
break;
+ case BMP380_CHIP_ID:
+ regmap_config = &bmp380_regmap_config;
+ break;
default:
return -EINVAL;
}
@@ -92,6 +95,7 @@ static const struct of_device_id bmp280_of_spi_match[] = {
{ .compatible = "bosch,bmp181", },
{ .compatible = "bosch,bmp280", },
{ .compatible = "bosch,bme280", },
+ { .compatible = "bosch,bmp380", },
{ },
};
MODULE_DEVICE_TABLE(of, bmp280_of_spi_match);
@@ -101,6 +105,7 @@ static const struct spi_device_id bmp280_spi_id[] = {
{ "bmp181", BMP180_CHIP_ID },
{ "bmp280", BMP280_CHIP_ID },
{ "bme280", BME280_CHIP_ID },
+ { "bmp380", BMP380_CHIP_ID },
{ }
};
MODULE_DEVICE_TABLE(spi, bmp280_spi_id);
diff --git a/drivers/iio/pressure/bmp280.h b/drivers/iio/pressure/bmp280.h
index c036c7835004..827bc6b7ca07 100644
--- a/drivers/iio/pressure/bmp280.h
+++ b/drivers/iio/pressure/bmp280.h
@@ -3,6 +3,105 @@
#include <linux/device.h>
#include <linux/regmap.h>
+/* BMP380 specific registers */
+#define BMP380_REG_CMD 0x7E
+#define BMP380_REG_CONFIG 0x1F
+#define BMP380_REG_ODR 0x1D
+#define BMP380_REG_OSR 0x1C
+#define BMP380_REG_POWER_CONTROL 0x1B
+#define BMP380_REG_IF_CONFIG 0x1A
+#define BMP380_REG_INT_CONTROL 0x19
+#define BMP380_REG_INT_STATUS 0x11
+#define BMP380_REG_EVENT 0x10
+#define BMP380_REG_STATUS 0x03
+#define BMP380_REG_ERROR 0x02
+#define BMP380_REG_ID 0x00
+
+#define BMP380_REG_FIFO_CONFIG_1 0x18
+#define BMP380_REG_FIFO_CONFIG_2 0x17
+#define BMP380_REG_FIFO_WATERMARK_MSB 0x16
+#define BMP380_REG_FIFO_WATERMARK_LSB 0x15
+#define BMP380_REG_FIFO_DATA 0x14
+#define BMP380_REG_FIFO_LENGTH_MSB 0x13
+#define BMP380_REG_FIFO_LENGTH_LSB 0x12
+
+#define BMP380_REG_SENSOR_TIME_MSB 0x0E
+#define BMP380_REG_SENSOR_TIME_LSB 0x0D
+#define BMP380_REG_SENSOR_TIME_XLSB 0x0C
+
+#define BMP380_REG_TEMP_MSB 0x09
+#define BMP380_REG_TEMP_LSB 0x08
+#define BMP380_REG_TEMP_XLSB 0x07
+
+#define BMP380_REG_PRESS_MSB 0x06
+#define BMP380_REG_PRESS_LSB 0x05
+#define BMP380_REG_PRESS_XLSB 0x04
+
+#define BMP380_REG_CALIB_TEMP_START 0x31
+#define BMP380_CALIB_REG_COUNT 21
+
+#define BMP380_FILTER_MASK GENMASK(3, 1)
+#define BMP380_FILTER_OFF 0
+#define BMP380_FILTER_1X 1
+#define BMP380_FILTER_3X 2
+#define BMP380_FILTER_7X 3
+#define BMP380_FILTER_15X 4
+#define BMP380_FILTER_31X 5
+#define BMP380_FILTER_63X 6
+#define BMP380_FILTER_127X 7
+
+#define BMP380_OSRS_TEMP_MASK GENMASK(5, 3)
+#define BMP380_OSRS_PRESS_MASK GENMASK(2, 0)
+
+#define BMP380_ODRS_MASK GENMASK(4, 0)
+#define BMP380_ODRS_200HZ 0x00
+#define BMP380_ODRS_100HZ 0x01
+#define BMP380_ODRS_50HZ 0x02
+#define BMP380_ODRS_25HZ 0x03
+#define BMP380_ODRS_12_5HZ 0x04
+#define BMP380_ODRS_6_25HZ 0x05
+#define BMP380_ODRS_3_1HZ 0x06
+#define BMP380_ODRS_1_5HZ 0x07
+#define BMP380_ODRS_0_78HZ 0x08
+#define BMP380_ODRS_0_39HZ 0x09
+#define BMP380_ODRS_0_2HZ 0x0A
+#define BMP380_ODRS_0_1HZ 0x0B
+#define BMP380_ODRS_0_05HZ 0x0C
+#define BMP380_ODRS_0_02HZ 0x0D
+#define BMP380_ODRS_0_01HZ 0x0E
+#define BMP380_ODRS_0_006HZ 0x0F
+#define BMP380_ODRS_0_003HZ 0x10
+#define BMP380_ODRS_0_0015HZ 0x11
+
+#define BMP380_CTRL_SENSORS_MASK GENMASK(1, 0)
+#define BMP380_CTRL_SENSORS_PRESS_EN BIT(0)
+#define BMP380_CTRL_SENSORS_TEMP_EN BIT(1)
+#define BMP380_MODE_MASK GENMASK(5, 4)
+#define BMP380_MODE_SLEEP 0
+#define BMP380_MODE_FORCED 1
+#define BMP380_MODE_NORMAL 3
+
+#define BMP380_MIN_TEMP -4000
+#define BMP380_MAX_TEMP 8500
+#define BMP380_MIN_PRES 3000000
+#define BMP380_MAX_PRES 12500000
+
+#define BMP380_CMD_NOOP 0x00
+#define BMP380_CMD_EXTMODE_EN_MID 0x34
+#define BMP380_CMD_FIFO_FLUSH 0xB0
+#define BMP380_CMD_SOFT_RESET 0xB6
+
+#define BMP380_STATUS_CMD_RDY_MASK BIT(4)
+#define BMP380_STATUS_DRDY_PRESS_MASK BIT(5)
+#define BMP380_STATUS_DRDY_TEMP_MASK BIT(6)
+
+#define BMP380_ERR_FATAL_MASK BIT(0)
+#define BMP380_ERR_CMD_MASK BIT(1)
+#define BMP380_ERR_CONF_MASK BIT(2)
+
+#define BMP380_TEMP_SKIPPED 0x800000
+#define BMP380_PRESS_SKIPPED 0x800000
+
/* BMP280 specific registers */
#define BMP280_REG_HUMIDITY_LSB 0xFE
#define BMP280_REG_HUMIDITY_MSB 0xFD
@@ -94,6 +193,7 @@
#define BMP280_REG_RESET 0xE0
#define BMP280_REG_ID 0xD0
+#define BMP380_CHIP_ID 0x50
#define BMP180_CHIP_ID 0x55
#define BMP280_CHIP_ID 0x58
#define BME280_CHIP_ID 0x60
@@ -107,6 +207,7 @@
/* Regmap configurations */
extern const struct regmap_config bmp180_regmap_config;
extern const struct regmap_config bmp280_regmap_config;
+extern const struct regmap_config bmp380_regmap_config;
/* Probe called from different transports */
int bmp280_common_probe(struct device *dev,
--
2.37.1
On Sun, Aug 7, 2022 at 1:56 PM Angel Iglesias <[email protected]> wrote:
>
> Adds compatibility with the new generation of this sensor, the BMP380
>
> Includes basic sensor initialization to do pressure and temp
> measurements and allows tuning oversampling settings for each channel.
>
> The compensation algorithms are adapted from the device datasheet and
> the repository https://github.com/BoschSensortec/BMP3-Sensor-API
Missed period.
...
> * https://ae-bst.resource.bosch.com/media/_tech/media/datasheets/BST-BMP180-DS000-121.pdf
> * https://ae-bst.resource.bosch.com/media/_tech/media/datasheets/BST-BMP280-DS001-12.pdf
> * https://ae-bst.resource.bosch.com/media/_tech/media/datasheets/BST-BME280_DS001-11.pdf
Seems like the above links are unresponsive now? Perhaps you may fix
them as well in a separate patch?
> + * https://www.bosch-sensortec.com/media/boschsensortec/downloads/datasheets/bst-bmp388-ds001.pdf
...
> +/* See datasheet Section 3.11.1. */
Again, a bit of consistency in (one-line) comments, please.
> +struct bmp380_calib {
> + u16 T1;
> + u16 T2;
> + s8 T3;
> + s16 P1;
> + s16 P2;
> + s8 P3;
> + s8 P4;
> + u16 P5;
> + u16 P6;
> + s8 P7;
> + s8 P8;
> + s16 P9;
> + s8 P10;
> + s8 P11;
> +};
__packed ?
...
> +/* Send a command to BMP3XX sensors */
> + /* check if device is ready to process a command */
> + /* send command to process */
> + /* wait for 2ms for command to be processed */
> + /* check for command processing error */
Consistency, please!
...
> + dev_dbg(data->dev, "Command 0x%X processed successfully\n", cmd);
Useless.
...
> +/*
> + * Returns temperature in DegC, resolution is 0.01 DegC. Output value of
DegC?! Perhaps "Celsius degrees"?
> + * "5123" equals 51.23 DegC. t_fine carries fine temperature as global
> + * value.
> + *
> + * Taken from datasheet, Section Appendix 9, "Compensation formula" and repo
> + * https://github.com/BoschSensortec/BMP3-Sensor-API
Missed period.
> + */
...
> + return (s32) comp_temp;
Do you need casting?
...
> +/*
> + * Returns pressure in Pa as unsigned 32 bit integer in fractional Pascal.
an unsigned
32-bit
> + * Output value of "9528709" represents 9528709/100 = 95287.09 Pa = 952.8709 hPa
> + *
> + * Taken from datasheet, Section 9.3. "Pressure compensation" and repository
> + * https://github.com/BoschSensortec/BMP3-Sensor-API
Missed period.
> + */
...
> + var1 = ((s64)data->t_fine) * ((s64)data->t_fine);
Too many parentheses?
...
> + /*
> + * Dividing by 10 followed by multiplying by 10 to avoid
> + * possible overflow caused by (uncomp_data->pressure * partial_data4)
Missed period.
> + */
...
> + return (u32)comp_press;
Do you need casting?
...
> + /* reading was skipped */
The useless comment.
> + dev_err(data->dev, "reading pressure skipped\n");
...
> + /* Compensated pressure is in cPa (centipascals) */
> + *val2 = 100000;
Anything to use from units.h?
...
> + ret = regmap_write_bits(data->regmap, BMP380_REG_OSR,
> + BMP380_OSRS_TEMP_MASK | BMP380_OSRS_PRESS_MASK,
> + osrs);
> + if (ret < 0) {
Do all these ' < 0' parts make any sense?
> + }
...
> + { .compatible = "bosch,bmp380", .data = (void *)BMP380_CHIP_ID },
> { .compatible = "bosch,bme280", .data = (void *)BME280_CHIP_ID },
> { .compatible = "bosch,bmp280", .data = (void *)BMP280_CHIP_ID },
> { .compatible = "bosch,bmp180", .data = (void *)BMP180_CHIP_ID },
See below.
...
> + {"bmp380", BMP380_CHIP_ID },
> {"bmp280", BMP280_CHIP_ID },
> {"bmp180", BMP180_CHIP_ID },
> {"bmp085", BMP180_CHIP_ID },
Can we actually keep them forward-ordered? (Add 380 after 280 here and
in a separate patch sort the rest, or other way around, sort as a
prerequisite patch)
...
> +#define BMP380_MIN_TEMP -4000
> +#define BMP380_MAX_TEMP 8500
> +#define BMP380_MIN_PRES 3000000
> +#define BMP380_MAX_PRES 12500000
Units?
--
With Best Regards,
Andy Shevchenko
On lun, 2022-08-08 at 11:08 +0200, Andy Shevchenko wrote:
> On Sun, Aug 7, 2022 at 1:56 PM Angel Iglesias <[email protected]> wrote:
> >
> > Adds compatibility with the new generation of this sensor, the BMP380
> >
> > Includes basic sensor initialization to do pressure and temp
> > measurements and allows tuning oversampling settings for each channel.
> >
> > The compensation algorithms are adapted from the device datasheet and
> > the repository https://github.com/BoschSensortec/BMP3-Sensor-API
>
> Missed period.
>
> ...
>
> > *
> > https://ae-bst.resource.bosch.com/media/_tech/media/datasheets/BST-BMP180-DS000-121.pdf
> > *
> > https://ae-bst.resource.bosch.com/media/_tech/media/datasheets/BST-BMP280-DS001-12.pdf
> > *
> > https://ae-bst.resource.bosch.com/media/_tech/media/datasheets/BST-BME280_DS001-11.pdf
>
> Seems like the above links are unresponsive now? Perhaps you may fix
> them as well in a separate patch?
Sure. Should I include this patch in this next version of this series, or should
I send the patch as a standalone change?
> > + *
> > https://www.bosch-sensortec.com/media/boschsensortec/downloads/datasheets/bst-bmp388-ds001.pdf
>
> ...
>
> > +/* See datasheet Section 3.11.1. */
>
> Again, a bit of consistency in (one-line) comments, please.
>
> > +struct bmp380_calib {
> > + u16 T1;
> > + u16 T2;
> > + s8 T3;
> > + s16 P1;
> > + s16 P2;
> > + s8 P3;
> > + s8 P4;
> > + u16 P5;
> > + u16 P6;
> > + s8 P7;
> > + s8 P8;
> > + s16 P9;
> > + s8 P10;
> > + s8 P11;
> > +};
>
> __packed ?
>
> ...
>
> > +/* Send a command to BMP3XX sensors */
>
> > + /* check if device is ready to process a command */
> > + /* send command to process */
> > + /* wait for 2ms for command to be processed */
> > + /* check for command processing error */
>
> Consistency, please!
>
> ...
>
> > + dev_dbg(data->dev, "Command 0x%X processed successfully\n", cmd);
>
> Useless.
>
> ...
>
> > +/*
> > + * Returns temperature in DegC, resolution is 0.01 DegC. Output value of
>
> DegC?! Perhaps "Celsius degrees"?
>
> > + * "5123" equals 51.23 DegC. t_fine carries fine temperature as global
> > + * value.
> > + *
> > + * Taken from datasheet, Section Appendix 9, "Compensation formula" and
> > repo
> > + * https://github.com/BoschSensortec/BMP3-Sensor-API
>
> Missed period.
>
> > + */
>
> ...
>
> > + return (s32) comp_temp;
>
> Do you need casting?
>
> ...
>
> > +/*
> > + * Returns pressure in Pa as unsigned 32 bit integer in fractional Pascal.
>
> an unsigned
> 32-bit
>
> > + * Output value of "9528709" represents 9528709/100 = 95287.09 Pa =
> > 952.8709 hPa
> > + *
> > + * Taken from datasheet, Section 9.3. "Pressure compensation" and
> > repository
> > + * https://github.com/BoschSensortec/BMP3-Sensor-API
>
> Missed period.
>
> > + */
>
> ...
>
> > + var1 = ((s64)data->t_fine) * ((s64)data->t_fine);
>
> Too many parentheses?
Yup, operator precedence of typecast precedes multiplication.
> ...
>
> > + /*
> > + * Dividing by 10 followed by multiplying by 10 to avoid
> > + * possible overflow caused by (uncomp_data->pressure *
> > partial_data4)
>
> Missed period.
>
> > + */
>
> ...
>
> > + return (u32)comp_press;
>
> Do you need casting?
Not really, should fall on the implicit conversion rules of the compiler as it
works like an assignment, right?. Also, after shifting 40 bits to the right,
there's no risk of overflow, comp_press can be a u32 from the start instead of a
u64.
> ...
>
> > + /* reading was skipped */
>
> The useless comment.
>
> > + dev_err(data->dev, "reading pressure skipped\n");
>
> ...
>
> > + /* Compensated pressure is in cPa (centipascals) */
> > + *val2 = 100000;
>
> Anything to use from units.h?
>
> ...
>
> > + ret = regmap_write_bits(data->regmap, BMP380_REG_OSR,
> > + BMP380_OSRS_TEMP_MASK |
> > BMP380_OSRS_PRESS_MASK,
> > + osrs);
> > + if (ret < 0) {
>
> Do all these ' < 0' parts make any sense?
I've checked regmap calls and return 0 when call is successful, so the answer is
no
> > + }
>
> ...
>
> > + { .compatible = "bosch,bmp380", .data = (void *)BMP380_CHIP_ID },
> > { .compatible = "bosch,bme280", .data = (void *)BME280_CHIP_ID },
> > { .compatible = "bosch,bmp280", .data = (void *)BMP280_CHIP_ID },
> > { .compatible = "bosch,bmp180", .data = (void *)BMP180_CHIP_ID },
>
> See below.
>
> ...
>
> > + {"bmp380", BMP380_CHIP_ID },
> > {"bmp280", BMP280_CHIP_ID },
> > {"bmp180", BMP180_CHIP_ID },
> > {"bmp085", BMP180_CHIP_ID },
>
> Can we actually keep them forward-ordered? (Add 380 after 280 here and
> in a separate patch sort the rest, or other way around, sort as a
> prerequisite patch)
Sure!
> ...
>
> > +#define BMP380_MIN_TEMP -4000
> > +#define BMP380_MAX_TEMP 8500
> > +#define BMP380_MIN_PRES 3000000
> > +#define BMP380_MAX_PRES 12500000
>
> Units?
Units as in I should use units.h constants or also comment in which units are
these constants?
>
> --
> With Best Regards,
> Andy Shevchenko
Kind regards,
Angel
On Sun, 7 Aug 2022 13:55:52 +0200
Angel Iglesias <[email protected]> wrote:
> Adds compatibility with the new generation of this sensor, the BMP380
>
> Includes basic sensor initialization to do pressure and temp
> measurements and allows tuning oversampling settings for each channel.
>
> The compensation algorithms are adapted from the device datasheet and
> the repository https://github.com/BoschSensortec/BMP3-Sensor-API
>
> Signed-off-by: Angel Iglesias <[email protected]>
One additional comment from me inline.
Thanks,
Jonathan
> }
> @@ -1124,6 +1471,13 @@ int bmp280_common_probe(struct device *dev,
> return -EINVAL;
> }
>
> + /* BMP3xx requires soft-reset as part of initialization */
> + if (chip_id == BMP380_CHIP_ID) {
I'd prefer this to be based on a flag in chip_info so that we can
trivially add it to future devices by just setting that flag for the
chip_info added for the new device.
> + ret = bmp380_cmd(data, BMP380_CMD_SOFT_RESET);
> + if (ret < 0)
> + return ret;
> + }
> +
> ret = data->chip_info->chip_config(data);
> if (ret < 0)
> return ret;
On Fri, 12 Aug 2022 12:47:20 +0200
Angel Iglesias <[email protected]> wrote:
> On lun, 2022-08-08 at 11:08 +0200, Andy Shevchenko wrote:
> > On Sun, Aug 7, 2022 at 1:56 PM Angel Iglesias <[email protected]> wrote:
> > >
> > > Adds compatibility with the new generation of this sensor, the BMP380
> > >
> > > Includes basic sensor initialization to do pressure and temp
> > > measurements and allows tuning oversampling settings for each channel.
> > >
> > > The compensation algorithms are adapted from the device datasheet and
> > > the repository https://github.com/BoschSensortec/BMP3-Sensor-API
> >
> > Missed period.
> >
> > ...
> >
> > > *
> > > https://ae-bst.resource.bosch.com/media/_tech/media/datasheets/BST-BMP180-DS000-121.pdf
> > > *
> > > https://ae-bst.resource.bosch.com/media/_tech/media/datasheets/BST-BMP280-DS001-12.pdf
> > > *
> > > https://ae-bst.resource.bosch.com/media/_tech/media/datasheets/BST-BME280_DS001-11.pdf
> >
> > Seems like the above links are unresponsive now? Perhaps you may fix
> > them as well in a separate patch?
>
> Sure. Should I include this patch in this next version of this series, or should
> I send the patch as a standalone change?
Either way is fine. Thanks for tidying this up!
>
> > > + *
> > > https://www.bosch-sensortec.com/media/boschsensortec/downloads/datasheets/bst-bmp388-ds001.pdf
> >
> > ...
> >
> > > +/* See datasheet Section 3.11.1. */
> >
> > Again, a bit of consistency in (one-line) comments, please.
> >
> > > +struct bmp380_calib {
> > > + u16 T1;
> > > + u16 T2;
> > > + s8 T3;
> > > + s16 P1;
> > > + s16 P2;
> > > + s8 P3;
> > > + s8 P4;
> > > + u16 P5;
> > > + u16 P6;
> > > + s8 P7;
> > > + s8 P8;
> > > + s16 P9;
> > > + s8 P10;
> > > + s8 P11;
> > > +};
> >
> > __packed ?
Nope - the unpacking is done on filling this array.
Could reorder to reduce size a little but given the naming vs datasheet
that would look very odd. I'd leave this as it is.
> >
> > > + /* Compensated pressure is in cPa (centipascals) */
> > > + *val2 = 100000;
> >
> > Anything to use from units.h?
Not sure we want to add centi to killo conversion!
That combination is rather rare.
Jonathan
On Sun, 2022-08-14 at 15:15 +0100, Jonathan Cameron wrote:
> On Sun, 7 Aug 2022 13:55:52 +0200
> Angel Iglesias <[email protected]> wrote:
>
> > Adds compatibility with the new generation of this sensor, the BMP380
> >
> > Includes basic sensor initialization to do pressure and temp
> > measurements and allows tuning oversampling settings for each channel.
> >
> > The compensation algorithms are adapted from the device datasheet and
> > the repository https://github.com/BoschSensortec/BMP3-Sensor-API
> >
> > Signed-off-by: Angel Iglesias <[email protected]>
>
> One additional comment from me inline.
>
> Thanks,
>
> Jonathan
>
>
> > }
> > @@ -1124,6 +1471,13 @@ int bmp280_common_probe(struct device *dev,
> > return -EINVAL;
> > }
> >
> > + /* BMP3xx requires soft-reset as part of initialization */
> > + if (chip_id == BMP380_CHIP_ID) {
>
> I'd prefer this to be based on a flag in chip_info so that we can
> trivially add it to future devices by just setting that flag for the
> chip_info added for the new device.
How a new init or preinit callback? For now only BMP380 chip would use it, but I
would like to get my hands on a BMP390 and the new BMP580 and extend the driver
to support for them.
> > + ret = bmp380_cmd(data, BMP380_CMD_SOFT_RESET);
> > + if (ret < 0)
> > + return ret;
> > + }
> > +
> > ret = data->chip_info->chip_config(data);
> > if (ret < 0)
> > return ret;
>
Kind regards,
Angel
On Sun, 14 Aug 2022 16:37:58 +0200
Angel Iglesias <[email protected]> wrote:
> On Sun, 2022-08-14 at 15:15 +0100, Jonathan Cameron wrote:
> > On Sun, 7 Aug 2022 13:55:52 +0200
> > Angel Iglesias <[email protected]> wrote:
> >
> > > Adds compatibility with the new generation of this sensor, the BMP380
> > >
> > > Includes basic sensor initialization to do pressure and temp
> > > measurements and allows tuning oversampling settings for each channel.
> > >
> > > The compensation algorithms are adapted from the device datasheet and
> > > the repository https://github.com/BoschSensortec/BMP3-Sensor-API
> > >
> > > Signed-off-by: Angel Iglesias <[email protected]>
> >
> > One additional comment from me inline.
> >
> > Thanks,
> >
> > Jonathan
> >
> >
> > > }
> > > @@ -1124,6 +1471,13 @@ int bmp280_common_probe(struct device *dev,
> > > return -EINVAL;
> > > }
> > >
> > > + /* BMP3xx requires soft-reset as part of initialization */
> > > + if (chip_id == BMP380_CHIP_ID) {
> >
> > I'd prefer this to be based on a flag in chip_info so that we can
> > trivially add it to future devices by just setting that flag for the
> > chip_info added for the new device.
>
> How a new init or preinit callback? For now only BMP380 chip would use it, but I
> would like to get my hands on a BMP390 and the new BMP580 and extend the driver
> to support for them.
Hmm. Good point, I'd failed to noticed the register is bmp380 specific currently.
Maybe one to leave for a future refactor if you get those newer parts.
Jonathan
>
> > > + ret = bmp380_cmd(data, BMP380_CMD_SOFT_RESET);
> > > + if (ret < 0)
> > > + return ret;
> > > + }
> > > +
> > > ret = data->chip_info->chip_config(data);
> > > if (ret < 0)
> > > return ret;
> >
>
> Kind regards,
> Angel