2021-04-13 12:44:52

by zhuguangqing83

Subject: [PATCH] irq: Fix missing IRQF_ONESHOT as only threaded handler

From: Guangqing Zhu <[email protected]>

Coccinelle noticed:
kernel/irq/manage.c:2199:8-28: ERROR: Threaded IRQ with no primary
handler requested without IRQF_ONESHOT.

Signed-off-by: Guangqing Zhu <[email protected]>
---
kernel/irq/manage.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/kernel/irq/manage.c b/kernel/irq/manage.c
index 4c14356543d9..222816750048 100644
--- a/kernel/irq/manage.c
+++ b/kernel/irq/manage.c
@@ -2197,7 +2197,7 @@ int request_any_context_irq(unsigned int irq, irq_handler_t handler,

if (irq_settings_is_nested_thread(desc)) {
ret = request_threaded_irq(irq, NULL, handler,
- flags, name, dev_id);
+ flags | IRQF_ONESHOT, name, dev_id);
return !ret ? IRQC_IS_NESTED : ret;
}

--
2.17.1

2021-04-16 10:03:03

by Krzysztof Kozlowski

Subject: Re: [PATCH] irq: Fix missing IRQF_ONESHOT as only threaded handler

On Tue, 13 Apr 2021 at 15:42, <[email protected]> wrote:
>
> From: Guangqing Zhu <[email protected]>
>
> Coccinelle noticed:
> kernel/irq/manage.c:2199:8-28: ERROR: Threaded IRQ with no primary
> handler requested without IRQF_ONESHOT.
>
> Signed-off-by: Guangqing Zhu <[email protected]>
> ---
> kernel/irq/manage.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/kernel/irq/manage.c b/kernel/irq/manage.c
> index 4c14356543d9..222816750048 100644
> --- a/kernel/irq/manage.c
> +++ b/kernel/irq/manage.c
> @@ -2197,7 +2197,7 @@ int request_any_context_irq(unsigned int irq, irq_handler_t handler,
>
> if (irq_settings_is_nested_thread(desc)) {
> ret = request_threaded_irq(irq, NULL, handler,
> - flags, name, dev_id);
> + flags | IRQF_ONESHOT, name, dev_id);

This is a core IRQ code... and you clearly see here a nested IRQ.
Please, stop sending automated coccinelle patches.

Best regards,
Krzysztof