2021-02-17 22:32:46

by Colin King

Subject: [PATCH] drivers/base/cpu: remove redundant initialization of variable retval

From: Colin Ian King <[email protected]>

The variable retval is being initialized with a value that is never read
and it is being updated later with a new value. The initialization is
redundant and can be removed.

Addresses-Coverity: ("Unused value")
Signed-off-by: Colin Ian King <[email protected]>
---
drivers/base/cpu.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/drivers/base/cpu.c b/drivers/base/cpu.c
index 8f1d6569564c..2e834cd315d8 100644
--- a/drivers/base/cpu.c
+++ b/drivers/base/cpu.c
@@ -409,7 +409,7 @@ __cpu_device_create(struct device *parent, void *drvdata,
const char *fmt, va_list args)
{
struct device *dev = NULL;
- int retval = -ENODEV;
+ int retval;

dev = kzalloc(sizeof(*dev), GFP_KERNEL);
if (!dev) {
--
2.30.0

2021-02-18 19:04:07

by Rafael J. Wysocki

Subject: Re: [PATCH] drivers/base/cpu: remove redundant initialization of variable retval

On Wed, Feb 17, 2021 at 8:51 PM Colin King <[email protected]> wrote:
>
> From: Colin Ian King <[email protected]>
>
> The variable retval is being initialized with a value that is never read
> and it is being updated later with a new value. The initialization is
> redundant and can be removed.
>
> Addresses-Coverity: ("Unused value")
> Signed-off-by: Colin Ian King <[email protected]>
> ---
> drivers/base/cpu.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/drivers/base/cpu.c b/drivers/base/cpu.c
> index 8f1d6569564c..2e834cd315d8 100644
> --- a/drivers/base/cpu.c
> +++ b/drivers/base/cpu.c
> @@ -409,7 +409,7 @@ __cpu_device_create(struct device *parent, void *drvdata,
> const char *fmt, va_list args)
> {
> struct device *dev = NULL;
> - int retval = -ENODEV;

Might as well init it to -ENOMEM and drop the assignment below.

> + int retval;
>
> dev = kzalloc(sizeof(*dev), GFP_KERNEL);
> if (!dev) {
> --