2022-09-06 20:41:32

by Doug Smythies

Subject: [PATCH] cpufreq: intel_pstate: Add Tigerlake support in no-HWP mode

Users may disable HWP in firmware, in which case intel_pstate wouldn't load
unless the CPU model is explicitly supported.

Add TIGERLAKE to the list of CPUs that can register intel_pstate while not
advertising the HWP capability. Without this change, an TIGERLAKE in no-HWP
mode could only use the acpi_cpufreq frequency scaling driver.

See also commits:
d8de7a44e11f: cpufreq: intel_pstate: Add Skylake servers support
fbdc21e9b038: cpufreq: intel_pstate: Add Icelake servers support in no-HWP mode
706c5328851d: cpufreq: intel_pstate: Add Cometlake support in no-HWP mode

Reported by: M. Cargi Ari <[email protected]>
Signed-off-by: Doug Smythies <[email protected]>
---
drivers/cpufreq/intel_pstate.c | 1 +
1 file changed, 1 insertion(+)

diff --git a/drivers/cpufreq/intel_pstate.c b/drivers/cpufreq/intel_pstate.c
index 57cdb3679885..fc3ebeb0bbe5 100644
--- a/drivers/cpufreq/intel_pstate.c
+++ b/drivers/cpufreq/intel_pstate.c
@@ -2416,6 +2416,7 @@ static const struct x86_cpu_id intel_pstate_cpu_ids[] = {
X86_MATCH(SKYLAKE_X, core_funcs),
X86_MATCH(COMETLAKE, core_funcs),
X86_MATCH(ICELAKE_X, core_funcs),
+ X86_MATCH(TIGERLAKE, core_funcs),
{}
};
MODULE_DEVICE_TABLE(x86cpu, intel_pstate_cpu_ids);
--
2.25.1

2022-09-10 17:04:18

by Rafael J. Wysocki

Subject: Re: [PATCH] cpufreq: intel_pstate: Add Tigerlake support in no-HWP mode

On Tue, Sep 6, 2022 at 10:29 PM Doug Smythies <[email protected]> wrote:
>
> Users may disable HWP in firmware, in which case intel_pstate wouldn't load
> unless the CPU model is explicitly supported.
>
> Add TIGERLAKE to the list of CPUs that can register intel_pstate while not
> advertising the HWP capability. Without this change, an TIGERLAKE in no-HWP
> mode could only use the acpi_cpufreq frequency scaling driver.
>
> See also commits:
> d8de7a44e11f: cpufreq: intel_pstate: Add Skylake servers support
> fbdc21e9b038: cpufreq: intel_pstate: Add Icelake servers support in no-HWP mode
> 706c5328851d: cpufreq: intel_pstate: Add Cometlake support in no-HWP mode
>
> Reported by: M. Cargi Ari <[email protected]>
> Signed-off-by: Doug Smythies <[email protected]>
> ---
> drivers/cpufreq/intel_pstate.c | 1 +
> 1 file changed, 1 insertion(+)
>
> diff --git a/drivers/cpufreq/intel_pstate.c b/drivers/cpufreq/intel_pstate.c
> index 57cdb3679885..fc3ebeb0bbe5 100644
> --- a/drivers/cpufreq/intel_pstate.c
> +++ b/drivers/cpufreq/intel_pstate.c
> @@ -2416,6 +2416,7 @@ static const struct x86_cpu_id intel_pstate_cpu_ids[] = {
> X86_MATCH(SKYLAKE_X, core_funcs),
> X86_MATCH(COMETLAKE, core_funcs),
> X86_MATCH(ICELAKE_X, core_funcs),
> + X86_MATCH(TIGERLAKE, core_funcs),
> {}
> };
> MODULE_DEVICE_TABLE(x86cpu, intel_pstate_cpu_ids);
> --

Applied as 6.1 material, thanks!