2023-03-28 01:59:51

by Jiangshan Yi

Subject: [PATCH] drivers/acpi/acpica/exserial.c: replace ternary operator with min()

Fix the following coccicheck warning:

drivers/acpi/acpica/exserial.c:346: WARNING opportunity for min().

min() macro is defined in include/linux/minmax.h. It avoids
multiple evaluations of the arguments when non-constant and performs
strict type-checking.

Signed-off-by: Jiangshan Yi <[email protected]>
---
drivers/acpi/acpica/exserial.c | 3 +--
1 file changed, 1 insertion(+), 2 deletions(-)

diff --git a/drivers/acpi/acpica/exserial.c b/drivers/acpi/acpica/exserial.c
index fd63f2042514..dfe507e0a09a 100644
--- a/drivers/acpi/acpica/exserial.c
+++ b/drivers/acpi/acpica/exserial.c
@@ -343,8 +343,7 @@ acpi_ex_write_serial_bus(union acpi_operand_object *source_desc,
/* Copy the input buffer data to the transfer buffer */

buffer = buffer_desc->buffer.pointer;
- data_length = (buffer_length < source_desc->buffer.length ?
- buffer_length : source_desc->buffer.length);
+ data_length = min(buffer_length, source_desc->buffer.length);
memcpy(buffer, source_desc->buffer.pointer, data_length);

/* Lock entire transaction if requested */
--
2.27.0

2023-03-28 15:32:37

by Rafael J. Wysocki

Subject: Re: [PATCH] drivers/acpi/acpica/exserial.c: replace ternary operator with min()

On Tue, Mar 28, 2023 at 3:52 AM Jiangshan Yi <[email protected]> wrote:
>
> Fix the following coccicheck warning:
>
> drivers/acpi/acpica/exserial.c:346: WARNING opportunity for min().
>
> min() macro is defined in include/linux/minmax.h. It avoids
> multiple evaluations of the arguments when non-constant and performs
> strict type-checking.
>
> Signed-off-by: Jiangshan Yi <[email protected]>

ACPICA changes need to be submitted as pull requests to the upstream
project on GitHub. When that happens, a Linux patch based on an
upstream ACPICA PR can be submitted with a Link: tag pointing to that
PR.

Thanks!

> ---
> drivers/acpi/acpica/exserial.c | 3 +--
> 1 file changed, 1 insertion(+), 2 deletions(-)
>
> diff --git a/drivers/acpi/acpica/exserial.c b/drivers/acpi/acpica/exserial.c
> index fd63f2042514..dfe507e0a09a 100644
> --- a/drivers/acpi/acpica/exserial.c
> +++ b/drivers/acpi/acpica/exserial.c
> @@ -343,8 +343,7 @@ acpi_ex_write_serial_bus(union acpi_operand_object *source_desc,
> /* Copy the input buffer data to the transfer buffer */
>
> buffer = buffer_desc->buffer.pointer;
> - data_length = (buffer_length < source_desc->buffer.length ?
> - buffer_length : source_desc->buffer.length);
> + data_length = min(buffer_length, source_desc->buffer.length);
> memcpy(buffer, source_desc->buffer.pointer, data_length);
>
> /* Lock entire transaction if requested */
> --
> 2.27.0
>