2013-04-16 17:30:21

by Suman Anna

Subject: [PATCH 2/2] rpmsg: fix kconfig dependencies for VIRTIO

rpmsg configuration selects VIRTIO, but VIRTIO is now
subordinate to VIRTUALIZATION. RPMSG is currently selected
by OMAP_REMOTEPROC, and the dependency warning is not seen
with the fix in remoteproc config, but the kconfig menu
hierarchy dependency has to be honored nevertheless.

warning: (VIRTIO_PCI && VIRTIO_MMIO && REMOTEPROC && RPMSG) selects VIRTIO which has unmet direct dependencies (VIRTUALIZATION)
warning: (VIRTIO_PCI && VIRTIO_MMIO && REMOTEPROC && RPMSG) selects VIRTIO which has unmet direct dependencies (VIRTUALIZATION)

Signed-off-by: Suman Anna <[email protected]>
---
drivers/rpmsg/Kconfig | 1 +
1 file changed, 1 insertion(+)

diff --git a/drivers/rpmsg/Kconfig b/drivers/rpmsg/Kconfig
index f6e0ea6..370645c 100644
--- a/drivers/rpmsg/Kconfig
+++ b/drivers/rpmsg/Kconfig
@@ -3,6 +3,7 @@ menu "Rpmsg drivers"
# RPMSG always gets selected by whoever wants it
config RPMSG
tristate
+ select VIRTUALIZATION
select VIRTIO

endmenu
--
1.8.2

2013-04-21 13:56:37

by Ohad Ben Cohen

Subject: Re: [PATCH 2/2] rpmsg: fix kconfig dependencies for VIRTIO

On Tue, Apr 16, 2013 at 8:25 PM, Suman Anna <[email protected]> wrote:
> rpmsg configuration selects VIRTIO, but VIRTIO is now
> subordinate to VIRTUALIZATION. RPMSG is currently selected
> by OMAP_REMOTEPROC, and the dependency warning is not seen
> with the fix in remoteproc config, but the kconfig menu
> hierarchy dependency has to be honored nevertheless.
>
> warning: (VIRTIO_PCI && VIRTIO_MMIO && REMOTEPROC && RPMSG) selects VIRTIO which has unmet direct dependencies (VIRTUALIZATION)
> warning: (VIRTIO_PCI && VIRTIO_MMIO && REMOTEPROC && RPMSG) selects VIRTIO which has unmet direct dependencies (VIRTUALIZATION)
>
> Signed-off-by: Suman Anna <[email protected]>

Applied, thanks!