2022-06-02 01:51:35

by Keith Busch

Subject: [PATCH] kbuild: show the install image name and path

From: Keith Busch <[email protected]>

Prior to commit f774f5bb87d13 ("kbuild: factor out the common
installation code into"), a 'make install' would print out the install
command like:

sh ./arch/x86/boot/install.sh 5.18.0-11935-gbffe08031c89 \
arch/x86/boot/bzImage System.map "/boot"

This output was very useful for my workflow, so this patch prints it out
again. I'm not sure if there's a better way to do this than what's
implemented here, so any feedback is appreciated.

Cc: Masahiro Yamada <[email protected]>
Signed-off-by: Keith Busch <[email protected]>
---
scripts/install.sh | 1 +
1 file changed, 1 insertion(+)

diff --git a/scripts/install.sh b/scripts/install.sh
index 9bb0fb44f04a..2989d25ef069 100755
--- a/scripts/install.sh
+++ b/scripts/install.sh
@@ -33,6 +33,7 @@ do
# installkernel(8) says the parameters are like follows:
#
# installkernel version zImage System.map [directory]
+ echo "$0 ${KERNELRELEASE} ${KBUILD_IMAGE} ${INSTALL_PATH}"
exec "${file}" "${KERNELRELEASE}" "${KBUILD_IMAGE}" System.map "${INSTALL_PATH}"
done

--
2.30.2

2022-06-03 17:12:10

by Masahiro Yamada

Subject: Re: [PATCH] kbuild: show the install image name and path

On Thu, Jun 2, 2022 at 10:51 AM Keith Busch <[email protected]> wrote:
>
> From: Keith Busch <[email protected]>
>
> Prior to commit f774f5bb87d13 ("kbuild: factor out the common
> installation code into"), a 'make install' would print out the install
> command like:
>
> sh ./arch/x86/boot/install.sh 5.18.0-11935-gbffe08031c89 \
> arch/x86/boot/bzImage System.map "/boot"
>
> This output was very useful for my workflow, so this patch prints it out
> again. I'm not sure if there's a better way to do this than what's
> implemented here, so any feedback is appreciated.
>
> Cc: Masahiro Yamada <[email protected]>
> Signed-off-by: Keith Busch <[email protected]>
> ---
> scripts/install.sh | 1 +
> 1 file changed, 1 insertion(+)
>
> diff --git a/scripts/install.sh b/scripts/install.sh
> index 9bb0fb44f04a..2989d25ef069 100755
> --- a/scripts/install.sh
> +++ b/scripts/install.sh
> @@ -33,6 +33,7 @@ do
> # installkernel(8) says the parameters are like follows:
> #
> # installkernel version zImage System.map [directory]
> + echo "$0 ${KERNELRELEASE} ${KBUILD_IMAGE} ${INSTALL_PATH}"
> exec "${file}" "${KERNELRELEASE}" "${KBUILD_IMAGE}" System.map "${INSTALL_PATH}"
> done
>
> --
> 2.30.2
>

You said "useful for *my* flow",
so you can do whatever you think is useful in
${HOME}/bin/${INSTALLKERNEL}, can't you?




$ cat ~/bin/installkernel
#!/bin/sh

echo '== useful info for my workflow =='
echo "$@"
echo '================================='

exec /sbin/${INSTALLKERNEL} "$@"




$ chmod +x ~/bin/installkernel

$ make install
INSTALL /boot
== useful info for my workflow ==
5.17.0 arch/x86/boot/bzImage System.map /boot
=================================






--
Best Regards
Masahiro Yamada

2022-06-03 18:12:13

by Keith Busch

Subject: Re: [PATCH] kbuild: show the install image name and path

On Thu, Jun 02, 2022 at 11:52:24PM +0900, Masahiro Yamada wrote:
>
> You said "useful for *my* flow",
> so you can do whatever you think is useful in
> ${HOME}/bin/${INSTALLKERNEL}, can't you?

Thanks for the suggestion, that works for me!

2022-06-05 17:17:38

by Randy Dunlap

Subject: Re: [PATCH] kbuild: show the install image name and path

On 6/2/22 07:52, Masahiro Yamada wrote:
> On Thu, Jun 2, 2022 at 10:51 AM Keith Busch <[email protected]> wrote:
>>
>> From: Keith Busch <[email protected]>
>>
>> Prior to commit f774f5bb87d13 ("kbuild: factor out the common
>> installation code into"), a 'make install' would print out the install
>> command like:
>>
>> sh ./arch/x86/boot/install.sh 5.18.0-11935-gbffe08031c89 \
>> arch/x86/boot/bzImage System.map "/boot"
>>
>> This output was very useful for my workflow, so this patch prints it out
>> again. I'm not sure if there's a better way to do this than what's
>> implemented here, so any feedback is appreciated.
>>
>> Cc: Masahiro Yamada <[email protected]>
>> Signed-off-by: Keith Busch <[email protected]>
>> ---
>> scripts/install.sh | 1 +
>> 1 file changed, 1 insertion(+)
>>
>> diff --git a/scripts/install.sh b/scripts/install.sh
>> index 9bb0fb44f04a..2989d25ef069 100755
>> --- a/scripts/install.sh
>> +++ b/scripts/install.sh
>> @@ -33,6 +33,7 @@ do
>> # installkernel(8) says the parameters are like follows:
>> #
>> # installkernel version zImage System.map [directory]
>> + echo "$0 ${KERNELRELEASE} ${KBUILD_IMAGE} ${INSTALL_PATH}"
>> exec "${file}" "${KERNELRELEASE}" "${KBUILD_IMAGE}" System.map "${INSTALL_PATH}"
>> done
>>
>> --
>> 2.30.2
>>
>
> You said "useful for *my* flow",
> so you can do whatever you think is useful in
> ${HOME}/bin/${INSTALLKERNEL}, can't you?
>
>

True. E.g., my kernel installer also shows me

a) the modules install path (e.g., /lib/modules/$KERNEL_RELEASE)
b) the number of modules installed

>
>
> $ cat ~/bin/installkernel
> #!/bin/sh
>
> echo '== useful info for my workflow =='
> echo "$@"
> echo '================================='
>
> exec /sbin/${INSTALLKERNEL} "$@"
>
>
>
>
> $ chmod +x ~/bin/installkernel
>
> $ make install
> INSTALL /boot
> == useful info for my workflow ==
> 5.17.0 arch/x86/boot/bzImage System.map /boot
> =================================
>
>
>
>
>
>

--
~Randy