2019-10-18 22:27:14

by Masahiro Yamada

[permalink] [raw]
Subject: [PATCH 2/2] asm-generic/export.h: remove unneeded __kcrctab_* symbols

EXPORT_SYMBOL from assembly code produces an unused symbol __kcrctab_*.

kcrctab is used as a section name (prefixed with three underscores),
but never used as a symbol.

Signed-off-by: Masahiro Yamada <[email protected]>
---

include/asm-generic/export.h | 1 -
1 file changed, 1 deletion(-)

diff --git a/include/asm-generic/export.h b/include/asm-generic/export.h
index 80ef2dc0c8be..a3983e2ce0fd 100644
--- a/include/asm-generic/export.h
+++ b/include/asm-generic/export.h
@@ -43,7 +43,6 @@ __kstrtab_\name:
#ifdef CONFIG_MODVERSIONS
.section ___kcrctab\sec+\name,"a"
.balign KCRC_ALIGN
-__kcrctab_\name:
#if defined(CONFIG_MODULE_REL_CRCS)
.long __crc_\name - .
#else
--
2.17.1


2019-11-06 15:45:16

by Masahiro Yamada

[permalink] [raw]
Subject: Re: [PATCH 2/2] asm-generic/export.h: remove unneeded __kcrctab_* symbols

On Fri, Oct 18, 2019 at 1:56 PM Masahiro Yamada
<[email protected]> wrote:
>
> EXPORT_SYMBOL from assembly code produces an unused symbol __kcrctab_*.
>
> kcrctab is used as a section name (prefixed with three underscores),
> but never used as a symbol.
>
> Signed-off-by: Masahiro Yamada <[email protected]>
> ---

Applied to linux-kbuild.

>
> include/asm-generic/export.h | 1 -
> 1 file changed, 1 deletion(-)
>
> diff --git a/include/asm-generic/export.h b/include/asm-generic/export.h
> index 80ef2dc0c8be..a3983e2ce0fd 100644
> --- a/include/asm-generic/export.h
> +++ b/include/asm-generic/export.h
> @@ -43,7 +43,6 @@ __kstrtab_\name:
> #ifdef CONFIG_MODVERSIONS
> .section ___kcrctab\sec+\name,"a"
> .balign KCRC_ALIGN
> -__kcrctab_\name:
> #if defined(CONFIG_MODULE_REL_CRCS)
> .long __crc_\name - .
> #else
> --
> 2.17.1
>


--
Best Regards
Masahiro Yamada