2020-04-14 13:20:09

by Masahiro Yamada

Subject: [PATCH] kconfig: do not assign a variable in the return statement

I am not a big fan of doing assignment in a return statement.
Split it into two lines.

Signed-off-by: Masahiro Yamada <[email protected]>
---

scripts/kconfig/menu.c | 3 ++-
1 file changed, 2 insertions(+), 1 deletion(-)

diff --git a/scripts/kconfig/menu.c b/scripts/kconfig/menu.c
index e436ba44c9c5..a5fbd6ccc006 100644
--- a/scripts/kconfig/menu.c
+++ b/scripts/kconfig/menu.c
@@ -65,7 +65,8 @@ void menu_add_entry(struct symbol *sym)
struct menu *menu_add_menu(void)
{
last_entry_ptr = &current_entry->list;
- return current_menu = current_entry;
+ current_menu = current_entry;
+ return current_menu;
}

void menu_end_menu(void)
--
2.25.1

2020-04-25 17:04:18

by Masahiro Yamada

Subject: Re: [PATCH] kconfig: do not assign a variable in the return statement

On Tue, Apr 14, 2020 at 12:35 AM Masahiro Yamada <[email protected]> wrote:
>
> I am not a big fan of doing assignment in a return statement.
> Split it into two lines.
>
> Signed-off-by: Masahiro Yamada <[email protected]>



Applied to linux-kbuild.

> ---
>
> scripts/kconfig/menu.c | 3 ++-
> 1 file changed, 2 insertions(+), 1 deletion(-)
>
> diff --git a/scripts/kconfig/menu.c b/scripts/kconfig/menu.c
> index e436ba44c9c5..a5fbd6ccc006 100644
> --- a/scripts/kconfig/menu.c
> +++ b/scripts/kconfig/menu.c
> @@ -65,7 +65,8 @@ void menu_add_entry(struct symbol *sym)
> struct menu *menu_add_menu(void)
> {
> last_entry_ptr = &current_entry->list;
> - return current_menu = current_entry;
> + current_menu = current_entry;
> + return current_menu;
> }
>
> void menu_end_menu(void)
> --
> 2.25.1
>


--
Best Regards
Masahiro Yamada