2022-02-21 10:04:05

by Jialu Xu

[permalink] [raw]
Subject: [PATCH] scripts/tags.sh: parse *.dts.tmp for compiled sources

There are files listed in *.dts.tmp, parse them as *.cmd for compiled sources.

Signed-off-by: Jialu Xu <[email protected]>
---
scripts/tags.sh | 4 ++--
1 file changed, 2 insertions(+), 2 deletions(-)

diff --git a/scripts/tags.sh b/scripts/tags.sh
index 16d475b3e203..f64c33f4dabf 100755
--- a/scripts/tags.sh
+++ b/scripts/tags.sh
@@ -97,8 +97,8 @@ all_compiled_sources()
{
realpath -es $([ -z "$KBUILD_ABS_SRCTREE" ] && echo --relative-to=.) \
include/generated/autoconf.h $(find $ignore -name "*.cmd" -exec \
- grep -Poh '(?(?=^source_.* \K).*|(?=^ \K\S).*(?= \\))' {} \+ |
- awk '!a[$0]++') | sort -u
+ grep -Poh '(?(?=^source_.* \K).*|(?=^ \K\S).*(?= \\))' {} \+ | awk '!a[$0]++') \
+ $(find -name "*.dts.tmp" -exec grep -Poh '(?(?=^# \d+ "\K).*(?="))' {} \+) | sort -u
}

all_target_sources()
--
2.30.2



2022-02-22 03:11:40

by Masahiro Yamada

[permalink] [raw]
Subject: Re: [PATCH] scripts/tags.sh: parse *.dts.tmp for compiled sources

On Mon, Feb 21, 2022 at 5:46 PM Jialu Xu <[email protected]> wrote:
>
> There are files listed in *.dts.tmp, parse them as *.cmd for compiled sources.
>
> Signed-off-by: Jialu Xu <[email protected]>
> ---

Why?




> scripts/tags.sh | 4 ++--
> 1 file changed, 2 insertions(+), 2 deletions(-)
>
> diff --git a/scripts/tags.sh b/scripts/tags.sh
> index 16d475b3e203..f64c33f4dabf 100755
> --- a/scripts/tags.sh
> +++ b/scripts/tags.sh
> @@ -97,8 +97,8 @@ all_compiled_sources()
> {
> realpath -es $([ -z "$KBUILD_ABS_SRCTREE" ] && echo --relative-to=.) \
> include/generated/autoconf.h $(find $ignore -name "*.cmd" -exec \
> - grep -Poh '(?(?=^source_.* \K).*|(?=^ \K\S).*(?= \\))' {} \+ |
> - awk '!a[$0]++') | sort -u
> + grep -Poh '(?(?=^source_.* \K).*|(?=^ \K\S).*(?= \\))' {} \+ | awk '!a[$0]++') \
> + $(find -name "*.dts.tmp" -exec grep -Poh '(?(?=^# \d+ "\K).*(?="))' {} \+) | sort -u
> }
>
> all_target_sources()
> --
> 2.30.2
>
>


--
Best Regards
Masahiro Yamada

2022-02-22 07:14:51

by Jialu Xu

[permalink] [raw]
Subject: Re: Re: [PATCH] scripts/tags.sh: parse *.dts.tmp for compiled sources

> >
> > There are files listed in *.dts.tmp, parse them as *.cmd for compiled sources.
> >
> > Signed-off-by: Jialu Xu <[email protected]>
> > ---
>
> Why?

Seems that i had a misunderstanding of this, the purpose of this
function is to generate tags but not a file list, and files that
this patch can get additionally are some device tree sources, so
this patch is probabily not necessary. Sorry.