2020-04-14 13:17:59

by Masahiro Yamada

[permalink] [raw]
Subject: [PATCH] kconfig: do not use OR-assignment for zero-cleared structure

The simple assignment is enough because memset() three lines above
has zero-cleared the structure.

Signed-off-by: Masahiro Yamada <[email protected]>
---

scripts/kconfig/symbol.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/scripts/kconfig/symbol.c b/scripts/kconfig/symbol.c
index 3dc81397d003..9363e37b8870 100644
--- a/scripts/kconfig/symbol.c
+++ b/scripts/kconfig/symbol.c
@@ -831,7 +831,7 @@ struct symbol *sym_lookup(const char *name, int flags)
memset(symbol, 0, sizeof(*symbol));
symbol->name = new_name;
symbol->type = S_UNKNOWN;
- symbol->flags |= flags;
+ symbol->flags = flags;

symbol->next = symbol_hash[hash];
symbol_hash[hash] = symbol;
--
2.25.1


2020-04-25 17:02:39

by Masahiro Yamada

[permalink] [raw]
Subject: Re: [PATCH] kconfig: do not use OR-assignment for zero-cleared structure

On Tue, Apr 14, 2020 at 12:33 AM Masahiro Yamada <[email protected]> wrote:
>
> The simple assignment is enough because memset() three lines above
> has zero-cleared the structure.
>
> Signed-off-by: Masahiro Yamada <[email protected]>
> ---
>
> scripts/kconfig/symbol.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/scripts/kconfig/symbol.c b/scripts/kconfig/symbol.c
> index 3dc81397d003..9363e37b8870 100644
> --- a/scripts/kconfig/symbol.c
> +++ b/scripts/kconfig/symbol.c
> @@ -831,7 +831,7 @@ struct symbol *sym_lookup(const char *name, int flags)
> memset(symbol, 0, sizeof(*symbol));
> symbol->name = new_name;
> symbol->type = S_UNKNOWN;
> - symbol->flags |= flags;
> + symbol->flags = flags;
>
> symbol->next = symbol_hash[hash];
> symbol_hash[hash] = symbol;
> --
> 2.25.1
>

Applied to linux-kbuild.


--
Best Regards
Masahiro Yamada