2020-04-27 00:34:05

by Masahiro Yamada

[permalink] [raw]
Subject: [PATCH] kbuild: remove unused AS assignment

$(AS) is not used anywhere, hence commit aa824e0c962b ("kbuild: remove
AS variable") killed it.

Remove the left-over code in arch/{arm,arm64}/Makefile.

Signed-off-by: Masahiro Yamada <[email protected]>
---

arch/arm/Makefile | 2 --
arch/arm64/Makefile | 2 --
2 files changed, 4 deletions(-)

diff --git a/arch/arm/Makefile b/arch/arm/Makefile
index 7d5cd0f85461..cd28211f1418 100644
--- a/arch/arm/Makefile
+++ b/arch/arm/Makefile
@@ -45,12 +45,10 @@ endif
ifeq ($(CONFIG_CPU_BIG_ENDIAN),y)
KBUILD_CPPFLAGS += -mbig-endian
CHECKFLAGS += -D__ARMEB__
-AS += -EB
KBUILD_LDFLAGS += -EB
else
KBUILD_CPPFLAGS += -mlittle-endian
CHECKFLAGS += -D__ARMEL__
-AS += -EL
KBUILD_LDFLAGS += -EL
endif

diff --git a/arch/arm64/Makefile b/arch/arm64/Makefile
index 85e4149cc5d5..d86cc9137539 100644
--- a/arch/arm64/Makefile
+++ b/arch/arm64/Makefile
@@ -84,7 +84,6 @@ KBUILD_CFLAGS += $(branch-prot-flags-y)
ifeq ($(CONFIG_CPU_BIG_ENDIAN), y)
KBUILD_CPPFLAGS += -mbig-endian
CHECKFLAGS += -D__AARCH64EB__
-AS += -EB
# Prefer the baremetal ELF build target, but not all toolchains include
# it so fall back to the standard linux version if needed.
KBUILD_LDFLAGS += -EB $(call ld-option, -maarch64elfb, -maarch64linuxb)
@@ -92,7 +91,6 @@ UTS_MACHINE := aarch64_be
else
KBUILD_CPPFLAGS += -mlittle-endian
CHECKFLAGS += -D__AARCH64EL__
-AS += -EL
# Same as above, prefer ELF but fall back to linux target if needed.
KBUILD_LDFLAGS += -EL $(call ld-option, -maarch64elf, -maarch64linux)
UTS_MACHINE := aarch64
--
2.25.1


2020-04-27 02:14:54

by Nathan Chancellor

[permalink] [raw]
Subject: Re: [PATCH] kbuild: remove unused AS assignment

On Mon, Apr 27, 2020 at 09:30:19AM +0900, Masahiro Yamada wrote:
> $(AS) is not used anywhere, hence commit aa824e0c962b ("kbuild: remove
> AS variable") killed it.
>
> Remove the left-over code in arch/{arm,arm64}/Makefile.
>
> Signed-off-by: Masahiro Yamada <[email protected]>

Reviewed-by: Nathan Chancellor <[email protected]>

2020-04-27 08:07:50

by Will Deacon

[permalink] [raw]
Subject: Re: [PATCH] kbuild: remove unused AS assignment

On Mon, Apr 27, 2020 at 09:30:19AM +0900, Masahiro Yamada wrote:
> $(AS) is not used anywhere, hence commit aa824e0c962b ("kbuild: remove
> AS variable") killed it.
>
> Remove the left-over code in arch/{arm,arm64}/Makefile.
>
> Signed-off-by: Masahiro Yamada <[email protected]>
> ---
>
> arch/arm/Makefile | 2 --
> arch/arm64/Makefile | 2 --
> 2 files changed, 4 deletions(-)

Acked-by: Will Deacon <[email protected]>

(If you post the arm64 part as a separate patch, I can pick it up)

Will

2020-05-01 05:45:16

by Masahiro Yamada

[permalink] [raw]
Subject: Re: [PATCH] kbuild: remove unused AS assignment

On Mon, Apr 27, 2020 at 5:06 PM Will Deacon <[email protected]> wrote:
>
> On Mon, Apr 27, 2020 at 09:30:19AM +0900, Masahiro Yamada wrote:
> > $(AS) is not used anywhere, hence commit aa824e0c962b ("kbuild: remove
> > AS variable") killed it.
> >
> > Remove the left-over code in arch/{arm,arm64}/Makefile.
> >
> > Signed-off-by: Masahiro Yamada <[email protected]>
> > ---
> >
> > arch/arm/Makefile | 2 --
> > arch/arm64/Makefile | 2 --
> > 2 files changed, 4 deletions(-)
>
> Acked-by: Will Deacon <[email protected]>
>
> (If you post the arm64 part as a separate patch, I can pick it up)


This is just a trivial cleanup patch.
So, I do not split it per-arch.


Applied to linux-kbuild.


--
Best Regards
Masahiro Yamada