2023-08-07 16:09:33

by Masahiro Yamada

[permalink] [raw]
Subject: [PATCH 1/3] loongarch: remove unneeded #include <asm/export.h>

There is no EXPORT_SYMBOL line there, hence #include <asm/export.h>
is unneeded.

Signed-off-by: Masahiro Yamada <[email protected]>
---

arch/loongarch/kernel/mcount_dyn.S | 1 -
arch/loongarch/lib/unaligned.S | 1 -
arch/loongarch/mm/tlbex.S | 1 -
3 files changed, 3 deletions(-)

diff --git a/arch/loongarch/kernel/mcount_dyn.S b/arch/loongarch/kernel/mcount_dyn.S
index e16ab0b98e5a..482aa553aa2d 100644
--- a/arch/loongarch/kernel/mcount_dyn.S
+++ b/arch/loongarch/kernel/mcount_dyn.S
@@ -3,7 +3,6 @@
* Copyright (C) 2022 Loongson Technology Corporation Limited
*/

-#include <asm/export.h>
#include <asm/ftrace.h>
#include <asm/regdef.h>
#include <asm/stackframe.h>
diff --git a/arch/loongarch/lib/unaligned.S b/arch/loongarch/lib/unaligned.S
index 9177fd638f07..185f82d85810 100644
--- a/arch/loongarch/lib/unaligned.S
+++ b/arch/loongarch/lib/unaligned.S
@@ -9,7 +9,6 @@
#include <asm/asmmacro.h>
#include <asm/asm-extable.h>
#include <asm/errno.h>
-#include <asm/export.h>
#include <asm/regdef.h>

.L_fixup_handle_unaligned:
diff --git a/arch/loongarch/mm/tlbex.S b/arch/loongarch/mm/tlbex.S
index 4ad78703de6f..ca17dd3a1915 100644
--- a/arch/loongarch/mm/tlbex.S
+++ b/arch/loongarch/mm/tlbex.S
@@ -3,7 +3,6 @@
* Copyright (C) 2020-2022 Loongson Technology Corporation Limited
*/
#include <asm/asm.h>
-#include <asm/export.h>
#include <asm/loongarch.h>
#include <asm/page.h>
#include <asm/pgtable.h>
--
2.39.2



2023-08-07 16:24:57

by Masahiro Yamada

[permalink] [raw]
Subject: [PATCH 3/3] loongarch: remove <asm/export.h>

All *.S files under arch/loongarch/ have been converted to include
<linux/export.h> instead of <asm/export.h>.

Remove <asm/export.h>.

Signed-off-by: Masahiro Yamada <[email protected]>
---

arch/loongarch/include/asm/Kbuild | 1 -
1 file changed, 1 deletion(-)

diff --git a/arch/loongarch/include/asm/Kbuild b/arch/loongarch/include/asm/Kbuild
index 6b222f227342..93783fa24f6e 100644
--- a/arch/loongarch/include/asm/Kbuild
+++ b/arch/loongarch/include/asm/Kbuild
@@ -1,6 +1,5 @@
# SPDX-License-Identifier: GPL-2.0
generic-y += dma-contiguous.h
-generic-y += export.h
generic-y += mcs_spinlock.h
generic-y += parport.h
generic-y += early_ioremap.h
--
2.39.2


2023-08-07 16:28:57

by Huacai Chen

[permalink] [raw]
Subject: Re: [PATCH 3/3] loongarch: remove <asm/export.h>

Hi, Masahiro,

Is this series only for linux-next (6.6), or also needed by 6.5?

Huacai

On Mon, Aug 7, 2023 at 11:43 PM Masahiro Yamada <[email protected]> wrote:
>
> All *.S files under arch/loongarch/ have been converted to include
> <linux/export.h> instead of <asm/export.h>.
>
> Remove <asm/export.h>.
>
> Signed-off-by: Masahiro Yamada <[email protected]>
> ---
>
> arch/loongarch/include/asm/Kbuild | 1 -
> 1 file changed, 1 deletion(-)
>
> diff --git a/arch/loongarch/include/asm/Kbuild b/arch/loongarch/include/asm/Kbuild
> index 6b222f227342..93783fa24f6e 100644
> --- a/arch/loongarch/include/asm/Kbuild
> +++ b/arch/loongarch/include/asm/Kbuild
> @@ -1,6 +1,5 @@
> # SPDX-License-Identifier: GPL-2.0
> generic-y += dma-contiguous.h
> -generic-y += export.h
> generic-y += mcs_spinlock.h
> generic-y += parport.h
> generic-y += early_ioremap.h
> --
> 2.39.2
>

2023-08-07 16:34:54

by Masahiro Yamada

[permalink] [raw]
Subject: Re: [PATCH 3/3] loongarch: remove <asm/export.h>

On Tue, Aug 8, 2023 at 12:56 AM Huacai Chen <[email protected]> wrote:
>
> Hi, Masahiro,
>
> Is this series only for linux-next (6.6), or also needed by 6.5?

I meant it for linux-next (6.6).

Code clean-up can wait for the next MW.



--
Best Regards
Masahiro Yamada