2021-12-06 10:31:10

by kernel test robot

[permalink] [raw]
Subject: ERROR: modpost: "__divsi3_table" [lib/lz4/lz4_compress.ko] undefined!

Hi Arnd,

First bad commit (maybe != root cause):

tree: https://git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git master
head: 0fcfb00b28c0b7884635dacf38e46d60bf3d4eb1
commit: 570a82b9c36f76a5959b5e47900629b0d413931d media: i2c: select V4L2_ASYNC where needed
date: 7 weeks ago
config: nios2-randconfig-r021-20211206 (https://download.01.org/0day-ci/archive/20211206/[email protected]/config)
compiler: nios2-linux-gcc (GCC) 11.2.0
reproduce (this is a W=1 build):
wget https://raw.githubusercontent.com/intel/lkp-tests/master/sbin/make.cross -O ~/bin/make.cross
chmod +x ~/bin/make.cross
# https://git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git/commit/?id=570a82b9c36f76a5959b5e47900629b0d413931d
git remote add linus https://git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git
git fetch --no-tags linus master
git checkout 570a82b9c36f76a5959b5e47900629b0d413931d
# save the config file to linux build tree
mkdir build_dir
COMPILER_INSTALL_PATH=$HOME/0day COMPILER=gcc-11.2.0 make.cross O=build_dir ARCH=nios2 SHELL=/bin/bash

If you fix the issue, kindly add following tag as appropriate
Reported-by: kernel test robot <[email protected]>

All errors (new ones prefixed by >>, old ones prefixed by <<):

>> ERROR: modpost: "__divsi3_table" [lib/lz4/lz4_compress.ko] undefined!

---
0-DAY CI Kernel Test Service, Intel Corporation
https://lists.01.org/hyperkitty/list/[email protected]


2021-12-06 11:02:08

by Arnd Bergmann

[permalink] [raw]
Subject: Re: ERROR: modpost: "__divsi3_table" [lib/lz4/lz4_compress.ko] undefined!

On Mon, Dec 6, 2021 at 11:30 AM kernel test robot <[email protected]> wrote:
> First bad commit (maybe != root cause):
> commit: 570a82b9c36f76a5959b5e47900629b0d413931d media: i2c: select V4L2_ASYNC where needed

Right, that is clearly unrelated.

> If you fix the issue, kindly add following tag as appropriate
> Reported-by: kernel test robot <[email protected]>
>
> All errors (new ones prefixed by >>, old ones prefixed by <<):
>
> >> ERROR: modpost: "__divsi3_table" [lib/lz4/lz4_compress.ko] undefined!

lz4 was recently updated, and apparently now does a 32-bit division. I
assume this
is the decompressor, as arch/mips had similar problems.

The possible fixes are:

- disable lz4 compressed kernels on xtensa
- change lz4 to not perform any division
- change the xtensa decompressor to include the divsi3 helper code from the
main kernel, see fbf3bce45821 ("MIPS: boot/compressed/: add __ashldi3 to
target for ZSTD compression")

Arnd

2021-12-24 12:09:43

by Max Filippov

[permalink] [raw]
Subject: Re: ERROR: modpost: "__divsi3_table" [lib/lz4/lz4_compress.ko] undefined!

Hi Arnd,

On Mon, Dec 6, 2021 at 3:02 AM Arnd Bergmann <[email protected]> wrote:
>
> On Mon, Dec 6, 2021 at 11:30 AM kernel test robot <[email protected]> wrote:
> > First bad commit (maybe != root cause):
> > commit: 570a82b9c36f76a5959b5e47900629b0d413931d media: i2c: select V4L2_ASYNC where needed
>
> Right, that is clearly unrelated.
>
> > If you fix the issue, kindly add following tag as appropriate
> > Reported-by: kernel test robot <[email protected]>
> >
> > All errors (new ones prefixed by >>, old ones prefixed by <<):
> >
> > >> ERROR: modpost: "__divsi3_table" [lib/lz4/lz4_compress.ko] undefined!
>
> lz4 was recently updated, and apparently now does a 32-bit division. I
> assume this
> is the decompressor, as arch/mips had similar problems.
>
> The possible fixes are:
>
> - disable lz4 compressed kernels on xtensa
> - change lz4 to not perform any division
> - change the xtensa decompressor to include the divsi3 helper code from the
> main kernel, see fbf3bce45821 ("MIPS: boot/compressed/: add __ashldi3 to
> target for ZSTD compression")

I couldn't reproduce this on xtensa with 5.16-rc6 and I don't think there
is such issue with xtensa because it has config-specific assembly
implementation of __divsi3 that doesn't use __divsi3_table.

Also the report is against nios2.

--
Thanks.
-- Max