2021-04-25 17:51:04

by Krzysztof Kozlowski

Subject: [PATCH] ARM: exynos: add missing of_node_put for loop iteration

Early exits from for_each_compatible_node() should decrement the
node reference counter. Reported by Coccinelle:

arch/arm/mach-exynos/exynos.c:52:1-25: WARNING:
Function "for_each_compatible_node" should have of_node_put() before break around line 58.

Fixes: b3205dea8fbf ("ARM: EXYNOS: Map SYSRAM through generic DT bindings")
Signed-off-by: Krzysztof Kozlowski <[email protected]>
---
arch/arm/mach-exynos/exynos.c | 2 ++
1 file changed, 2 insertions(+)

diff --git a/arch/arm/mach-exynos/exynos.c b/arch/arm/mach-exynos/exynos.c
index 25b01da4771b..8b48326be9fd 100644
--- a/arch/arm/mach-exynos/exynos.c
+++ b/arch/arm/mach-exynos/exynos.c
@@ -55,6 +55,7 @@ void __init exynos_sysram_init(void)
sysram_base_addr = of_iomap(node, 0);
sysram_base_phys = of_translate_address(node,
of_get_address(node, 0, NULL, NULL));
+ of_node_put(node);
break;
}

@@ -62,6 +63,7 @@ void __init exynos_sysram_init(void)
if (!of_device_is_available(node))
continue;
sysram_ns_base_addr = of_iomap(node, 0);
+ of_node_put(node);
break;
}
}
--
2.25.1

2021-04-25 18:47:58

by Arnd Bergmann

Subject: Re: [PATCH] ARM: exynos: add missing of_node_put for loop iteration

On Sun, Apr 25, 2021 at 7:50 PM Krzysztof Kozlowski
<[email protected]> wrote:
>
> Early exits from for_each_compatible_node() should decrement the
> node reference counter. Reported by Coccinelle:
>
> arch/arm/mach-exynos/exynos.c:52:1-25: WARNING:
> Function "for_each_compatible_node" should have of_node_put() before break around line 58.
>
> Fixes: b3205dea8fbf ("ARM: EXYNOS: Map SYSRAM through generic DT bindings")
> Signed-off-by: Krzysztof Kozlowski <[email protected]>

Acked-by: Arnd Bergmann <[email protected]>

I've already tagged the pull requests for 5.13, so I guess you can
just add this into
your next fixes branch.

Arnd

2021-05-11 12:39:03

by Krzysztof Kozlowski

Subject: Re: [PATCH] ARM: exynos: add missing of_node_put for loop iteration

On Sun, 25 Apr 2021 19:49:45 +0200, Krzysztof Kozlowski wrote:
> Early exits from for_each_compatible_node() should decrement the
> node reference counter. Reported by Coccinelle:
>
> arch/arm/mach-exynos/exynos.c:52:1-25: WARNING:
> Function "for_each_compatible_node" should have of_node_put() before break around line 58.

Applied, thanks!

[1/1] ARM: exynos: add missing of_node_put for loop iteration
commit: 48d551bf20858240f38a0276be3016ff379918ac

Best regards,
--
Krzysztof Kozlowski <[email protected]>