Hi,
On Mon, Nov 21, 2022 at 4:45 PM Chen Zhongjin wrote:
> On 2022/11/21 14:48, Ryusuke Konishi wrote:
> > On Mon, Nov 21, 2022 at 11:16 AM Chen Zhongjin wrote:
> >> Hi,
> >>
> >> On 2022/11/19 22:09, Ryusuke Konishi wrote:
> >>> On Sat, Nov 19, 2022 at 6:37 PM Chen Zhongjin wrote:
> >>>> In nilfs_sufile_mark_dirty(), the buffer and inode are set dirty, but
> >>>> nilfs_segment_usage is not set dirty, which makes it can be found by
> >>>> nilfs_sufile_alloc() because it checks nilfs_segment_usage_clean(su).
> >>> The body of the patch looks OK, but this part of the commit log is a
> >>> bit misleading.
> >>> Could you please modify the expression so that we can understand this
> >>> patch fixes the issue when the disk image is corrupted and the leak
> >>> wasn't always there ?
> >> Makes sense. I'm going to fix the message as this:
> > Thank you for responding to my comment.
> >
> >> When extending segment, the current segment is allocated and set dirty
> >> by previous nilfs_sufile_alloc().
> >> But for some special cases such as corrupted image it can be unreliable,
> >> so nilfs_sufile_mark_dirty()
> >> is called to promise that current segment is dirty.
> > This sentence is a little different because nilfs_sufile_mark_dirty()
> > is originally called to dirty the buffer to include it as a part of
> > the log of nilfs ahead, where the completed usage data will be stored
> > later.
> >
> > And, unlike the dirty state of buffers and inodes, the dirty state of
> > segments is persistent and resides on disk until it's freed by
> > nilfs_sufile_free() unless it's destroyed on disk.
> >
> >> However, nilfs_sufile_mark_dirty() only sets buffer and inode dirty
> >> while nilfs_segment_usage can
> >> still be clean an used by following nilfs_sufile_alloc() because it
> >> checks nilfs_segment_usage_clean(su).
> >>
> >> This will cause the problem reported...
> > So, how about a description like this:
> >
> > When extending segments, nilfs_sufile_alloc() is called to get an
> > unassigned segment.
> > nilfs_sufile_alloc() then marks it as dirty to avoid accidentally
> > allocating the same segment in the future.
> > But for some special cases such as a corrupted image it can be unreliable.
> >
> > If such corruption of the dirty state of the segment occurs, nilfs2
> > may reallocate a segment that is in use and pick the same segment for
> > writing twice at the same time.
> > ...
> > This will cause the reported problem.
> > ...
> > Fix the problem by setting usage as dirty every time in
> > nilfs_sufile_mark_dirty() which is called for the current segment
> > before allocating additional segments during constructing segments to
> > be written out.
>
> Thanks for your explanation!
>
> I made some simplification, so everything looks like:
>
>
> When extending segments, nilfs_sufile_alloc() is called to get an
> unassigned segment, then mark it as dirty to avoid accidentally
> allocating the same segment in the future.
>
> But for some special cases such as a corrupted image it can be
> unreliable.
> If such corruption of the dirty state of the segment occurs, nilfs2 may
> reallocate a segment that is in use and pick the same segment for
> writing twice at the same time.
>
> This will cause the problem reported by syzkaller:
> https://syzkaller.appspot.com/bug?id=c7c4748e11ffcc367cef04f76e02e931833cbd24
>
> This case started with segbuf1.segnum = 3, nextnum = 4 when constructed.
> It supposed segment 4 has already been allocated and marked as dirty.
>
> However the dirty state was corrupted and segment 4 usage was not dirty.
> For the first time nilfs_segctor_extend_segments() segment 4 was
> allocated again, which made segbuf2 and next segbuf3 had same segment 4.
>
> sb_getblk() will get same bh for segbuf2 and segbuf3, and this bh is
> added to both buffer lists of two segbuf. It makes the lists broken
> which causes NULL pointer dereference.
>
> Fix the problem by setting usage as dirty every time in
> nilfs_sufile_mark_dirty(), which is called during constructing current
> segment to be written out and before allocating next segment.
>
> Also add lock in it to protect the usage modification.
You don't have to say this because this lock is needed to complete
your modification and not the original.
If you want to mention it, how about saying like this:
Along with this change, this also adds a lock in it to protect the
usage modification.
> If it looks good, I'll sent the v3 patch for it.
>
> Best,
> Chen
I think the rest is OK as an overall description.
Thanks,
Ryusuke Konishi
On Mon, Nov 21, 2022 at 5:48 PM Ryusuke Konishi wrote:
>
> Hi,
>
> On Mon, Nov 21, 2022 at 4:45 PM Chen Zhongjin wrote:
> > On 2022/11/21 14:48, Ryusuke Konishi wrote:
> > > On Mon, Nov 21, 2022 at 11:16 AM Chen Zhongjin wrote:
> > >> Hi,
> > >>
> > >> On 2022/11/19 22:09, Ryusuke Konishi wrote:
> > >>> On Sat, Nov 19, 2022 at 6:37 PM Chen Zhongjin wrote:
> > >>>> In nilfs_sufile_mark_dirty(), the buffer and inode are set dirty, but
> > >>>> nilfs_segment_usage is not set dirty, which makes it can be found by
> > >>>> nilfs_sufile_alloc() because it checks nilfs_segment_usage_clean(su).
> > >>> The body of the patch looks OK, but this part of the commit log is a
> > >>> bit misleading.
> > >>> Could you please modify the expression so that we can understand this
> > >>> patch fixes the issue when the disk image is corrupted and the leak
> > >>> wasn't always there ?
> > >> Makes sense. I'm going to fix the message as this:
> > > Thank you for responding to my comment.
> > >
> > >> When extending segment, the current segment is allocated and set dirty
> > >> by previous nilfs_sufile_alloc().
> > >> But for some special cases such as corrupted image it can be unreliable,
> > >> so nilfs_sufile_mark_dirty()
> > >> is called to promise that current segment is dirty.
> > > This sentence is a little different because nilfs_sufile_mark_dirty()
> > > is originally called to dirty the buffer to include it as a part of
> > > the log of nilfs ahead, where the completed usage data will be stored
> > > later.
> > >
> > > And, unlike the dirty state of buffers and inodes, the dirty state of
> > > segments is persistent and resides on disk until it's freed by
> > > nilfs_sufile_free() unless it's destroyed on disk.
> > >
> > >> However, nilfs_sufile_mark_dirty() only sets buffer and inode dirty
> > >> while nilfs_segment_usage can
> > >> still be clean an used by following nilfs_sufile_alloc() because it
> > >> checks nilfs_segment_usage_clean(su).
> > >>
> > >> This will cause the problem reported...
> > > So, how about a description like this:
> > >
> > > When extending segments, nilfs_sufile_alloc() is called to get an
> > > unassigned segment.
> > > nilfs_sufile_alloc() then marks it as dirty to avoid accidentally
> > > allocating the same segment in the future.
> > > But for some special cases such as a corrupted image it can be unreliable.
> > >
> > > If such corruption of the dirty state of the segment occurs, nilfs2
> > > may reallocate a segment that is in use and pick the same segment for
> > > writing twice at the same time.
> > > ...
> > > This will cause the reported problem.
> > > ...
> > > Fix the problem by setting usage as dirty every time in
> > > nilfs_sufile_mark_dirty() which is called for the current segment
> > > before allocating additional segments during constructing segments to
> > > be written out.
> >
> > Thanks for your explanation!
> >
> > I made some simplification, so everything looks like:
> >
> >
> > When extending segments, nilfs_sufile_alloc() is called to get an
> > unassigned segment, then mark it as dirty to avoid accidentally
> > allocating the same segment in the future.
> >
> > But for some special cases such as a corrupted image it can be
> > unreliable.
> > If such corruption of the dirty state of the segment occurs, nilfs2 may
> > reallocate a segment that is in use and pick the same segment for
> > writing twice at the same time.
> >
> > This will cause the problem reported by syzkaller:
> > https://syzkaller.appspot.com/bug?id=c7c4748e11ffcc367cef04f76e02e931833cbd24
> >
> > This case started with segbuf1.segnum = 3, nextnum = 4 when constructed.
> > It supposed segment 4 has already been allocated and marked as dirty.
> >
> > However the dirty state was corrupted and segment 4 usage was not dirty.
> > For the first time nilfs_segctor_extend_segments() segment 4 was
> > allocated again, which made segbuf2 and next segbuf3 had same segment 4.
> >
> > sb_getblk() will get same bh for segbuf2 and segbuf3, and this bh is
> > added to both buffer lists of two segbuf. It makes the lists broken
> > which causes NULL pointer dereference.
> >
> > Fix the problem by setting usage as dirty every time in
> > nilfs_sufile_mark_dirty(), which is called during constructing current
> > segment to be written out and before allocating next segment.
> >
>
> > Also add lock in it to protect the usage modification.
>
> You don't have to say this because this lock is needed to complete
> your modification and not the original.
> If you want to mention it, how about saying like this:
>
> Along with this change, this also adds a lock in it to protect the
> usage modification.
Come to think of it, this was also a misleading expression because the
patch doesn't add a new lock, but adds a use of an existing lock.
Either way, I'll leave it up to you.
Thanks,
Ryusuke Konishi
>
> > If it looks good, I'll sent the v3 patch for it.
> >
> > Best,
> > Chen
>
> I think the rest is OK as an overall description.
>
> Thanks,
> Ryusuke Konishi