2021-06-21 10:06:22

by Colin King

Subject: [PATCH] nilfs2: remove redundant continue statement in a while-loop

From: Colin Ian King <[email protected]>

The continue statement at the end of the while-loop is redundant,
remove it.

Addresses-Coverity: ("Continue has no effect")
Signed-off-by: Colin Ian King <[email protected]>
---
fs/nilfs2/btree.c | 1 -
1 file changed, 1 deletion(-)

diff --git a/fs/nilfs2/btree.c b/fs/nilfs2/btree.c
index f42ab57201e7..ab9ec073330f 100644
--- a/fs/nilfs2/btree.c
+++ b/fs/nilfs2/btree.c
@@ -738,7 +738,6 @@ static int nilfs_btree_lookup_contig(const struct nilfs_bmap *btree,
if (ptr2 != ptr + cnt || ++cnt == maxblocks)
goto end;
index++;
- continue;
}
if (level == maxlevel)
break;
--
2.31.1

2021-06-24 17:38:24

by Ryusuke Konishi

Subject: Re: [PATCH] nilfs2: remove redundant continue statement in a while-loop

Thank you. This change is correct also in view of the expected
behavior of the function
(it really is unnecessary).
I will send this to upstream.

Regards,
Ryusuke Konishi

On Mon, Jun 21, 2021 at 7:05 PM Colin King <[email protected]> wrote:
>
> From: Colin Ian King <[email protected]>
>
> The continue statement at the end of the while-loop is redundant,
> remove it.
>
> Addresses-Coverity: ("Continue has no effect")
> Signed-off-by: Colin Ian King <[email protected]>
> ---
> fs/nilfs2/btree.c | 1 -
> 1 file changed, 1 deletion(-)
>
> diff --git a/fs/nilfs2/btree.c b/fs/nilfs2/btree.c
> index f42ab57201e7..ab9ec073330f 100644
> --- a/fs/nilfs2/btree.c
> +++ b/fs/nilfs2/btree.c
> @@ -738,7 +738,6 @@ static int nilfs_btree_lookup_contig(const struct nilfs_bmap *btree,
> if (ptr2 != ptr + cnt || ++cnt == maxblocks)
> goto end;
> index++;
> - continue;
> }
> if (level == maxlevel)
> break;
> --
> 2.31.1
>