Commit 5a517b5bf687 ("i2c: designware: Get rid of legacy platform data")
removes ./include/linux/platform_data/i2c-designware.h, but misses to
adjust the SYNOPSYS DESIGNWARE I2C DRIVER section in MAINTAINERS.
Hence, ./scripts/get_maintainer.pl --self-test=patterns complains:
warning: no file matches F: include/linux/platform_data/i2c-designware.h
Remove the file entry to this removed file as well.
Signed-off-by: Lukas Bulwahn <[email protected]>
---
applies cleanly on next-20210419
Andy, please ack.
Lee, please pick this minor patch on your -next tree.
MAINTAINERS | 1 -
1 file changed, 1 deletion(-)
diff --git a/MAINTAINERS b/MAINTAINERS
index bbe356508f29..6b903aad27f4 100644
--- a/MAINTAINERS
+++ b/MAINTAINERS
@@ -17667,7 +17667,6 @@ R: Mika Westerberg <[email protected]>
L: [email protected]
S: Maintained
F: drivers/i2c/busses/i2c-designware-*
-F: include/linux/platform_data/i2c-designware.h
SYNOPSYS DESIGNWARE MMC/SD/SDIO DRIVER
M: Jaehoon Chung <[email protected]>
--
2.17.1
On Mon, Apr 19, 2021 at 9:38 AM Lukas Bulwahn <[email protected]> wrote:
>
> Commit 5a517b5bf687 ("i2c: designware: Get rid of legacy platform data")
> removes ./include/linux/platform_data/i2c-designware.h, but misses to
> adjust the SYNOPSYS DESIGNWARE I2C DRIVER section in MAINTAINERS.
>
> Hence, ./scripts/get_maintainer.pl --self-test=patterns complains:
>
> warning: no file matches F: include/linux/platform_data/i2c-designware.h
>
> Remove the file entry to this removed file as well.
Oops, I was under the impression I grepped all occurrences, but I have not.
Reviewed-by: Andy Shevchenko <[email protected]>
Thanks for the catch!
> Signed-off-by: Lukas Bulwahn <[email protected]>
> ---
> applies cleanly on next-20210419
>
> Andy, please ack.
> Lee, please pick this minor patch on your -next tree.
>
> MAINTAINERS | 1 -
> 1 file changed, 1 deletion(-)
>
> diff --git a/MAINTAINERS b/MAINTAINERS
> index bbe356508f29..6b903aad27f4 100644
> --- a/MAINTAINERS
> +++ b/MAINTAINERS
> @@ -17667,7 +17667,6 @@ R: Mika Westerberg <[email protected]>
> L: [email protected]
> S: Maintained
> F: drivers/i2c/busses/i2c-designware-*
> -F: include/linux/platform_data/i2c-designware.h
>
> SYNOPSYS DESIGNWARE MMC/SD/SDIO DRIVER
> M: Jaehoon Chung <[email protected]>
> --
> 2.17.1
>
--
With Best Regards,
Andy Shevchenko
On Mon, Apr 19, 2021 at 11:33:16AM +0300, Andy Shevchenko wrote:
> On Mon, Apr 19, 2021 at 9:38 AM Lukas Bulwahn <[email protected]> wrote:
> >
> > Commit 5a517b5bf687 ("i2c: designware: Get rid of legacy platform data")
> > removes ./include/linux/platform_data/i2c-designware.h, but misses to
> > adjust the SYNOPSYS DESIGNWARE I2C DRIVER section in MAINTAINERS.
> >
> > Hence, ./scripts/get_maintainer.pl --self-test=patterns complains:
> >
> > warning: no file matches F: include/linux/platform_data/i2c-designware.h
> >
> > Remove the file entry to this removed file as well.
>
> Oops, I was under the impression I grepped all occurrences, but I have not.
>
> Reviewed-by: Andy Shevchenko <[email protected]>
>
> Thanks for the catch!
Wolfram, isn't it forgotten somehow?
--
With Best Regards,
Andy Shevchenko
> > > Remove the file entry to this removed file as well.
> >
> > Oops, I was under the impression I grepped all occurrences, but I have not.
> >
> > Reviewed-by: Andy Shevchenko <[email protected]>
> >
> > Thanks for the catch!
>
> Wolfram, isn't it forgotten somehow?
I can pick it. I refrained from doing so because Lukas explicitly asked
Lee to pick it.
On Mon, Apr 19, 2021 at 08:18:09AM +0200, Lukas Bulwahn wrote:
> Commit 5a517b5bf687 ("i2c: designware: Get rid of legacy platform data")
> removes ./include/linux/platform_data/i2c-designware.h, but misses to
> adjust the SYNOPSYS DESIGNWARE I2C DRIVER section in MAINTAINERS.
>
> Hence, ./scripts/get_maintainer.pl --self-test=patterns complains:
>
> warning: no file matches F: include/linux/platform_data/i2c-designware.h
>
> Remove the file entry to this removed file as well.
>
> Signed-off-by: Lukas Bulwahn <[email protected]>
Applied to for-current, thanks!
On Fri, May 28, 2021 at 4:48 PM Wolfram Sang <[email protected]> wrote:
>
>
> > > > Remove the file entry to this removed file as well.
> > >
> > > Oops, I was under the impression I grepped all occurrences, but I have not.
> > >
> > > Reviewed-by: Andy Shevchenko <[email protected]>
> > >
> > > Thanks for the catch!
> >
> > Wolfram, isn't it forgotten somehow?
>
> I can pick it. I refrained from doing so because Lukas explicitly asked
> Lee to pick it.
>
Wolfram, take it. Nobody compiles MAINTAINERS, so it cannot break any build :)
Thanks, Lukas
On Fri, May 28, 2021 at 04:48:16PM +0200, Wolfram Sang wrote:
>
> > > > Remove the file entry to this removed file as well.
> > >
> > > Oops, I was under the impression I grepped all occurrences, but I have not.
> > >
> > > Reviewed-by: Andy Shevchenko <[email protected]>
> > >
> > > Thanks for the catch!
> >
> > Wolfram, isn't it forgotten somehow?
>
> I can pick it. I refrained from doing so because Lukas explicitly asked
> Lee to pick it.
Ah, I see. AFAIR Lee doesn't update his branch frequently, so it might be that
he already applied that but it's not visible to Linux Next.
--
With Best Regards,
Andy Shevchenko
On Fri, 28 May 2021, Andy Shevchenko wrote:
> On Fri, May 28, 2021 at 04:48:16PM +0200, Wolfram Sang wrote:
> >
> > > > > Remove the file entry to this removed file as well.
> > > >
> > > > Oops, I was under the impression I grepped all occurrences, but I have not.
> > > >
> > > > Reviewed-by: Andy Shevchenko <[email protected]>
> > > >
> > > > Thanks for the catch!
> > >
> > > Wolfram, isn't it forgotten somehow?
> >
> > I can pick it. I refrained from doing so because Lukas explicitly asked
> > Lee to pick it.
>
> Ah, I see. AFAIR Lee doesn't update his branch frequently, so it might be that
> he already applied that but it's not visible to Linux Next.
I'm not sure whether to find this funny or be offended.
Let's go with funny!
AFAICT, this patch does not enter my area of responsibility.
Please take it via I2C.
--
Lee Jones [李琼斯]
Senior Technical Lead - Developer Services
Linaro.org │ Open source software for Arm SoCs
Follow Linaro: Facebook | Twitter | Blog
On Fri, May 28, 2021 at 9:20 PM Lee Jones <[email protected]> wrote:
> On Fri, 28 May 2021, Andy Shevchenko wrote:
> > On Fri, May 28, 2021 at 04:48:16PM +0200, Wolfram Sang wrote:
...
> > Ah, I see. AFAIR Lee doesn't update his branch frequently, so it might be that
> > he already applied that but it's not visible to Linux Next.
>
> I'm not sure whether to find this funny or be offended.
Definitely not about offending anyone. Let's go with funny!
--
With Best Regards,
Andy Shevchenko