2021-12-30 12:59:59

by Lukas Bulwahn

[permalink] [raw]
Subject: References to non-existing configs in the NILFS2 FILESYSTEM

Dear Ryusuke Konishi-san,


The script ./scripts/checkkconfigsymbols.py identifies references to
non-existing configs in the NILFS2 FILESYSTEM:

NILFS_POSIX_ACL
Referencing files: fs/nilfs2/nilfs.h

NILFS_XATTR
Referencing files: fs/nilfs2/nilfs.h, fs/nilfs2/super.c

I assume this filesystem support is simply not yet developed to
support those two configs fully, and these code blocks are just some
first steps in that direction, but are currently just intended to be
dead code in the repository. If you do not see this support to be
added in the future, you could also just delete these ifdef blocks and
these references to non-existing configs.

This is just to share this information with you; there is no need for
further action.


Best regards,

Lukas


2021-12-30 14:15:10

by Ryusuke Konishi

[permalink] [raw]
Subject: Re: References to non-existing configs in the NILFS2 FILESYSTEM

Hi,

On Thu, Dec 30, 2021 at 9:59 PM Lukas Bulwahn <[email protected]> wrote:
>
> Dear Ryusuke Konishi-san,
>
>
> The script ./scripts/checkkconfigsymbols.py identifies references to
> non-existing configs in the NILFS2 FILESYSTEM:
>
> NILFS_POSIX_ACL
> Referencing files: fs/nilfs2/nilfs.h
>
> NILFS_XATTR
> Referencing files: fs/nilfs2/nilfs.h, fs/nilfs2/super.c
>
> I assume this filesystem support is simply not yet developed to
> support those two configs fully, and these code blocks are just some
> first steps in that direction, but are currently just intended to be
> dead code in the repository. If you do not see this support to be
> added in the future, you could also just delete these ifdef blocks and
> these references to non-existing configs.
>
> This is just to share this information with you; there is no need for
> further action.
>
>
> Best regards,
>
> Lukas

Thank you for the feedback on the check script warnings.
I will put the decision on hold, however, I recognized it.

Thanks,
Ryusuke Konishi