2020-03-20 13:22:49

by Vincent Donnefort

Subject: [PATCH] sched: Remove unused last_load_update_tick rq member

From: Vincent Donnefort <[email protected]>

The commit 5e83eafbfd3b ("sched/fair: Remove the rq->cpu_load[] update
code") eliminated the use case for rq->last_load_update_tick. Removing
it.

Signed-off-by: Vincent Donnefort <[email protected]>

diff --git a/kernel/sched/core.c b/kernel/sched/core.c
index 1a9983d..c41ee26 100644
--- a/kernel/sched/core.c
+++ b/kernel/sched/core.c
@@ -6685,7 +6685,6 @@ void __init sched_init(void)

rq_attach_root(rq, &def_root_domain);
#ifdef CONFIG_NO_HZ_COMMON
- rq->last_load_update_tick = jiffies;
rq->last_blocked_load_update_tick = jiffies;
atomic_set(&rq->nohz_flags, 0);
#endif
diff --git a/kernel/sched/sched.h b/kernel/sched/sched.h
index 9ea6478..6e14fad 100644
--- a/kernel/sched/sched.h
+++ b/kernel/sched/sched.h
@@ -860,7 +860,6 @@ struct rq {
#endif
#ifdef CONFIG_NO_HZ_COMMON
#ifdef CONFIG_SMP
- unsigned long last_load_update_tick;
unsigned long last_blocked_load_update_tick;
unsigned int has_blocked_load;
#endif /* CONFIG_SMP */
--
2.7.4

2020-03-20 13:47:01

by Dietmar Eggemann

Subject: Re: [PATCH] sched: Remove unused last_load_update_tick rq member

+ Vincent Guittot

On 20.03.20 14:21, [email protected] wrote:
> From: Vincent Donnefort <[email protected]>
>
> The commit 5e83eafbfd3b ("sched/fair: Remove the rq->cpu_load[] update
> code") eliminated the use case for rq->last_load_update_tick. Removing
> it.
>
> Signed-off-by: Vincent Donnefort <[email protected]>
>
> diff --git a/kernel/sched/core.c b/kernel/sched/core.c
> index 1a9983d..c41ee26 100644
> --- a/kernel/sched/core.c
> +++ b/kernel/sched/core.c
> @@ -6685,7 +6685,6 @@ void __init sched_init(void)
>
> rq_attach_root(rq, &def_root_domain);
> #ifdef CONFIG_NO_HZ_COMMON
> - rq->last_load_update_tick = jiffies;
> rq->last_blocked_load_update_tick = jiffies;
> atomic_set(&rq->nohz_flags, 0);
> #endif
> diff --git a/kernel/sched/sched.h b/kernel/sched/sched.h
> index 9ea6478..6e14fad 100644
> --- a/kernel/sched/sched.h
> +++ b/kernel/sched/sched.h
> @@ -860,7 +860,6 @@ struct rq {
> #endif
> #ifdef CONFIG_NO_HZ_COMMON
> #ifdef CONFIG_SMP
> - unsigned long last_load_update_tick;
> unsigned long last_blocked_load_update_tick;
> unsigned int has_blocked_load;
> #endif /* CONFIG_SMP */

Reviewed-by: Dietmar Eggemann <[email protected]>

2020-03-20 13:59:14

by Vincent Guittot

Subject: Re: [PATCH] sched: Remove unused last_load_update_tick rq member

On Fri, 20 Mar 2020 at 14:44, Dietmar Eggemann <[email protected]> wrote:
>
> + Vincent Guittot

Thanks Dietmar

>
> On 20.03.20 14:21, [email protected] wrote:
> > From: Vincent Donnefort <[email protected]>
> >
> > The commit 5e83eafbfd3b ("sched/fair: Remove the rq->cpu_load[] update
> > code") eliminated the use case for rq->last_load_update_tick. Removing
> > it.
> >
> > Signed-off-by: Vincent Donnefort <[email protected]>

Reviewed-by: Vincent Guittot <[email protected]>

> >
> > diff --git a/kernel/sched/core.c b/kernel/sched/core.c
> > index 1a9983d..c41ee26 100644
> > --- a/kernel/sched/core.c
> > +++ b/kernel/sched/core.c
> > @@ -6685,7 +6685,6 @@ void __init sched_init(void)
> >
> > rq_attach_root(rq, &def_root_domain);
> > #ifdef CONFIG_NO_HZ_COMMON
> > - rq->last_load_update_tick = jiffies;
> > rq->last_blocked_load_update_tick = jiffies;
> > atomic_set(&rq->nohz_flags, 0);
> > #endif
> > diff --git a/kernel/sched/sched.h b/kernel/sched/sched.h
> > index 9ea6478..6e14fad 100644
> > --- a/kernel/sched/sched.h
> > +++ b/kernel/sched/sched.h
> > @@ -860,7 +860,6 @@ struct rq {
> > #endif
> > #ifdef CONFIG_NO_HZ_COMMON
> > #ifdef CONFIG_SMP
> > - unsigned long last_load_update_tick;
> > unsigned long last_blocked_load_update_tick;
> > unsigned int has_blocked_load;
> > #endif /* CONFIG_SMP */
>
> Reviewed-by: Dietmar Eggemann <[email protected]>

2020-04-08 13:28:58

by tip-bot2 for Haifeng Xu

Subject: [tip: sched/urgent] sched/core: Remove unused rq::last_load_update_tick

The following commit has been merged into the sched/urgent branch of tip:

Commit-ID: 275b2f6723ab9173484e1055ae138d4c2dd9d7c5
Gitweb: https://git.kernel.org/tip/275b2f6723ab9173484e1055ae138d4c2dd9d7c5
Author: Vincent Donnefort <[email protected]>
AuthorDate: Fri, 20 Mar 2020 13:21:35
Committer: Ingo Molnar <[email protected]>
CommitterDate: Wed, 08 Apr 2020 11:35:23 +02:00

sched/core: Remove unused rq::last_load_update_tick

The following commit:

5e83eafbfd3b ("sched/fair: Remove the rq->cpu_load[] update code")

eliminated the last use case for rq->last_load_update_tick, so remove
the field as well.

Reviewed-by: Dietmar Eggemann <[email protected]>
Reviewed-by: Vincent Guittot <[email protected]>
Signed-off-by: Vincent Donnefort <[email protected]>
Signed-off-by: Peter Zijlstra (Intel) <[email protected]>
Signed-off-by: Ingo Molnar <[email protected]>
Link: https://lkml.kernel.org/r/[email protected]
---
kernel/sched/core.c | 1 -
kernel/sched/sched.h | 1 -
2 files changed, 2 deletions(-)

diff --git a/kernel/sched/core.c b/kernel/sched/core.c
index c3d12e3..3a61a3b 100644
--- a/kernel/sched/core.c
+++ b/kernel/sched/core.c
@@ -6694,7 +6694,6 @@ void __init sched_init(void)

rq_attach_root(rq, &def_root_domain);
#ifdef CONFIG_NO_HZ_COMMON
- rq->last_load_update_tick = jiffies;
rq->last_blocked_load_update_tick = jiffies;
atomic_set(&rq->nohz_flags, 0);
#endif
diff --git a/kernel/sched/sched.h b/kernel/sched/sched.h
index cd00814..db3a576 100644
--- a/kernel/sched/sched.h
+++ b/kernel/sched/sched.h
@@ -888,7 +888,6 @@ struct rq {
#endif
#ifdef CONFIG_NO_HZ_COMMON
#ifdef CONFIG_SMP
- unsigned long last_load_update_tick;
unsigned long last_blocked_load_update_tick;
unsigned int has_blocked_load;
#endif /* CONFIG_SMP */