2020-04-14 06:17:41

by Zou Wei

Subject: [PATCH-next] sched/topology: use true, false for bool variable

Fixes coccicheck warning:

kernel/sched/topology.c:224:3-22: WARNING: Assignment of 0/1 to bool variable
kernel/sched/topology.c:226:3-22: WARNING: Assignment of 0/1 to bool variable

Reported-by: Hulk Robot <[email protected]>
Signed-off-by: Zou Wei <[email protected]>
---
kernel/sched/topology.c | 4 ++--
1 file changed, 2 insertions(+), 2 deletions(-)

diff --git a/kernel/sched/topology.c b/kernel/sched/topology.c
index 8344757b..e4d6464 100644
--- a/kernel/sched/topology.c
+++ b/kernel/sched/topology.c
@@ -221,9 +221,9 @@ int sched_energy_aware_handler(struct ctl_table *table, int write,
state = static_branch_unlikely(&sched_energy_present);
if (state != sysctl_sched_energy_aware) {
mutex_lock(&sched_energy_mutex);
- sched_energy_update = 1;
+ sched_energy_update = true;
rebuild_sched_domains();
- sched_energy_update = 0;
+ sched_energy_update = false;
mutex_unlock(&sched_energy_mutex);
}
}
--
2.6.2

2020-04-14 15:07:03

by Vincent Guittot

Subject: Re: [PATCH-next] sched/topology: use true, false for bool variable

On Mon, 13 Apr 2020 at 13:55, Zou Wei <[email protected]> wrote:
>
> Fixes coccicheck warning:
>
> kernel/sched/topology.c:224:3-22: WARNING: Assignment of 0/1 to bool variable
> kernel/sched/topology.c:226:3-22: WARNING: Assignment of 0/1 to bool variable
>
> Reported-by: Hulk Robot <[email protected]>
> Signed-off-by: Zou Wei <[email protected]>

You will probably be interested by this thread
https://lkml.org/lkml/2020/3/27/785

> ---
> kernel/sched/topology.c | 4 ++--
> 1 file changed, 2 insertions(+), 2 deletions(-)
>
> diff --git a/kernel/sched/topology.c b/kernel/sched/topology.c
> index 8344757b..e4d6464 100644
> --- a/kernel/sched/topology.c
> +++ b/kernel/sched/topology.c
> @@ -221,9 +221,9 @@ int sched_energy_aware_handler(struct ctl_table *table, int write,
> state = static_branch_unlikely(&sched_energy_present);
> if (state != sysctl_sched_energy_aware) {
> mutex_lock(&sched_energy_mutex);
> - sched_energy_update = 1;
> + sched_energy_update = true;
> rebuild_sched_domains();
> - sched_energy_update = 0;
> + sched_energy_update = false;
> mutex_unlock(&sched_energy_mutex);
> }
> }
> --
> 2.6.2
>

2020-04-15 19:12:31

by Peter Zijlstra

Subject: Re: [PATCH-next] sched/topology: use true, false for bool variable

On Mon, Apr 13, 2020 at 08:01:21PM +0800, Zou Wei wrote:
> Fixes coccicheck warning:
>
> kernel/sched/topology.c:224:3-22: WARNING: Assignment of 0/1 to bool variable
> kernel/sched/topology.c:226:3-22: WARNING: Assignment of 0/1 to bool variable

Please shoot that script, it's broken crap.