2021-03-20 11:19:56

by kernel test robot

[permalink] [raw]
Subject: drivers/gpu/drm/i915/gvt/gtt.c:267:19: error: unused function 'get_pt_type'

Hi Nick,

FYI, the error/warning still remains.

tree: https://git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git master
head: 1c273e10bc0cc7efb933e0ca10e260cdfc9f0b8c
commit: 9f4069b055d1508c833115df7493b6e0001e5c9b drm/i915: re-disable -Wframe-address
date: 11 months ago
config: x86_64-randconfig-a016-20210319 (attached as .config)
compiler: clang version 13.0.0 (https://github.com/llvm/llvm-project fcc1ce00931751ac02498986feb37744e9ace8de)
reproduce (this is a W=1 build):
wget https://raw.githubusercontent.com/intel/lkp-tests/master/sbin/make.cross -O ~/bin/make.cross
chmod +x ~/bin/make.cross
# install x86_64 cross compiling tool for clang build
# apt-get install binutils-x86-64-linux-gnu
# https://git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git/commit/?id=9f4069b055d1508c833115df7493b6e0001e5c9b
git remote add linus https://git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git
git fetch --no-tags linus master
git checkout 9f4069b055d1508c833115df7493b6e0001e5c9b
# save the attached .config to linux build tree
COMPILER_INSTALL_PATH=$HOME/0day COMPILER=clang make.cross ARCH=x86_64

If you fix the issue, kindly add following tag as appropriate
Reported-by: kernel test robot <[email protected]>

All errors (new ones prefixed by >>):

>> drivers/gpu/drm/i915/gvt/gtt.c:267:19: error: unused function 'get_pt_type' [-Werror,-Wunused-function]
static inline int get_pt_type(int type)
^
>> drivers/gpu/drm/i915/gvt/gtt.c:590:20: error: unused function 'ppgtt_set_guest_root_entry' [-Werror,-Wunused-function]
static inline void ppgtt_set_guest_root_entry(struct intel_vgpu_mm *mm,
^
2 errors generated.


vim +/get_pt_type +267 drivers/gpu/drm/i915/gvt/gtt.c

2707e44466881d6 Zhi Wang 2016-03-28 266
054f4eba2a2985b Zhi Wang 2017-10-10 @267 static inline int get_pt_type(int type)
054f4eba2a2985b Zhi Wang 2017-10-10 268 {
054f4eba2a2985b Zhi Wang 2017-10-10 269 return gtt_type_table[type].pt_type;
054f4eba2a2985b Zhi Wang 2017-10-10 270 }
054f4eba2a2985b Zhi Wang 2017-10-10 271

:::::: The code at line 267 was first introduced by commit
:::::: 054f4eba2a2985b1db43353b7b5ce90e96cf9bb9 drm/i915/gvt: Introduce page table type of current level in GTT type enumerations

:::::: TO: Zhi Wang <[email protected]>
:::::: CC: Zhenyu Wang <[email protected]>

---
0-DAY CI Kernel Test Service, Intel Corporation
https://lists.01.org/hyperkitty/list/[email protected]


Attachments:
(No filename) (2.56 kB)
.config.gz (33.53 kB)
Download all attachments

2021-03-23 22:20:24

by Nick Desaulniers

[permalink] [raw]
Subject: Re: drivers/gpu/drm/i915/gvt/gtt.c:267:19: error: unused function 'get_pt_type'

On Fri, Mar 19, 2021 at 11:45 PM kernel test robot <[email protected]> wrote:
>
> Hi Nick,
>
> FYI, the error/warning still remains.
>
> tree: https://git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git master
> head: 1c273e10bc0cc7efb933e0ca10e260cdfc9f0b8c
> commit: 9f4069b055d1508c833115df7493b6e0001e5c9b drm/i915: re-disable -Wframe-address

This in unrelated to my change.

+ Changbin, Zhenyu (authors of 3aff3512802) and Zhi (author of
054f4eba2a298) in case there's any interest in fixing this up.
Otherwise I don't think these tiny helpful functions were meant to be
used somewhere but are not, so there's not much value in cleaning them
up.

> date: 11 months ago
> config: x86_64-randconfig-a016-20210319 (attached as .config)
> compiler: clang version 13.0.0 (https://github.com/llvm/llvm-project fcc1ce00931751ac02498986feb37744e9ace8de)
> reproduce (this is a W=1 build):
> wget https://raw.githubusercontent.com/intel/lkp-tests/master/sbin/make.cross -O ~/bin/make.cross
> chmod +x ~/bin/make.cross
> # install x86_64 cross compiling tool for clang build
> # apt-get install binutils-x86-64-linux-gnu
> # https://git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git/commit/?id=9f4069b055d1508c833115df7493b6e0001e5c9b
> git remote add linus https://git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git
> git fetch --no-tags linus master
> git checkout 9f4069b055d1508c833115df7493b6e0001e5c9b
> # save the attached .config to linux build tree
> COMPILER_INSTALL_PATH=$HOME/0day COMPILER=clang make.cross ARCH=x86_64
>
> If you fix the issue, kindly add following tag as appropriate
> Reported-by: kernel test robot <[email protected]>
>
> All errors (new ones prefixed by >>):
>
> >> drivers/gpu/drm/i915/gvt/gtt.c:267:19: error: unused function 'get_pt_type' [-Werror,-Wunused-function]
> static inline int get_pt_type(int type)
> ^
> >> drivers/gpu/drm/i915/gvt/gtt.c:590:20: error: unused function 'ppgtt_set_guest_root_entry' [-Werror,-Wunused-function]
> static inline void ppgtt_set_guest_root_entry(struct intel_vgpu_mm *mm,
> ^
> 2 errors generated.
>
>
> vim +/get_pt_type +267 drivers/gpu/drm/i915/gvt/gtt.c
>
> 2707e44466881d6 Zhi Wang 2016-03-28 266
> 054f4eba2a2985b Zhi Wang 2017-10-10 @267 static inline int get_pt_type(int type)
> 054f4eba2a2985b Zhi Wang 2017-10-10 268 {
> 054f4eba2a2985b Zhi Wang 2017-10-10 269 return gtt_type_table[type].pt_type;
> 054f4eba2a2985b Zhi Wang 2017-10-10 270 }
> 054f4eba2a2985b Zhi Wang 2017-10-10 271
>
> :::::: The code at line 267 was first introduced by commit
> :::::: 054f4eba2a2985b1db43353b7b5ce90e96cf9bb9 drm/i915/gvt: Introduce page table type of current level in GTT type enumerations
>
> :::::: TO: Zhi Wang <[email protected]>
> :::::: CC: Zhenyu Wang <[email protected]>
>
> ---
> 0-DAY CI Kernel Test Service, Intel Corporation
> https://lists.01.org/hyperkitty/list/[email protected]



--
Thanks,
~Nick Desaulniers

2021-03-24 10:58:40

by Zhenyu Wang

[permalink] [raw]
Subject: Re: drivers/gpu/drm/i915/gvt/gtt.c:267:19: error: unused function 'get_pt_type'

On 2021.03.23 15:15:29 -0700, Nick Desaulniers wrote:
> On Fri, Mar 19, 2021 at 11:45 PM kernel test robot <[email protected]> wrote:
> >
> > Hi Nick,
> >
> > FYI, the error/warning still remains.
> >
> > tree: https://git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git master
> > head: 1c273e10bc0cc7efb933e0ca10e260cdfc9f0b8c
> > commit: 9f4069b055d1508c833115df7493b6e0001e5c9b drm/i915: re-disable -Wframe-address
>
> This in unrelated to my change.
>
> + Changbin, Zhenyu (authors of 3aff3512802) and Zhi (author of
> 054f4eba2a298) in case there's any interest in fixing this up.
> Otherwise I don't think these tiny helpful functions were meant to be
> used somewhere but are not, so there's not much value in cleaning them
> up.

I'll check that, should be some left over last big gtt code refactor.
Looks lkp guys don't apply -Wunused-function for gvt tree build test...

Thanks

>
> > date: 11 months ago
> > config: x86_64-randconfig-a016-20210319 (attached as .config)
> > compiler: clang version 13.0.0 (https://github.com/llvm/llvm-project fcc1ce00931751ac02498986feb37744e9ace8de)
> > reproduce (this is a W=1 build):
> > wget https://raw.githubusercontent.com/intel/lkp-tests/master/sbin/make.cross -O ~/bin/make.cross
> > chmod +x ~/bin/make.cross
> > # install x86_64 cross compiling tool for clang build
> > # apt-get install binutils-x86-64-linux-gnu
> > # https://git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git/commit/?id=9f4069b055d1508c833115df7493b6e0001e5c9b
> > git remote add linus https://git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git
> > git fetch --no-tags linus master
> > git checkout 9f4069b055d1508c833115df7493b6e0001e5c9b
> > # save the attached .config to linux build tree
> > COMPILER_INSTALL_PATH=$HOME/0day COMPILER=clang make.cross ARCH=x86_64
> >
> > If you fix the issue, kindly add following tag as appropriate
> > Reported-by: kernel test robot <[email protected]>
> >
> > All errors (new ones prefixed by >>):
> >
> > >> drivers/gpu/drm/i915/gvt/gtt.c:267:19: error: unused function 'get_pt_type' [-Werror,-Wunused-function]
> > static inline int get_pt_type(int type)
> > ^
> > >> drivers/gpu/drm/i915/gvt/gtt.c:590:20: error: unused function 'ppgtt_set_guest_root_entry' [-Werror,-Wunused-function]
> > static inline void ppgtt_set_guest_root_entry(struct intel_vgpu_mm *mm,
> > ^
> > 2 errors generated.
> >
> >
> > vim +/get_pt_type +267 drivers/gpu/drm/i915/gvt/gtt.c
> >
> > 2707e44466881d6 Zhi Wang 2016-03-28 266
> > 054f4eba2a2985b Zhi Wang 2017-10-10 @267 static inline int get_pt_type(int type)
> > 054f4eba2a2985b Zhi Wang 2017-10-10 268 {
> > 054f4eba2a2985b Zhi Wang 2017-10-10 269 return gtt_type_table[type].pt_type;
> > 054f4eba2a2985b Zhi Wang 2017-10-10 270 }
> > 054f4eba2a2985b Zhi Wang 2017-10-10 271
> >
> > :::::: The code at line 267 was first introduced by commit
> > :::::: 054f4eba2a2985b1db43353b7b5ce90e96cf9bb9 drm/i915/gvt: Introduce page table type of current level in GTT type enumerations
> >
> > :::::: TO: Zhi Wang <[email protected]>
> > :::::: CC: Zhenyu Wang <[email protected]>
> >
> > ---
> > 0-DAY CI Kernel Test Service, Intel Corporation
> > https://lists.01.org/hyperkitty/list/[email protected]
>
>
>
> --
> Thanks,
> ~Nick Desaulniers


Attachments:
(No filename) (3.42 kB)
signature.asc (201.00 B)
Download all attachments

2021-03-24 17:06:11

by Nick Desaulniers

[permalink] [raw]
Subject: Re: drivers/gpu/drm/i915/gvt/gtt.c:267:19: error: unused function 'get_pt_type'

On Wed, Mar 24, 2021 at 2:12 AM Zhenyu Wang <[email protected]> wrote:
>
> On 2021.03.23 15:15:29 -0700, Nick Desaulniers wrote:
> > On Fri, Mar 19, 2021 at 11:45 PM kernel test robot <[email protected]> wrote:
> > >
> > > Hi Nick,
> > >
> > > FYI, the error/warning still remains.
> > >
> > > tree: https://git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git master
> > > head: 1c273e10bc0cc7efb933e0ca10e260cdfc9f0b8c
> > > commit: 9f4069b055d1508c833115df7493b6e0001e5c9b drm/i915: re-disable -Wframe-address
> >
> > This in unrelated to my change.
> >
> > + Changbin, Zhenyu (authors of 3aff3512802) and Zhi (author of
> > 054f4eba2a298) in case there's any interest in fixing this up.
> > Otherwise I don't think these tiny helpful functions were meant to be
> > used somewhere but are not, so there's not much value in cleaning them
> > up.
>
> I'll check that, should be some left over last big gtt code refactor.
> Looks lkp guys don't apply -Wunused-function for gvt tree build test...

Thanks, yeah the report from the bot mentions it had `make W=1 ...` on.

>
> Thanks
>
> >
> > > date: 11 months ago
> > > config: x86_64-randconfig-a016-20210319 (attached as .config)
> > > compiler: clang version 13.0.0 (https://github.com/llvm/llvm-project fcc1ce00931751ac02498986feb37744e9ace8de)
> > > reproduce (this is a W=1 build):

^ hidden note about W=1, easy to miss.

> > > wget https://raw.githubusercontent.com/intel/lkp-tests/master/sbin/make.cross -O ~/bin/make.cross
> > > chmod +x ~/bin/make.cross
> > > # install x86_64 cross compiling tool for clang build
> > > # apt-get install binutils-x86-64-linux-gnu
> > > # https://git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git/commit/?id=9f4069b055d1508c833115df7493b6e0001e5c9b
> > > git remote add linus https://git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git
> > > git fetch --no-tags linus master
> > > git checkout 9f4069b055d1508c833115df7493b6e0001e5c9b
> > > # save the attached .config to linux build tree
> > > COMPILER_INSTALL_PATH=$HOME/0day COMPILER=clang make.cross ARCH=x86_64
> > >
> > > If you fix the issue, kindly add following tag as appropriate
> > > Reported-by: kernel test robot <[email protected]>
> > >
> > > All errors (new ones prefixed by >>):
> > >
> > > >> drivers/gpu/drm/i915/gvt/gtt.c:267:19: error: unused function 'get_pt_type' [-Werror,-Wunused-function]
> > > static inline int get_pt_type(int type)
> > > ^
> > > >> drivers/gpu/drm/i915/gvt/gtt.c:590:20: error: unused function 'ppgtt_set_guest_root_entry' [-Werror,-Wunused-function]
> > > static inline void ppgtt_set_guest_root_entry(struct intel_vgpu_mm *mm,
> > > ^
> > > 2 errors generated.
> > >
> > >
> > > vim +/get_pt_type +267 drivers/gpu/drm/i915/gvt/gtt.c
> > >
> > > 2707e44466881d6 Zhi Wang 2016-03-28 266
> > > 054f4eba2a2985b Zhi Wang 2017-10-10 @267 static inline int get_pt_type(int type)
> > > 054f4eba2a2985b Zhi Wang 2017-10-10 268 {
> > > 054f4eba2a2985b Zhi Wang 2017-10-10 269 return gtt_type_table[type].pt_type;
> > > 054f4eba2a2985b Zhi Wang 2017-10-10 270 }
> > > 054f4eba2a2985b Zhi Wang 2017-10-10 271
> > >
> > > :::::: The code at line 267 was first introduced by commit
> > > :::::: 054f4eba2a2985b1db43353b7b5ce90e96cf9bb9 drm/i915/gvt: Introduce page table type of current level in GTT type enumerations
> > >
> > > :::::: TO: Zhi Wang <[email protected]>
> > > :::::: CC: Zhenyu Wang <[email protected]>
> > >
> > > ---
> > > 0-DAY CI Kernel Test Service, Intel Corporation
> > > https://lists.01.org/hyperkitty/list/[email protected]
> >
> >
> >
> > --
> > Thanks,
> > ~Nick Desaulniers



--
Thanks,
~Nick Desaulniers