2020-04-24 22:19:50

by Andrew Davis

Subject: [PATCH] dma-buf: heaps: Initialize during core instead of subsys

Some clients of DMA-Heaps probe earlier than subsys_initcall(), this
can cause issues when these clients call dma_heap_add() before the
core DMA-Heaps framework has initialized. DMA-Heaps should initialize
during core startup to get ahead of all users.

Signed-off-by: Andrew F. Davis <[email protected]>
---
drivers/dma-buf/dma-heap.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/drivers/dma-buf/dma-heap.c b/drivers/dma-buf/dma-heap.c
index afd22c9dbdcf..af6edfbeddfe 100644
--- a/drivers/dma-buf/dma-heap.c
+++ b/drivers/dma-buf/dma-heap.c
@@ -295,4 +295,4 @@ static int dma_heap_init(void)

return 0;
}
-subsys_initcall(dma_heap_init);
+core_initcall(dma_heap_init);
--
2.17.1

2020-04-25 00:28:21

by John Stultz

Subject: Re: [PATCH] dma-buf: heaps: Initialize during core instead of subsys

On Fri, Apr 24, 2020 at 3:18 PM Andrew F. Davis <[email protected]> wrote:
>
> Some clients of DMA-Heaps probe earlier than subsys_initcall(), this
> can cause issues when these clients call dma_heap_add() before the
> core DMA-Heaps framework has initialized. DMA-Heaps should initialize
> during core startup to get ahead of all users.
>
> Signed-off-by: Andrew F. Davis <[email protected]>

No objection from me right off.

Acked-by: John Stultz <[email protected]>

thanks
-john