2017-11-09 13:15:41

by Luc Van Oostenryck

[permalink] [raw]
Subject: Re: [PATCH v2 2/2] sparc: pass endianness info to sparse

On Thu, Nov 9, 2017 at 9:34 AM, Christoph Hellwig <[email protected]> wrote:
> On Thu, Nov 09, 2017 at 07:16:52AM +0100, Luc Van Oostenryck wrote:
>> sparc is big-endian only but sparse assumes the same endianness
>> as the building machine.
>> This is problematic for code which expect __BYTE_ORDER__ being
>> correctly predefined by the compiler which sparse can then
>> pre-process differently from what gcc would, depending on the
>> building machine endianness.
>>
>> Fix this by letting sparse know about the architecture endianness.
>
> You're posted patches for this for about half a dozen architectures
> now, but we also now have generic Kconfig symbols for the byte order.
>
> I'd much rather see this done in generic code than hacking it up
> everywhere.

OK, when I wrote these patch (in June, IIRC) there wasn't yet the
generic Kconfig symbol. I'll see what can now be generic and what
need to stay specific (for example, ARM need __ARME{L,B}__,
ARM64 & MIPS are in the same situation as are a few others archs).

-- Luc Van Oostenryck

From 1583576828395367221@xxx Thu Nov 09 08:35:49 +0000 2017
X-GM-THRID: 1583568171624506780
X-Gmail-Labels: Inbox,Category Forums,HistoricalUnread