2021-02-03 00:48:51

by Stephen Boyd

[permalink] [raw]
Subject: [PATCH -next] media: venus: Include io.h for memremap()

This file uses memremap() now, so we should include io.h instead of
relying on any sort of implicit include elsewhere.

Cc: Dikshita Agarwal <[email protected]>
Fixes: 0ca0ca980505 ("media: venus: core: add support to dump FW region")
Signed-off-by: Stephen Boyd <[email protected]>
---
drivers/media/platform/qcom/venus/core.c | 1 +
1 file changed, 1 insertion(+)

diff --git a/drivers/media/platform/qcom/venus/core.c b/drivers/media/platform/qcom/venus/core.c
index 1471c7f9c89d..915b3ed8ed64 100644
--- a/drivers/media/platform/qcom/venus/core.c
+++ b/drivers/media/platform/qcom/venus/core.c
@@ -5,6 +5,7 @@
*/
#include <linux/init.h>
#include <linux/interconnect.h>
+#include <linux/io.h>
#include <linux/ioctl.h>
#include <linux/delay.h>
#include <linux/devcoredump.h>

base-commit: 0ca0ca9805055bb0efc16890f9d6433c65bd07cc
--
https://chromeos.dev


2021-02-06 03:00:40

by Fritz Koenig

[permalink] [raw]
Subject: Re: [PATCH -next] media: venus: Include io.h for memremap()

On Tue, Feb 2, 2021 at 11:51 AM Stephen Boyd <[email protected]> wrote:
>
> This file uses memremap() now, so we should include io.h instead of
> relying on any sort of implicit include elsewhere.
>
> Cc: Dikshita Agarwal <[email protected]>
> Fixes: 0ca0ca980505 ("media: venus: core: add support to dump FW region")
> Signed-off-by: Stephen Boyd <[email protected]>
> ---
> drivers/media/platform/qcom/venus/core.c | 1 +
> 1 file changed, 1 insertion(+)
>
> diff --git a/drivers/media/platform/qcom/venus/core.c b/drivers/media/platform/qcom/venus/core.c
> index 1471c7f9c89d..915b3ed8ed64 100644
> --- a/drivers/media/platform/qcom/venus/core.c
> +++ b/drivers/media/platform/qcom/venus/core.c
> @@ -5,6 +5,7 @@
> */
> #include <linux/init.h>
> #include <linux/interconnect.h>
> +#include <linux/io.h>
> #include <linux/ioctl.h>
> #include <linux/delay.h>
> #include <linux/devcoredump.h>
>
> base-commit: 0ca0ca9805055bb0efc16890f9d6433c65bd07cc
> --
> https://chromeos.dev

Reviewed-by: Fritz Koenig <[email protected]>