2021-06-29 15:43:02

by Sergio Paracuellos

Subject: [PATCH] pinctrl: ralink: rt305x: add missing include

Header 'rt305x.h' is ralink architecture dependent file where
other general definitions which are in 'ralink_regs.h' are
being used. This 'rt305x.h' is only being included in two
different files: 'rt305x.c' and 'pinctrl-rt305x.c'. When
file 'pinctrl-rt305x.c' is being compiled definitions in
'ralink_regs.h' are need to build it properly. Hence, add
missing include 'ralink_regs.h' in 'pinctrl-rt305x.c'
source to avoid compilation problems.

Fixes: 3a1b0ca5a83b ("pinctrl: ralink: move RT305X SoC pinmux config into a new 'pinctrl-rt305x.c' file")
Reported-by: kernel test robot <[email protected]>
Signed-off-by: Sergio Paracuellos <[email protected]>
---
drivers/pinctrl/ralink/pinctrl-rt305x.c | 1 +
1 file changed, 1 insertion(+)

diff --git a/drivers/pinctrl/ralink/pinctrl-rt305x.c b/drivers/pinctrl/ralink/pinctrl-rt305x.c
index 699fe18e7000..5d8fa156c003 100644
--- a/drivers/pinctrl/ralink/pinctrl-rt305x.c
+++ b/drivers/pinctrl/ralink/pinctrl-rt305x.c
@@ -1,5 +1,6 @@
// SPDX-License-Identifier: GPL-2.0-only

+#include <asm/mach-ralink/ralink_regs.h>
#include <asm/mach-ralink/rt305x.h>
#include <linux/module.h>
#include <linux/platform_device.h>
--
2.25.1

2021-06-30 00:42:12

by Linus Walleij

Subject: Re: [PATCH] pinctrl: ralink: rt305x: add missing include

On Tue, Jun 29, 2021 at 4:34 PM Sergio Paracuellos
<[email protected]> wrote:

> Header 'rt305x.h' is ralink architecture dependent file where
> other general definitions which are in 'ralink_regs.h' are
> being used. This 'rt305x.h' is only being included in two
> different files: 'rt305x.c' and 'pinctrl-rt305x.c'. When
> file 'pinctrl-rt305x.c' is being compiled definitions in
> 'ralink_regs.h' are need to build it properly. Hence, add
> missing include 'ralink_regs.h' in 'pinctrl-rt305x.c'
> source to avoid compilation problems.
>
> Fixes: 3a1b0ca5a83b ("pinctrl: ralink: move RT305X SoC pinmux config into a new 'pinctrl-rt305x.c' file")
> Reported-by: kernel test robot <[email protected]>
> Signed-off-by: Sergio Paracuellos <[email protected]>

Patch applied!

Yours,
Linus Walleij

2021-06-30 06:42:23

by Sergio Paracuellos

Subject: Re: [PATCH] pinctrl: ralink: rt305x: add missing include

On Wed, Jun 30, 2021 at 2:40 AM Linus Walleij <[email protected]> wrote:
>
> On Tue, Jun 29, 2021 at 4:34 PM Sergio Paracuellos
> <[email protected]> wrote:
>
> > Header 'rt305x.h' is ralink architecture dependent file where
> > other general definitions which are in 'ralink_regs.h' are
> > being used. This 'rt305x.h' is only being included in two
> > different files: 'rt305x.c' and 'pinctrl-rt305x.c'. When
> > file 'pinctrl-rt305x.c' is being compiled definitions in
> > 'ralink_regs.h' are need to build it properly. Hence, add
> > missing include 'ralink_regs.h' in 'pinctrl-rt305x.c'
> > source to avoid compilation problems.
> >
> > Fixes: 3a1b0ca5a83b ("pinctrl: ralink: move RT305X SoC pinmux config into a new 'pinctrl-rt305x.c' file")
> > Reported-by: kernel test robot <[email protected]>
> > Signed-off-by: Sergio Paracuellos <[email protected]>
>
> Patch applied!

Thanks!

Best regards,
Sergio Paracuellos

>
> Yours,
> Linus Walleij