2023-08-03 06:37:58

by Wang, Xiao W

Subject: [PATCH] efi/riscv: libstub: Fix comment about absolute relocation

We don't want absolute symbols references in the stub, so fix the double
negation in the comment.

Fixes: d7071743db31 ("RISC-V: Add EFI stub support.")
Cc: [email protected]
Signed-off-by: Xiao Wang <[email protected]>
---
drivers/firmware/efi/libstub/Makefile | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/drivers/firmware/efi/libstub/Makefile b/drivers/firmware/efi/libstub/Makefile
index b0f8c495c10f..ed6e8ebd89b4 100644
--- a/drivers/firmware/efi/libstub/Makefile
+++ b/drivers/firmware/efi/libstub/Makefile
@@ -146,7 +146,7 @@ STUBCOPY_RELOC-$(CONFIG_ARM64) := R_AARCH64_ABS

# For RISC-V, we don't need anything special other than arm64. Keep all the
# symbols in .init section and make sure that no absolute symbols references
-# doesn't exist.
+# exist.
STUBCOPY_FLAGS-$(CONFIG_RISCV) += --prefix-alloc-sections=.init \
--prefix-symbols=__efistub_
STUBCOPY_RELOC-$(CONFIG_RISCV) := R_RISCV_HI20
--
2.25.1

2023-08-03 14:10:34

by Ard Biesheuvel

Subject: Re: [PATCH] efi/riscv: libstub: Fix comment about absolute relocation

On Thu, 3 Aug 2023 at 07:48, Xiao Wang <[email protected]> wrote:
>
> We don't want absolute symbols references in the stub, so fix the double
> negation in the comment.
>
> Fixes: d7071743db31 ("RISC-V: Add EFI stub support.")
> Cc: [email protected]
> Signed-off-by: Xiao Wang <[email protected]>

Queued up in efi/next (without the cc stable)

Thanks,


> ---
> drivers/firmware/efi/libstub/Makefile | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/drivers/firmware/efi/libstub/Makefile b/drivers/firmware/efi/libstub/Makefile
> index b0f8c495c10f..ed6e8ebd89b4 100644
> --- a/drivers/firmware/efi/libstub/Makefile
> +++ b/drivers/firmware/efi/libstub/Makefile
> @@ -146,7 +146,7 @@ STUBCOPY_RELOC-$(CONFIG_ARM64) := R_AARCH64_ABS
>
> # For RISC-V, we don't need anything special other than arm64. Keep all the
> # symbols in .init section and make sure that no absolute symbols references
> -# doesn't exist.
> +# exist.
> STUBCOPY_FLAGS-$(CONFIG_RISCV) += --prefix-alloc-sections=.init \
> --prefix-symbols=__efistub_
> STUBCOPY_RELOC-$(CONFIG_RISCV) := R_RISCV_HI20
> --
> 2.25.1
>