2022-05-24 07:58:01

by Geert Uytterhoeven

Subject: [PATCH v2] efi: EFI_DISABLE_RUNTIME should depend on EFI

The EFI_DISABLE_RUNTIME config option controls the use of Extensible
Firmware Interface (EFI) runtime services, which matters only if EFI
support is enabled.

Hence add a dependency on EFI, to prevent asking the user about this
control knob when configuring a kernel without EFI support.

Fixes: a031651ff2144a3d ("efi: Allow to enable EFI runtime services by default on RT")
Signed-off-by: Geert Uytterhoeven <[email protected]>
Acked-by: Javier Martinez Canillas <[email protected]>
---
v2:
- Add Acked-by,
- Fix typo s/with/without/.
---
drivers/firmware/efi/Kconfig | 1 +
1 file changed, 1 insertion(+)

diff --git a/drivers/firmware/efi/Kconfig b/drivers/firmware/efi/Kconfig
index 4720ba98cec312e7..ff6e7bfa8355cfc2 100644
--- a/drivers/firmware/efi/Kconfig
+++ b/drivers/firmware/efi/Kconfig
@@ -299,6 +299,7 @@ config EFI_CUSTOM_SSDT_OVERLAYS

config EFI_DISABLE_RUNTIME
bool "Disable EFI runtime services support by default"
+ depends on EFI
default y if PREEMPT_RT
help
Allow to disable the EFI runtime services support by default. This can
--
2.25.1

2022-05-28 17:20:32

by Ard Biesheuvel

Subject: Re: [PATCH v2] efi: EFI_DISABLE_RUNTIME should depend on EFI

On Sat, 28 May 2022 at 11:24, Ard Biesheuvel <[email protected]> wrote:
>
> On Tue, 24 May 2022 at 09:37, Geert Uytterhoeven <[email protected]> wrote:
> >
> > The EFI_DISABLE_RUNTIME config option controls the use of Extensible
> > Firmware Interface (EFI) runtime services, which matters only if EFI
> > support is enabled.
> >
> > Hence add a dependency on EFI, to prevent asking the user about this
> > control knob when configuring a kernel without EFI support.
> >
> > Fixes: a031651ff2144a3d ("efi: Allow to enable EFI runtime services by default on RT")
> > Signed-off-by: Geert Uytterhoeven <[email protected]>
> > Acked-by: Javier Martinez Canillas <[email protected]>
> > ---
> > v2:
> > - Add Acked-by,
> > - Fix typo s/with/without/.
> > ---
> > drivers/firmware/efi/Kconfig | 1 +
> > 1 file changed, 1 insertion(+)
> >
>
> Can we just move this option into the menu/endmenu scope that already
> depends on EFI?
>

We can, and there are other candidates as well. So I'll drop this
patch, and send out another one that covers some other options too.

Thanks,
Ard.


> > diff --git a/drivers/firmware/efi/Kconfig b/drivers/firmware/efi/Kconfig
> > index 4720ba98cec312e7..ff6e7bfa8355cfc2 100644
> > --- a/drivers/firmware/efi/Kconfig
> > +++ b/drivers/firmware/efi/Kconfig
> > @@ -299,6 +299,7 @@ config EFI_CUSTOM_SSDT_OVERLAYS
> >
> > config EFI_DISABLE_RUNTIME
> > bool "Disable EFI runtime services support by default"
> > + depends on EFI
> > default y if PREEMPT_RT
> > help
> > Allow to disable the EFI runtime services support by default. This can
> > --
> > 2.25.1
> >

2022-05-28 20:41:01

by Ard Biesheuvel

Subject: Re: [PATCH v2] efi: EFI_DISABLE_RUNTIME should depend on EFI

On Tue, 24 May 2022 at 09:37, Geert Uytterhoeven <[email protected]> wrote:
>
> The EFI_DISABLE_RUNTIME config option controls the use of Extensible
> Firmware Interface (EFI) runtime services, which matters only if EFI
> support is enabled.
>
> Hence add a dependency on EFI, to prevent asking the user about this
> control knob when configuring a kernel without EFI support.
>
> Fixes: a031651ff2144a3d ("efi: Allow to enable EFI runtime services by default on RT")
> Signed-off-by: Geert Uytterhoeven <[email protected]>
> Acked-by: Javier Martinez Canillas <[email protected]>
> ---
> v2:
> - Add Acked-by,
> - Fix typo s/with/without/.
> ---
> drivers/firmware/efi/Kconfig | 1 +
> 1 file changed, 1 insertion(+)
>

Can we just move this option into the menu/endmenu scope that already
depends on EFI?

> diff --git a/drivers/firmware/efi/Kconfig b/drivers/firmware/efi/Kconfig
> index 4720ba98cec312e7..ff6e7bfa8355cfc2 100644
> --- a/drivers/firmware/efi/Kconfig
> +++ b/drivers/firmware/efi/Kconfig
> @@ -299,6 +299,7 @@ config EFI_CUSTOM_SSDT_OVERLAYS
>
> config EFI_DISABLE_RUNTIME
> bool "Disable EFI runtime services support by default"
> + depends on EFI
> default y if PREEMPT_RT
> help
> Allow to disable the EFI runtime services support by default. This can
> --
> 2.25.1
>