2022-09-19 09:25:17

by Ard Biesheuvel

[permalink] [raw]
Subject: Re: linux-next: build failure after merge of the efi tree

On Mon, 19 Sept 2022 at 11:11, Stephen Rothwell <[email protected]> wrote:
>
> Hi all,
>
> After merging the efi tree, today's linux-next build (x86_64 allmodconfig)
> failed like this:
>
> x86_64-linux-gnu-ld: drivers/firmware/efi/libstub/x86-stub.stub.o:(.bss.efistub+0x8): multiple definition of `efi_system_table'; drivers/firmware/efi/libstub/systable.stub.o:(.bss.efistub+0x0): first defined here
>
> Presumably caused by commit
>
> 8fd3c9a90998 ("efi/libstub: move efi_system_table global var into separate object")
>
> (or maybe commit
>
> ba2dd31b7588 ("efi/libstub: implement generic EFI zboot")
> )
>
> I have used the efi tree from next-20220916 for today.
>

Thanks for the report. I'll take a look and fix this asap.


2022-09-19 10:18:12

by Ard Biesheuvel

[permalink] [raw]
Subject: Re: linux-next: build failure after merge of the efi tree

On Mon, 19 Sept 2022 at 11:12, Ard Biesheuvel <[email protected]> wrote:
>
> On Mon, 19 Sept 2022 at 11:11, Stephen Rothwell <[email protected]> wrote:
> >
> > Hi all,
> >
> > After merging the efi tree, today's linux-next build (x86_64 allmodconfig)
> > failed like this:
> >
> > x86_64-linux-gnu-ld: drivers/firmware/efi/libstub/x86-stub.stub.o:(.bss.efistub+0x8): multiple definition of `efi_system_table'; drivers/firmware/efi/libstub/systable.stub.o:(.bss.efistub+0x0): first defined here
> >
> > Presumably caused by commit
> >
> > 8fd3c9a90998 ("efi/libstub: move efi_system_table global var into separate object")
> >
> > (or maybe commit
> >
> > ba2dd31b7588 ("efi/libstub: implement generic EFI zboot")
> > )
> >
> > I have used the efi tree from next-20220916 for today.
> >
>
> Thanks for the report. I'll take a look and fix this asap.

Fixed now on efi/next so we should be ok for tomorrow.