2021-12-01 03:43:47

by kernel test robot

Subject: [ardb:for-kernelci 18/28] arch/arm/mach-footbridge/common.c:102:6: warning: no previous prototype for function 'dc21285_handle_irq'

tree: git://git.kernel.org/pub/scm/linux/kernel/git/ardb/linux.git for-kernelci
head: 6999340fcf7f37e2a82eb35452b08c5893a2872d
commit: 9a2235df531e427be5777a894b3fa355ce127894 [18/28] ARM: footbridge: use GENERIC_IRQ_MULTI_HANDLER
config: arm-randconfig-r001-20211130 (https://download.01.org/0day-ci/archive/20211201/[email protected]/config)
compiler: clang version 14.0.0 (https://github.com/llvm/llvm-project 25eb7fa01d7ebbe67648ea03841cda55b4239ab2)
reproduce (this is a W=1 build):
wget https://raw.githubusercontent.com/intel/lkp-tests/master/sbin/make.cross -O ~/bin/make.cross
chmod +x ~/bin/make.cross
# install arm cross compiling tool for clang build
# apt-get install binutils-arm-linux-gnueabi
# https://git.kernel.org/pub/scm/linux/kernel/git/ardb/linux.git/commit/?id=9a2235df531e427be5777a894b3fa355ce127894
git remote add ardb git://git.kernel.org/pub/scm/linux/kernel/git/ardb/linux.git
git fetch --no-tags ardb for-kernelci
git checkout 9a2235df531e427be5777a894b3fa355ce127894
# save the config file to linux build tree
mkdir build_dir
COMPILER_INSTALL_PATH=$HOME/0day COMPILER=clang make.cross W=1 O=build_dir ARCH=arm SHELL=/bin/bash

If you fix the issue, kindly add following tag as appropriate
Reported-by: kernel test robot <[email protected]>

All warnings (new ones prefixed by >>):

>> arch/arm/mach-footbridge/common.c:102:6: warning: no previous prototype for function 'dc21285_handle_irq' [-Wmissing-prototypes]
void dc21285_handle_irq(struct pt_regs *regs)
^
arch/arm/mach-footbridge/common.c:102:1: note: declare 'static' if the function is not intended to be used outside of this translation unit
void dc21285_handle_irq(struct pt_regs *regs)
^
static
1 warning generated.


vim +/dc21285_handle_irq +102 arch/arm/mach-footbridge/common.c

101
> 102 void dc21285_handle_irq(struct pt_regs *regs)
103 {
104 int irq;
105 do {
106 irq = dc21285_get_irq();
107 if (!irq)
108 break;
109
110 generic_handle_irq(irq);
111 } while (1);
112 }
113

---
0-DAY CI Kernel Test Service, Intel Corporation
https://lists.01.org/hyperkitty/list/[email protected]

2021-12-01 07:39:29

by Arnd Bergmann

Subject: Re: [ardb:for-kernelci 18/28] arch/arm/mach-footbridge/common.c:102:6: warning: no previous prototype for function 'dc21285_handle_irq'

On Wed, Dec 1, 2021 at 4:42 AM kernel test robot <[email protected]> wrote:
>
> arch/arm/mach-footbridge/common.c:102:1: note: declare 'static' if the function is not intended to be used outside of this translation unit

Correct, thanks for the report!

Ard, I assume you can fix this up in your tree.

Arnd

2021-12-01 11:14:02

by Ard Biesheuvel

Subject: Re: [ardb:for-kernelci 18/28] arch/arm/mach-footbridge/common.c:102:6: warning: no previous prototype for function 'dc21285_handle_irq'

On Wed, 1 Dec 2021 at 08:44, Arnd Bergmann <[email protected]> wrote:
>
> On Wed, Dec 1, 2021 at 4:42 AM kernel test robot <[email protected]> wrote:
> >
> > arch/arm/mach-footbridge/common.c:102:1: note: declare 'static' if the function is not intended to be used outside of this translation unit
>
> Correct, thanks for the report!
>
> Ard, I assume you can fix this up in your tree.
>

Sure.