2020-07-19 02:21:04

by Max Filippov

[permalink] [raw]
Subject: [PATCH 0/3] xtensa: add seccomp support

Hello,

this series adds support for seccomp filter on xtensa and updates
selftests/seccomp.

Max Filippov (3):
xtensa: expose syscall through user_pt_regs
xtensa: add seccomp support
selftests/seccomp: add xtensa support

.../seccomp/seccomp-filter/arch-support.txt | 2 +-
arch/xtensa/Kconfig | 15 +++++++++++++++
arch/xtensa/include/asm/Kbuild | 1 +
arch/xtensa/include/asm/thread_info.h | 5 ++++-
arch/xtensa/include/uapi/asm/ptrace.h | 3 ++-
arch/xtensa/kernel/ptrace.c | 8 +++++++-
tools/testing/selftests/seccomp/seccomp_bpf.c | 16 +++++++++++++++-
7 files changed, 45 insertions(+), 5 deletions(-)

--
2.20.1


2020-09-11 19:39:57

by Kees Cook

[permalink] [raw]
Subject: Re: [PATCH 0/3] xtensa: add seccomp support

On Sat, Jul 18, 2020 at 07:16:51PM -0700, Max Filippov wrote:
> Hello,
>
> this series adds support for seccomp filter on xtensa and updates
> selftests/seccomp.

Hi!

Firstly, thanks for adding seccomp support! :) I would, however, ask
that you CC maintainers on these kinds of changes for feedback. I was
surprised to find the changes in the seccomp selftests today in Linus's
tree. I didn't seem to get CCed on this series, even though
get_maintainers shows this:

$ ./scripts/get_maintainer.pl 0001-selftests-seccomp-add-xtensa-support.mbox
Kees Cook <[email protected]> (supporter:SECURE COMPUTING)
Andy Lutomirski <[email protected]> (reviewer:SECURE COMPUTING)
Will Drewry <[email protected]> (reviewer:SECURE COMPUTING)
Shuah Khan <[email protected]> (maintainer:KERNEL SELFTEST FRAMEWORK)
...

Regardless, I'm still glad to have more arch support! :) I'll send a
follow-up patch to refactor a bit of the selftest.

Thanks,

--
Kees Cook

2020-09-11 20:00:03

by Max Filippov

[permalink] [raw]
Subject: Re: [PATCH 0/3] xtensa: add seccomp support

On Fri, Sep 11, 2020 at 12:38 PM Kees Cook <[email protected]> wrote:
> On Sat, Jul 18, 2020 at 07:16:51PM -0700, Max Filippov wrote:
> > Hello,
> >
> > this series adds support for seccomp filter on xtensa and updates
> > selftests/seccomp.
>
> Hi!
>
> Firstly, thanks for adding seccomp support! :) I would, however, ask
> that you CC maintainers on these kinds of changes for feedback. I was
> surprised to find the changes in the seccomp selftests today in Linus's
> tree. I didn't seem to get CCed on this series, even though
> get_maintainers shows this:
>
> $ ./scripts/get_maintainer.pl 0001-selftests-seccomp-add-xtensa-support.mbox
> Kees Cook <[email protected]> (supporter:SECURE COMPUTING)
> Andy Lutomirski <[email protected]> (reviewer:SECURE COMPUTING)
> Will Drewry <[email protected]> (reviewer:SECURE COMPUTING)
> Shuah Khan <[email protected]> (maintainer:KERNEL SELFTEST FRAMEWORK)
> ...

Sorry about that. Looks like I've filtered out too much of the cc: list.
I'll fix my workflow.

> Regardless, I'm still glad to have more arch support! :) I'll send a
> follow-up patch to refactor a bit of the selftest.

--
Thanks.
-- Max